asked on

Do I require an update query?

Hi
I have three tables, one for client details, the other two are client reports and client visits.
They are related by ClientID, and thus are one to many (the one side being the client detail side).

I have a a main form, and two sub forms. The main form selects the client, and the two sub-forms select the latest report data and visit data. These two subforms are based on normal queries and work fine.

On my two subforms, I have a button whereby a user can 'add a new report' or 'visit' for a new month. This button in both cases is simply:
Private Sub NewMonth_Click()
On Error GoTo Err_NewMonth_Click
DoCmd.GoToRecord , , acNewRec
Exit_NewMonth_Click:
Exit Sub
Err_NewMonth_Click:
MsgBox Err.Description
Resume Exit_NewMonth_Click
End Sub

The problem is this:
When I click on 'new month' I cannot input data into the form. I can edit existing data that loads up but if i click new month it won't let me do it. Is this because of my relationships and 'joins'? Or is this because I don't have it set as an update query? Any help much appreciated!

peter57r

" Is this because of my relationships and 'joins'"

It could be.
Post the sql view of the recordsource of your problem subform.

bo8482

ASKER

here is SQL for one of the subforms, but the other is pretty similar....

thanks for any help

SELECT tblClientDetails.ClientNumber, tblLedgerRecStatus.MonthEndPackDate, tblLedgerRecStatus.SalesLedgerRecd, tblLedgerRecStatus.AgeingReserves, tblLedgerRecStatus.CreditorsLedgerReceived, tblLedgerRecStatus.BankStatementsReceived, tblLedgerRecStatus.ReconciliationRecd, tblLedgerRecStatus.ReconciliationProcessed, tblLedgerRecStatus.Contras, tblLedgerRecStatus.Notes
FROM tblClientDetails LEFT JOIN tblLedgerRecStatus ON tblClientDetails.ClientNumber = tblLedgerRecStatus.ClientNumber
WHERE (((tblClientDetails.ClientNumber)=[Forms]![EditAllRecords]![Combo15] And (tblClientDetails.ClientNumber) Is Not Null))
ORDER BY tblLedgerRecStatus.MonthEndPackDate DESC;

Open in new window

peter57r

If this is a subform is linked to the main form by client id then you don't want the client table involved at all.
All you need is the tblLedgerRecStatus table.

SELECT tblLedgerRecStatus.ClientNumber, tblLedgerRecStatus.MonthEndPackDate, tblLedgerRecStatus.SalesLedgerRecd, tblLedgerRecStatus.AgeingReserves, tblLedgerRecStatus.CreditorsLedgerReceived, tblLedgerRecStatus.BankStatementsReceived, tblLedgerRecStatus.ReconciliationRecd, tblLedgerRecStatus.ReconciliationProcessed, tblLedgerRecStatus.Contras, tblLedgerRecStatus.Notes
FROM tblLedgerRecStatus
ORDER BY tblLedgerRecStatus.MonthEndPackDate DESC;

bo8482

ASKER

OK I started to get automation errors when I removed that (not entirely sure why but I think because they were linked to the mainform via ClientNumber.)

I'm beginning to get a little muddled here....

The main form where you select the client number, should that be bound to a table? Or should I leave it unbound with a select query? (I want a combo box that lists all client numbers)

Then the two subforms - currently they are based on a query. Should I link these to the main form via client number child/parent? Or should i just use VBA/expression to input the client number that is selected in the main form? What is the best way of doing that do you think?

Thanks

ASKER CERTIFIED SOLUTION

peter57r

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

bo8482

ASKER

Sorry about the late reply, I had internet connection issues this morning...

That now works I'm pleased to say - however the form does not load up blank now - it loads up the first record in the query. How do I get rid of that, so that users don't accidentally keep changing the first record?

peter57r

Are you setting a default value for your combo box?

bo8482

ASKER

No I'm not. I've got criteria in the ClientNumber of myform.[clientnumber] and is not null

I then set default value to null in the form on load event.

I tried to remove the recordset and then update the recordset after update off the combo....but that returned #name? errors on load.

I think i'll have to just set the default value of my combo to the first record so that at least it does not look like the records in the subform are orphaned. Unless you have any ideas that can help?

peter57r

I don't see why you would get a record diplayed in the subform if there is no selection in the combo...
(unless you have a subform record that has no clientid set up?)

I am running a test form here as we go through this and on mine, the subform shows a new empty record when I open the main form.

bo8482

ASKER

I wonder if its anything to do with the wizard generated code - I used the wizard for my combo box...

Code is below.

I may try and rebuild the form from scratch to see if that works.

I will award the points though on the basis that you answered my original question of fixing the non-update issue....muchas gratias!

Private Sub Combo15_AfterUpdate()
    ' Find the record that matches the control.
    Me.Requery
    Dim rs As Object
    Me.RecordSource = "tblClientDetails"
    Set rs = Me.Recordset.Clone
    rs.FindFirst "[ClientNumber] = " & Str(Nz(Me![Combo15], 0))
    If Not rs.EOF Then Me.Bookmark = rs.Bookmark
    
    End Sub

Open in new window

peter57r

We appear to have switched back to a bound main form again (the code you have just posted would not be possible to create if the main form is unbound). You said earlier that you were using an unbound main for,
Some of the stuff I've posted is completely unnecessary if the main form is a bound form.

bo8482

ASKER

well that code stays in there whether it is bound or not....

I will try removing the code and unbinding the main form to see if that works