• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 538
  • Last Modified:

static variable - unresolved external symbol

Hi Experts,

I've got a class where I'm creating a static variable which is a pointer.  In the implementation file, in the cpp file, I reference this pointer and I get the unresolved external symbol...  What am I doing wrong?  I'm trying to implement a singleton ...   The code below is what I believe is just the essentials.....

Thanks,
Mike
///  this is the .h file.....
#include "afxdb.h"
class CMyClass
{
public:
           CMyClass();
          static CDatabase * m_pDatabase;   ////  if I comment out this line, no more error.......
}
 
///// cpp file:
CMyClass::CMyClass() {}
 
BOOL CMyClass::Connect()
{
        m_pDatabase = new CDatabase();
        return TRUE;
}

Open in new window

0
thready
Asked:
thready
  • 6
  • 5
1 Solution
 
mrjoltcolaCommented:
A static member variable is essentially a global variable with class scope. So declaring one is not the same as defining one.

So add this to your .cpp file, it will define the single memory variable that is a static member variable.



///// cpp file:
 
// define static members
static CDatabase * CMyClass::m_pDatabase;
 
 
CMyClass::CMyClass() {}
 
BOOL CMyClass::Connect()
{
        m_pDatabase = new CDatabase();
        return TRUE;
}

Open in new window

0
 
mrjoltcolaCommented:
All that said, this is a throwback to C compatibility. Newer languages implement it in the compiler, but C++ is compatible with C linkers which expect the variable to exist in one compilation unit.

Maybe we see this ugly feature go away in C++0x
0
 
threadyAuthor Commented:
I keep coming back to this solution - I know about it - then I forget it......  Then I do the same thing again...  This time I hope I remember it....  It's from my java background.....  works in java - makes me hate c++....  But you gotta hate java for how slow it is....  Thanks for the response!
0
VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

 
threadyAuthor Commented:
Hi mrjoltcola - i`m getting this error - I did as you said - I got this error - I then removed the declaration I made in the .h - I still get this error......  How come?

C2761: 'CMyDatabase *CMyClass::m_pDatabase' : member function redeclaration not allowed
0
 
mrjoltcolaCommented:
Something changed, it thinks you are declaring a member function. Post your code again so I can see.
0
 
threadyAuthor Commented:
It`s just that it thinks that m_pDatabase is a member function...  because of the :: operator perhaps?
0
 
threadyAuthor Commented:
I apologize - this is the error I am getting:

error C2720: 'CMyClass::m_pDatabase' : 'static ' storage-class specifier illegal on members
0
 
threadyAuthor Commented:
//  .h file:
class CDatabase;

class CMyClass
{
public:
     CMyClass();
     static CDatabase * m_pDatabase;
}

// .cpp file:
#include "afxdb.h"
static CDatabase * CMyClass::m_pDatabase;

///  with no other reference to m_pDatabase.....  (error c2720)
0
 
mrjoltcolaCommented:
You don't use the "static" keyword in the .cpp file, only in the .h file inside the class declaration. Another C throwback.
0
 
threadyAuthor Commented:
Compiles - thanks again mrjoltcola - and I like the name - sounds heavily caffeinated...
0
 
mrjoltcolaCommented:
Only sometimes!
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 6
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now