Solved

static variable - unresolved external symbol

Posted on 2009-04-14
11
506 Views
Last Modified: 2013-11-20
Hi Experts,

I've got a class where I'm creating a static variable which is a pointer.  In the implementation file, in the cpp file, I reference this pointer and I get the unresolved external symbol...  What am I doing wrong?  I'm trying to implement a singleton ...   The code below is what I believe is just the essentials.....

Thanks,
Mike
///  this is the .h file.....

#include "afxdb.h"

class CMyClass

{

public:

           CMyClass();

          static CDatabase * m_pDatabase;   ////  if I comment out this line, no more error.......

}

 

///// cpp file:

CMyClass::CMyClass() {}

 

BOOL CMyClass::Connect()

{

        m_pDatabase = new CDatabase();

        return TRUE;

}

Open in new window

0
Comment
Question by:thready
  • 6
  • 5
11 Comments
 
LVL 40

Accepted Solution

by:
mrjoltcola earned 500 total points
ID: 24143722
A static member variable is essentially a global variable with class scope. So declaring one is not the same as defining one.

So add this to your .cpp file, it will define the single memory variable that is a static member variable.



///// cpp file:
 

// define static members

static CDatabase * CMyClass::m_pDatabase;
 
 

CMyClass::CMyClass() {}

 

BOOL CMyClass::Connect()

{

        m_pDatabase = new CDatabase();

        return TRUE;

}

Open in new window

0
 
LVL 40

Expert Comment

by:mrjoltcola
ID: 24143751
All that said, this is a throwback to C compatibility. Newer languages implement it in the compiler, but C++ is compatible with C linkers which expect the variable to exist in one compilation unit.

Maybe we see this ugly feature go away in C++0x
0
 
LVL 1

Author Closing Comment

by:thready
ID: 31570213
I keep coming back to this solution - I know about it - then I forget it......  Then I do the same thing again...  This time I hope I remember it....  It's from my java background.....  works in java - makes me hate c++....  But you gotta hate java for how slow it is....  Thanks for the response!
0
 
LVL 1

Author Comment

by:thready
ID: 24143928
Hi mrjoltcola - i`m getting this error - I did as you said - I got this error - I then removed the declaration I made in the .h - I still get this error......  How come?

C2761: 'CMyDatabase *CMyClass::m_pDatabase' : member function redeclaration not allowed
0
 
LVL 40

Expert Comment

by:mrjoltcola
ID: 24144000
Something changed, it thinks you are declaring a member function. Post your code again so I can see.
0
6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

 
LVL 1

Author Comment

by:thready
ID: 24144020
It`s just that it thinks that m_pDatabase is a member function...  because of the :: operator perhaps?
0
 
LVL 1

Author Comment

by:thready
ID: 24144061
I apologize - this is the error I am getting:

error C2720: 'CMyClass::m_pDatabase' : 'static ' storage-class specifier illegal on members
0
 
LVL 1

Author Comment

by:thready
ID: 24144104
//  .h file:
class CDatabase;

class CMyClass
{
public:
     CMyClass();
     static CDatabase * m_pDatabase;
}

// .cpp file:
#include "afxdb.h"
static CDatabase * CMyClass::m_pDatabase;

///  with no other reference to m_pDatabase.....  (error c2720)
0
 
LVL 40

Expert Comment

by:mrjoltcola
ID: 24144112
You don't use the "static" keyword in the .cpp file, only in the .h file inside the class declaration. Another C throwback.
0
 
LVL 1

Author Comment

by:thready
ID: 24144125
Compiles - thanks again mrjoltcola - and I like the name - sounds heavily caffeinated...
0
 
LVL 40

Expert Comment

by:mrjoltcola
ID: 24144196
Only sometimes!
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Introduction: Database storage, where is the exe actually on the disc? Playing a game selected randomly (how to generate random numbers).  Error trapping with try..catch to help the code run even if something goes wrong. Continuing from the seve…
Introduction: Dialogs (2) modeless dialog and a worker thread.  Handling data shared between threads.  Recursive functions. Continuing from the tenth article about sudoku.   Last article we worked with a modal dialog to help maintain informat…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now