• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 371
  • Last Modified:

JavaScript tag not validating

I had to add some code supplied by an ad network company and the code they gave me took my page from zero validation errors to over 30 validation errors. Looking at it the w3c validator wants to see amphersands in their HTML version however the code will not work if I do that which must be from the sever end.

However, when look at the code I see no reason why the validator should require the HTML version. Can anyone out there shed some light on this? The only other supposition I came up with is that perhaps query parameters are simply not legal where they are using them but my gut tells me this is an oversight of the validator and it should be fixed.

Does anyone know for sure what the reality of the situation is?
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
  "//www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html....>
	<head>
		<title>Something</title>
	</head>
	<body....>
		....
		<script language="javascript" src="http://media.fastclick.net/w/get.media?sid=12345&m=6&tp=8&d=j&t=n"></script>
		<noscript>
			<a href="http://media.fastclick.net/w/click.here?sid=12345&m=6&c=1" target="_blank">
				<img src="http://media.fastclick.net/w/get.media?sid=12345&m=6&tp=8&d=s&c=1" width=300 height=250 border=1>
			</a>
		</noscript>
		....
	</body>
</html>

Open in new window

0
RegProctor
Asked:
RegProctor
1 Solution
 
QualitySoftwareDevelopmentCommented:
Is it not just a question of which HTML version you set wether it works or not?
0
 
naspinskiCommented:
You are validating to XHTML 1.0 Strict, which, as it implies is very strict.  Any reason you choose to validate to this level?  Your website will be evaluated with the guidelines for ehichever version of html you tell it to validate to, you are picking one of the highest levels, so it will require more to get it to validate.
0
 
David S.Commented:
The protocol is missing from the URL in the doctype?

Anyway the other errors are because that code is not even valid HTML 4.01 Transitional.

Each of the "&" needs to be changed to "&amp;"

language="javascript"  should be type="text/javascript"

Quotes are required for the values of attributes.

The <img> tag is unclosed.

CSS should be used instead of the border attribute.

The <a> element should be in a <p> or <div>.
                <script type="text/javascript" src="http://media.fastclick.net/w/get.media?sid=12345&amp;m=6&amp;tp=8&amp;d=j&amp;t=n"></script>
                <noscript>
                        <p><a href="http://media.fastclick.net/w/click.here?sid=12345&amp;m=6&amp;c=1" target="_blank">
                                <img src="http://media.fastclick.net/w/get.media?sid=12345&amp;m=6&amp;tp=8&amp;d=s&amp;c=1" width="300" height="250" />
                        </a></p>
                </noscript>

Open in new window

0
Ultimate Tool Kit for Technology Solution Provider

Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.

 
RegProctorAuthor Commented:
Hello naspinski, yes, I always code in the highest level of strictness. I am a programmer and I am used to well formed coding.

You made a lot of points Kravimer, I'll go through them as best I can:

By dropping the http in the doc type it can be used for both http & https. You will have to be okay with a warning from the validator but it's a useful trick if you don't want browsers throwing errors because you have the wrong protocol in the doc type.

If you read the question, I was asking if <code>&amp;</code> was needed in the JavaScript tag because the browser was not translating that to a <code>&</code> so of course the code is going to show them as just ampersands.

Language, img etc. Oops! I copied the wrong code over. This was their original code, not the code changed for strict specs. - sorry.

In any case you helped me look at this again and I found an error before the JavaScript tag and that I guess was throwing off the browser from translating the <code>&amp;</code> since once I fixed the preceding error it validated just fine and their server picked it up the query string just fine.
0
 
RegProctorAuthor Commented:
Not the exact answer but it was one of those times when you just need someone else to help you see things clearly, thanks.
0
 
David S.Commented:
Which browsers have given you a security warning because of the URL in a doctype?
0
 
RegProctorAuthor Commented:
It was a long time ago that I solved that problem and I don't really remember much more than the problem in general. Sorry, I just don't have that detail in my mind anymore.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: Microsoft Azure 2017

Azure has a changed a lot since it was originally introduce by adding new services and features. Do you know everything you need to about Azure? This course will teach you about the Azure App Service, monitoring and application insights, DevOps, and Team Services.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now