Want to win a PS4? Go Premium and enter to win our High-Tech Treats giveaway. Enter to Win

x
?
Solved

Nested if else statements giving error

Posted on 2009-04-15
6
Medium Priority
?
553 Views
Last Modified: 2013-12-14
I have the following nested if else statement and it keeps giving me the error that it has an illefal else without matching if .  I've tried playing with the brackets and can't get it to work.  Can someone point out where the problem is?  Thanks in advance!
if (!bEndOfDay)
	{
		if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))
		{
			update_detail("Error in moving data from ....");
			uRetVal = FALSE;
		}
		else
		{
			if (g_SysCfg.IsVerbose())
				update_detail("Data moved from to .....");
		}
	}
	else
	{
		if (!MoveBulkData(csBulkTable,pSqlDb))
		{
			update_detail("Error in moving data from ....");
			uRetVal = FALSE;
		}
		else
		{
			if (g_SysCfg.IsVerbose())
				update_detail("Data moved from to .....");
		}
	}
	else
	{
		if (!MoveAlertData(csAPAlertTable,pSqlDb))
		{
			update_detail("Error in moving data from ....");
			uRetVal = FALSE;
		}
		else
		{
			if (g_SysCfg.IsVerbose())
				update_detail("Data moved from to .....");
		}
	}
	return uRetVal;

Open in new window

0
Comment
Question by:Cashmgmt
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 3
6 Comments
 
LVL 86

Expert Comment

by:jkr
ID: 24149528
Well, take a look at your code, there's indeed one 'else' that has no 'if':
if (!bEndOfDay)
        {
                if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        }
        else
        {
                if (!MoveBulkData(csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        } // <---------- if (!bEndOfDay) ends here
 
        else // <----------- there's no if for that one
        {
                if (!MoveAlertData(csAPAlertTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        }
        return uRetVal;

Open in new window

0
 

Author Comment

by:Cashmgmt
ID: 24149846
Yeah, I see it and that's where the program is stopping when I try to build, but I'm new to programming and I can't figure out how to make the else that's causing the error part of the if (!bEndOfDay).  can you help?
0
 
LVL 86

Expert Comment

by:jkr
ID: 24150075
Well, that's pretty hard, since that's not a complete function and I have no idea what it is supposed to do ;o)

Well, is 'MoveAlertData()' supposed to execute when 'bEndOfDay' is 'true' or 'false' or under what other condition?
0
Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

 

Author Comment

by:Cashmgmt
ID: 24150098
if bEndOfDay is false, then i need it to do the MoveDate then MoveBulkDate then MoveAlertData
0
 
LVL 86

Accepted Solution

by:
jkr earned 1000 total points
ID: 24150121
Then, you don't need ansy 'else' for 'if (!bEndOfDay)':
if (!bEndOfDay)
        {
                if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        
                if (!MoveBulkData(csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        
                if (!MoveAlertData(csAPAlertTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        }
        return uRetVal;

Open in new window

0
 

Author Closing Comment

by:Cashmgmt
ID: 31570530
You're absolutely right.  So obvious and I didn't see it.  Thanks, that worked!!!
0

Featured Post

Enroll in October's Free Course of the Month

Do you work with and analyze data? Enroll in October's Course of the Month for 7+ hours of SQL training, allowing you to quickly and efficiently store or retrieve data. It's free for Premium Members, Team Accounts, and Qualified Experts!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Templates For Beginners Or How To Encourage The Compiler To Work For You Introduction This tutorial is targeted at the reader who is, perhaps, familiar with the basics of C++ but would prefer a little slower introduction to the more ad…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
The viewer will learn how to use and create keystrokes in Netbeans IDE 8.0 for Windows.
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

610 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question