Solved

Nested if else statements giving error

Posted on 2009-04-15
6
541 Views
Last Modified: 2013-12-14
I have the following nested if else statement and it keeps giving me the error that it has an illefal else without matching if .  I've tried playing with the brackets and can't get it to work.  Can someone point out where the problem is?  Thanks in advance!
if (!bEndOfDay)

	{

		if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))

		{

			update_detail("Error in moving data from ....");

			uRetVal = FALSE;

		}

		else

		{

			if (g_SysCfg.IsVerbose())

				update_detail("Data moved from to .....");

		}

	}

	else

	{

		if (!MoveBulkData(csBulkTable,pSqlDb))

		{

			update_detail("Error in moving data from ....");

			uRetVal = FALSE;

		}

		else

		{

			if (g_SysCfg.IsVerbose())

				update_detail("Data moved from to .....");

		}

	}

	else

	{

		if (!MoveAlertData(csAPAlertTable,pSqlDb))

		{

			update_detail("Error in moving data from ....");

			uRetVal = FALSE;

		}

		else

		{

			if (g_SysCfg.IsVerbose())

				update_detail("Data moved from to .....");

		}

	}

	return uRetVal;

Open in new window

0
Comment
Question by:Cashmgmt
  • 3
  • 3
6 Comments
 
LVL 86

Expert Comment

by:jkr
ID: 24149528
Well, take a look at your code, there's indeed one 'else' that has no 'if':
if (!bEndOfDay)

        {

                if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))

                {

                        update_detail("Error in moving data from ....");

                        uRetVal = FALSE;

                }

                else

                {

                        if (g_SysCfg.IsVerbose())

                                update_detail("Data moved from to .....");

                }

        }

        else

        {

                if (!MoveBulkData(csBulkTable,pSqlDb))

                {

                        update_detail("Error in moving data from ....");

                        uRetVal = FALSE;

                }

                else

                {

                        if (g_SysCfg.IsVerbose())

                                update_detail("Data moved from to .....");

                }

        } // <---------- if (!bEndOfDay) ends here
 

        else // <----------- there's no if for that one

        {

                if (!MoveAlertData(csAPAlertTable,pSqlDb))

                {

                        update_detail("Error in moving data from ....");

                        uRetVal = FALSE;

                }

                else

                {

                        if (g_SysCfg.IsVerbose())

                                update_detail("Data moved from to .....");

                }

        }

        return uRetVal;

Open in new window

0
 

Author Comment

by:Cashmgmt
ID: 24149846
Yeah, I see it and that's where the program is stopping when I try to build, but I'm new to programming and I can't figure out how to make the else that's causing the error part of the if (!bEndOfDay).  can you help?
0
 
LVL 86

Expert Comment

by:jkr
ID: 24150075
Well, that's pretty hard, since that's not a complete function and I have no idea what it is supposed to do ;o)

Well, is 'MoveAlertData()' supposed to execute when 'bEndOfDay' is 'true' or 'false' or under what other condition?
0
Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

 

Author Comment

by:Cashmgmt
ID: 24150098
if bEndOfDay is false, then i need it to do the MoveDate then MoveBulkDate then MoveAlertData
0
 
LVL 86

Accepted Solution

by:
jkr earned 250 total points
ID: 24150121
Then, you don't need ansy 'else' for 'if (!bEndOfDay)':
if (!bEndOfDay)

        {

                if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))

                {

                        update_detail("Error in moving data from ....");

                        uRetVal = FALSE;

                }

                else

                {

                        if (g_SysCfg.IsVerbose())

                                update_detail("Data moved from to .....");

                }

        

                if (!MoveBulkData(csBulkTable,pSqlDb))

                {

                        update_detail("Error in moving data from ....");

                        uRetVal = FALSE;

                }

                else

                {

                        if (g_SysCfg.IsVerbose())

                                update_detail("Data moved from to .....");

                }

        

                if (!MoveAlertData(csAPAlertTable,pSqlDb))

                {

                        update_detail("Error in moving data from ....");

                        uRetVal = FALSE;

                }

                else

                {

                        if (g_SysCfg.IsVerbose())

                                update_detail("Data moved from to .....");

                }

        }

        return uRetVal;

Open in new window

0
 

Author Closing Comment

by:Cashmgmt
ID: 31570530
You're absolutely right.  So obvious and I didn't see it.  Thanks, that worked!!!
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Suggested Solutions

What is C++ STL?: STL stands for Standard Template Library and is a part of standard C++ libraries. It contains many useful data structures (containers) and algorithms, which can spare you a lot of the time. Today we will look at the STL Vector. …
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now