Solved

Nested if else statements giving error

Posted on 2009-04-15
6
549 Views
Last Modified: 2013-12-14
I have the following nested if else statement and it keeps giving me the error that it has an illefal else without matching if .  I've tried playing with the brackets and can't get it to work.  Can someone point out where the problem is?  Thanks in advance!
if (!bEndOfDay)
	{
		if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))
		{
			update_detail("Error in moving data from ....");
			uRetVal = FALSE;
		}
		else
		{
			if (g_SysCfg.IsVerbose())
				update_detail("Data moved from to .....");
		}
	}
	else
	{
		if (!MoveBulkData(csBulkTable,pSqlDb))
		{
			update_detail("Error in moving data from ....");
			uRetVal = FALSE;
		}
		else
		{
			if (g_SysCfg.IsVerbose())
				update_detail("Data moved from to .....");
		}
	}
	else
	{
		if (!MoveAlertData(csAPAlertTable,pSqlDb))
		{
			update_detail("Error in moving data from ....");
			uRetVal = FALSE;
		}
		else
		{
			if (g_SysCfg.IsVerbose())
				update_detail("Data moved from to .....");
		}
	}
	return uRetVal;

Open in new window

0
Comment
Question by:Cashmgmt
  • 3
  • 3
6 Comments
 
LVL 86

Expert Comment

by:jkr
ID: 24149528
Well, take a look at your code, there's indeed one 'else' that has no 'if':
if (!bEndOfDay)
        {
                if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        }
        else
        {
                if (!MoveBulkData(csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        } // <---------- if (!bEndOfDay) ends here
 
        else // <----------- there's no if for that one
        {
                if (!MoveAlertData(csAPAlertTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        }
        return uRetVal;

Open in new window

0
 

Author Comment

by:Cashmgmt
ID: 24149846
Yeah, I see it and that's where the program is stopping when I try to build, but I'm new to programming and I can't figure out how to make the else that's causing the error part of the if (!bEndOfDay).  can you help?
0
 
LVL 86

Expert Comment

by:jkr
ID: 24150075
Well, that's pretty hard, since that's not a complete function and I have no idea what it is supposed to do ;o)

Well, is 'MoveAlertData()' supposed to execute when 'bEndOfDay' is 'true' or 'false' or under what other condition?
0
Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

 

Author Comment

by:Cashmgmt
ID: 24150098
if bEndOfDay is false, then i need it to do the MoveDate then MoveBulkDate then MoveAlertData
0
 
LVL 86

Accepted Solution

by:
jkr earned 250 total points
ID: 24150121
Then, you don't need ansy 'else' for 'if (!bEndOfDay)':
if (!bEndOfDay)
        {
                if (!MoveData(csTblName, csBlobTable, csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        
                if (!MoveBulkData(csBulkTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        
                if (!MoveAlertData(csAPAlertTable,pSqlDb))
                {
                        update_detail("Error in moving data from ....");
                        uRetVal = FALSE;
                }
                else
                {
                        if (g_SysCfg.IsVerbose())
                                update_detail("Data moved from to .....");
                }
        }
        return uRetVal;

Open in new window

0
 

Author Closing Comment

by:Cashmgmt
ID: 31570530
You're absolutely right.  So obvious and I didn't see it.  Thanks, that worked!!!
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

  Included as part of the C++ Standard Template Library (STL) is a collection of generic containers. Each of these containers serves a different purpose and has different pros and cons. It is often difficult to decide which container to use and …
Update (December 2011): Since this article was published, the things have changed for good for Android native developers. The Sequoyah Project (http://www.eclipse.org/sequoyah/) automates most of the tasks discussed in this article. You can even fin…
The viewer will learn how to use NetBeans IDE 8.0 for Windows to connect to a MySQL database. Open Services Panel: Create a new connection using New Connection Wizard: Create a test database called eetutorial: Create a new test tabel called ee…
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.

825 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question