Javascript function question

I am not sure if it helps but shouldn't this function looks like that?

 function gettax(total){
 
     if (form.state.value = "CA") {
         form.total.value = form.sub_tot.value + (form.sub_tot.value * tax_amt);
     }
     else {
         form.total.value = form.sub_tot.value;
         document.order_form.total.focus();
     }
 }

Select allOpen in new window

No, use a double == sign!

if (form.state.value == "CA")  ...

Select allOpen in new window

That helped because with my poorly formed code before the total field wan't showing up on the page at all, now it shows up, but it still won't change to to revised total with the tax amount included when I add CA to the state field.

How about

function gettax( total ) {
  form.total.value = form.sub_tot.value + ( form.sub_tot.value * ( ( form.state.value == "CA" ) ? 1 : 0 ) )
  document.order_form.total.focus();
}

Select allOpen in new window

Thanks for all your help so far this is definitely getting me closer but, still didn't work.
The total field still only shows the sub_tot value and doesn't updade to the new tax value when CA is put in the "state field"

ok,  how about this?

function gettax( total ) {
  var sub = parseFloat( form.sub_tot.value )
  var CA  = ( form.state.value == "CA" )
  form.total.value = ( sub + ( ( CA ? 1 : 0 ) * tax_amt ) ).toFixed( 2 )
  document.order_form.total.focus();
}

Select allOpen in new window

no, sorry, still didn't work.

If it helps this is the page I am working on.

https://secure2.spiralweb.com/~dadsbourbonballs/products1.php

but the order process actually begins here:

https://secure2.spiralweb.com/~dadsbourbonballs/products.php

hm.  total isn't being used, so I guess it isn't needed as a parameter...

I don't see where on that page that you have, or call the gettax() function.

Let's see what is happening...

function gettax() {
  alert( 'enter gettax(): #parms=' + arguments.length )
  var sub = parseFloat( form.sub_tot.value )
  alert( 'subtotal: ' + sub )
  var CA  = ( form.state.value == "CA" )
  alert( 'State: "' + form.state.value + '"  CA=' + CA )
  form.total.value = ( sub + ( ( CA ? 1 : 0 ) * tax_amt ) ).toFixed( 2 )
  document.order_form.total.focus();
  alert( ' exit gettax() total = ' + form.total.value )
}

Select allOpen in new window

ok, I put that function on the page

what output did you see when the function is called/invoked?

It didn't do anything. There was no alert box. How should I have called the function? I typed CA into the state field, which i thought would work, but it didn't

enter gettax(): #parms=0

ok, that's it though?

Then form.sub_tot.value must not be valid.

In most instances of functions already on the page, you pass a reference to the form object.  I bet that's the problem...

How/where do you call gettax() ?

I didn't have a call for it before, so that was the problem. But I guess I don't really know how to properly call the function to make it work in the form.

I tried this, and it made the alert appear but it made the other Javascript validation function stop working.

<FORM name="order_form" action="products2.php" method="post" onsubmit="return validateFormOnSubmit(this), gettax() ">

what did it look like before?

<FORM name="order_form" action="products2.php" method="post" onsubmit="return validateFormOnSubmit(this)">

ok, What show me what this function looks like:

validateFormOnSubmit()

All the validation code is below, the first part is the function being called in the form.

function validateFormOnSubmit(theForm) {
var reason = "";
 
  reason += validateEmpty(theForm.fname);
  reason += validateEmpty(theForm.lname);
  reason += validateEmpty(theForm.address1);
  reason += validateEmpty(theForm.city);
  reason += validateEmpty(theForm.state);
  reason += validateEmail(theForm.email);
  reason += validatePhone(theForm.phone);
      
  if (reason != "") {
    alert("Some fields need correction:\n" + reason);
    return false;
  }
 
  return true;
}
 
function validateEmpty(fld) {
    var error = "";
 
    if (fld.value.length == 0) {
        fld.style.background = 'Yellow'; 
        error = "The required field has not been filled in.\n"
    } else {
        fld.style.background = 'White';
    }
    return error;  
}
 
function validateUsername(fld) {
    var error = "";
    var illegalChars = /\W/; // allow letters, numbers, and underscores
 
    if (fld.value == "") {
        fld.style.background = 'Yellow'; 
        error = "You didn't enter a username.\n";
    } else if ((fld.value.length < 5) || (fld.value.length > 15)) {
        fld.style.background = 'Yellow'; 
        error = "The username is the wrong length.\n";
    } else if (illegalChars.test(fld.value)) {
        fld.style.background = 'Yellow'; 
        error = "The username contains illegal characters.\n";
    } else {
        fld.style.background = 'White';
    }
    return error;
}
 
function validatePassword(fld) {
    var error = "";
    var illegalChars = /[\W_]/; // allow only letters and numbers 
 
    if (fld.value == "") {
        fld.style.background = 'Yellow';
        error = "You didn't enter a password.\n";
    } else if ((fld.value.length < 7) || (fld.value.length > 15)) {
        error = "The password is the wrong length. \n";
        fld.style.background = 'Yellow';
    } else if (illegalChars.test(fld.value)) {
        error = "The password contains illegal characters.\n";
        fld.style.background = 'Yellow';
    } else if (!((fld.value.search(/(a-z)+/)) && (fld.value.search(/(0-9)+/)))) {
        error = "The password must contain at least one numeral.\n";
        fld.style.background = 'Yellow';
    } else {
        fld.style.background = 'White';
    }
   return error;
}   
 
function trim(s)
{
  return s.replace(/^\s+|\s+$/, '');
}
 
function validateEmail(fld) {
    var error="";
    var tfld = trim(fld.value);                        // value of field with whitespace trimmed off
    var emailFilter = /^[^@]+@[^@.]+\.[^@]*\w\w$/ ;
    var illegalChars= /[\(\)\<\>\,\;\:\\\"\[\]]/ ;
   
    if (fld.value == "") {
        fld.style.background = 'Yellow';
        error = "You didn't enter an email address.\n";
    } else if (!emailFilter.test(tfld)) {              //test email for illegal characters
        fld.style.background = 'Yellow';
        error = "Please enter a valid email address.\n";
    } else if (fld.value.match(illegalChars)) {
        fld.style.background = 'Yellow';
        error = "The email address contains illegal characters.\n";
    } else {
        fld.style.background = 'White';
    }
    return error;
}
 
function validatePhone(fld) {
    var error = "";
    var stripped = fld.value.replace(/[\(\)\.\-\ ]/g, '');    
 
   if (fld.value == "") {
        error = "You didn't enter a phone number.\n";
        fld.style.background = 'Yellow';
    } else if (isNaN(parseInt(stripped))) {
        error = "The phone number contains illegal characters.\n";
        fld.style.background = 'Yellow';
    } else if (!(stripped.length == 10)) {
        error = "The phone number is the wrong length. Make sure you included an area code.\n";
        fld.style.background = 'Yellow';
    }
    return error;
}

Select allOpen in new window

Ok, that worked, which is great, but total field only updates after you hit the form's submit button. Is there a way to make the form total field update with the revised total amount after "CA" has been placed inside the State field?

Maybe you could use onblur event on State field for that?

I tried adding what you suggested and I could no longer type in the State field on the form. Do you know what I am doing wrong with the blur?

<input name="state" type="text" id="state"  onChange="javascript:copy()" onfocus="this.blur()" size="3" maxlength="3">

Select allOpen in new window

Thanks for hanging in there with me guys!

Thanks for the grade & points.

Good luck & have a great day.