Perl only will not process all items in loop.

#!/usr/bin/perl
 
#BEGIN {
#open (STDERR, ">../public_html/error.txt");
#}
 
use CGI ':standard';
use CGI::Carp qw(fatalsToBrowser);  
 
#--------------------------------------------------
# retrieve itemno
#--------------------------------------------------
 
$itemno = $ENV{'QUERY_STRING'};
 
$terminator = $itemno . "\xff";
 
#--------------------------------------------------
# open file  
#--------------------------------------------------
open (FILE, "../public_html/files/testdata.txt") || die (print "Could not open file.");
 
while (<FILE>) {
   chomp;
   ($item, $category, $subcategory, $filename, $description) = split("\t");
 
   next if ($item lt /$itemno/i);
 
   #exit loop if item is after one we are looking for
   last if ($item ge $terminator);
 
   #look for fileno (multiple matches possible)
   next if (($itemno) && ! ($item==$itemno));
 
   #matched
   if(($item == $itemno) && ($category eq "P")){
      download_file($filename,$itemno);
   }
}
 
print "Location: http://www.mydomain.com/public_html/printorderthanks.html\n\n";
 
#--------------------------------------------------
# DOWNLOAD FILES
#--------------------------------------------------
sub download_file {
my $files_location;  
my $ID;  
my @fileholder;
 
   ($cookiename, $cookievalue) = split(/=/,$ENV{HTTP_COOKIE});
 
	$files_location = "../public_html/files";
 
	$ID = $_[0];
	$fileno = $_[1];
 
	if ($ID eq '') {  
 	  	print "Content-type: text/html\n\n";  
   		print "You must specify a file to download.";  
	} else {
 
   		open(DLFILE, "<$files_location/$ID") || Error('open', 'file');  
   		@fileholder = <DLFILE>;  
   		close (DLFILE) || Error ('close', 'file');  
 
   		open (LOG, ">>../public_html/files/downloadfile.log") || Error('open', 'file');
   		print LOG scalar localtime();
   		print LOG ", $cookievalue, ";
   		print LOG "$fileno, $ID\n";
   		close (LOG);
 
   		print "Content-Type:application/x-download\n";  
   		print "Content-Disposition:attachment;filename=$ID\n\n";
   		print @fileholder
	}
   return 1;
}
 
sub Error {
   print "Content-type: text/html\n\n";
   print "The server can't $_[0] the $_[1]: $! \n";
   exit;
}

Select allOpen in new window