• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 271
  • Last Modified:

Run-time Check Failure #2

I'm new to C++ and my program works, but I keep getting the following error:

Run-time check failure #2 - stack around the variable "ranNumArray" was corrupted.

I'm not sure why this is happening, can some please help!  Thanks a lot.
int main (void)
{
 
int ranNumber;
int ranNumArray[100];
int i;
 
int numFind;
int arrayPos;
int foundNum = 0;
 
  /* initialize random seed: */
  srand (1);
 
  /* generate secret number: */
for(i=0; i< 101; i++) {
  ranNumber = rand() % 100 + 1;
  ranNumArray[i] = ranNumber;
  cout<<i<<" "<<ranNumArray[i]<<endl;	
}
 
     int max = ranNumArray[0]; 
 
     for(int i = 1; i<101; i++)
     {
          if(ranNumArray[i] > max)
                max = ranNumArray[i];
     }
 
 cout<<"The Max is "<<max<<endl;
 
 cout<<"Please enter a number to find:";
 cin>>numFind;   
 
     for(int x = 0; x<101; x++)
     {
          if(ranNumArray[x] == numFind) {
          		cout<<"The position of your number is "<<x<<endl;
                foundNum = 1;
          }
 
     }
  
  if(foundNum == 0){
  	cout<<"Not Found";
    }
     
return 0; 
}

Open in new window

0
trifecta2k
Asked:
trifecta2k
1 Solution
 
mrjoltcolaCommented:
Your problems are the for loops, looping 1 too many. It goes past the end of the array. Array of 100 means 0 - 99 in C++
for(i=0; i< 101; i++)  // 101 slots, one too many
 
for(int x = 0; x<101; x++) // 101 slots, one too many
 
 
Instead use
//
for(i=0; i< 100; i++)  // 100 slots
 
for(int x=0; x< 100; x++)  // 100 slots

Open in new window

0
 
itsmeandnobodyelseCommented:
Alternatively to that mrjoltcola said, you could do


     for(int i = 1; i<=100; i++)
     {
          if(ranNumArray[i-1] > max)
          ...

That way your loop counter is 1-based what might give some benefits if using it as an ID-number.

But actually this is more error-prone than that mrjoltcola suggested.

>>>>      for(int i = 1; i<101; i++)

Never use 101 as upper boundary if the size is 100. That is very error-prone even if using a 1-based counter.

Generally, if using fixed-sized arrays you might consider the following:

 for(int i = 0; i < sizeof(ranNumArray)/sizeof(ranNumArray[0]); i++)

With that you could change the size and type of array without having to change the for loop as well.

0
 
emilmgeorgeCommented:
int main (void)
{
 
int ranNumber;
int ranNumArray[100];
int i;
 
int numFind;
int arrayPos;
int foundNum = 0;
 
  /* initialize random seed: */
  srand (1);
 
  /* generate secret number: */
for(i=0; i< 100; i++) {
  ranNumber = rand() % 100 + 1;
  ranNumArray[i] = ranNumber;
  cout<<i<<" "<<ranNumArray[i]<<endl;  
}
 
     int max = ranNumArray[0];
 
     for(int i = 1; i<100; i++)
     {
          if(ranNumArray[i] > max)
                max = ranNumArray[i];
     }
 
 cout<<"The Max is "<<max<<endl;
 
 cout<<"Please enter a number to find:";
 cin>>numFind;  
 
     for(int x = 0; x<100; x++)
     {
          if(ranNumArray[x] == numFind) {
                        cout<<"The position of your number is "<<x<<endl;
                foundNum = 1;
          }
 
     }
 
  if(foundNum == 0){
        cout<<"Not Found";
    }
     
return 0;
}
0
 
trifecta2kAuthor Commented:
Thanks, that worked perfectly.  
0

Featured Post

Never miss a deadline with monday.com

The revolutionary project management tool is here!   Plan visually with a single glance and make sure your projects get done.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now