Solved

Run-time Check Failure #2

Posted on 2009-05-03
4
255 Views
Last Modified: 2012-05-06
I'm new to C++ and my program works, but I keep getting the following error:

Run-time check failure #2 - stack around the variable "ranNumArray" was corrupted.

I'm not sure why this is happening, can some please help!  Thanks a lot.
int main (void)
{
 
int ranNumber;
int ranNumArray[100];
int i;
 
int numFind;
int arrayPos;
int foundNum = 0;
 
  /* initialize random seed: */
  srand (1);
 
  /* generate secret number: */
for(i=0; i< 101; i++) {
  ranNumber = rand() % 100 + 1;
  ranNumArray[i] = ranNumber;
  cout<<i<<" "<<ranNumArray[i]<<endl;	
}
 
     int max = ranNumArray[0]; 
 
     for(int i = 1; i<101; i++)
     {
          if(ranNumArray[i] > max)
                max = ranNumArray[i];
     }
 
 cout<<"The Max is "<<max<<endl;
 
 cout<<"Please enter a number to find:";
 cin>>numFind;   
 
     for(int x = 0; x<101; x++)
     {
          if(ranNumArray[x] == numFind) {
          		cout<<"The position of your number is "<<x<<endl;
                foundNum = 1;
          }
 
     }
  
  if(foundNum == 0){
  	cout<<"Not Found";
    }
     
return 0; 
}

Open in new window

0
Comment
Question by:trifecta2k
4 Comments
 
LVL 40

Accepted Solution

by:
mrjoltcola earned 500 total points
ID: 24292547
Your problems are the for loops, looping 1 too many. It goes past the end of the array. Array of 100 means 0 - 99 in C++
for(i=0; i< 101; i++)  // 101 slots, one too many
 
for(int x = 0; x<101; x++) // 101 slots, one too many
 
 
Instead use
//
for(i=0; i< 100; i++)  // 100 slots
 
for(int x=0; x< 100; x++)  // 100 slots

Open in new window

0
 
LVL 39

Expert Comment

by:itsmeandnobodyelse
ID: 24294096
Alternatively to that mrjoltcola said, you could do


     for(int i = 1; i<=100; i++)
     {
          if(ranNumArray[i-1] > max)
          ...

That way your loop counter is 1-based what might give some benefits if using it as an ID-number.

But actually this is more error-prone than that mrjoltcola suggested.

>>>>      for(int i = 1; i<101; i++)

Never use 101 as upper boundary if the size is 100. That is very error-prone even if using a 1-based counter.

Generally, if using fixed-sized arrays you might consider the following:

 for(int i = 0; i < sizeof(ranNumArray)/sizeof(ranNumArray[0]); i++)

With that you could change the size and type of array without having to change the for loop as well.

0
 

Expert Comment

by:emilmgeorge
ID: 24295905
int main (void)
{
 
int ranNumber;
int ranNumArray[100];
int i;
 
int numFind;
int arrayPos;
int foundNum = 0;
 
  /* initialize random seed: */
  srand (1);
 
  /* generate secret number: */
for(i=0; i< 100; i++) {
  ranNumber = rand() % 100 + 1;
  ranNumArray[i] = ranNumber;
  cout<<i<<" "<<ranNumArray[i]<<endl;  
}
 
     int max = ranNumArray[0];
 
     for(int i = 1; i<100; i++)
     {
          if(ranNumArray[i] > max)
                max = ranNumArray[i];
     }
 
 cout<<"The Max is "<<max<<endl;
 
 cout<<"Please enter a number to find:";
 cin>>numFind;  
 
     for(int x = 0; x<100; x++)
     {
          if(ranNumArray[x] == numFind) {
                        cout<<"The position of your number is "<<x<<endl;
                foundNum = 1;
          }
 
     }
 
  if(foundNum == 0){
        cout<<"Not Found";
    }
     
return 0;
}
0
 
LVL 5

Author Closing Comment

by:trifecta2k
ID: 31577439
Thanks, that worked perfectly.  
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

What is C++ STL?: STL stands for Standard Template Library and is a part of standard C++ libraries. It contains many useful data structures (containers) and algorithms, which can spare you a lot of the time. Today we will look at the STL Vector. …
C++ Properties One feature missing from standard C++ that you will find in many other Object Oriented Programming languages is something called a Property (http://www.experts-exchange.com/Programming/Languages/CPP/A_3912-Object-Properties-in-C.ht…
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.

790 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question