Solved

Looping through directory for file and do a word count

Posted on 2009-05-04
5
697 Views
Last Modified: 2013-12-26
Hello All.

I am working on a script which basically loop through a directory for files and does a word count for each file and if the file has more than 1 row then writes that filename to a log file.

1. Loop thorugh a directory and pick up files
2. do a word count on each file
3. write the filename to a logfile only if the file has more than 1 record.

I have a written some code and it works but it is writing all files to logfile
for file in `ls`
do
 Count=`echo cat $file |  wc -l`
echo " my count is $Count"
if [ "$count" -gt 1 ];
then
echo $count
echo $file >> /home/log.txt
else
 echo "there is no file to write"
fi
done

Open in new window

0
Comment
Question by:antvu
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
5 Comments
 
LVL 8

Expert Comment

by:mostart
ID: 24295835
watch your case. $Count is initialized with capital C and later you are using lower case c..
0
 

Author Comment

by:antvu
ID: 24295936
I  changed the case with upper case C and executed the script.. below is the result i got
my count is 1
there is no file to write
 my count is 1
there is no file to write
 my count is 1
there is no file to write
 my count is 1
there is no file to write
___________________________

I have 4 files in the directory , one of the files has 1 record and other 3 have more than 1 ..
0
 
LVL 8

Accepted Solution

by:
mostart earned 50 total points
ID: 24295967
also remove the "echo" in line 3.
0
 

Author Comment

by:antvu
ID: 24295991
Thanks mostart.. that worked.
I am closing the question now.
0
 
LVL 48

Expert Comment

by:Tintin
ID: 24299015
Let's remove redundant code and shorten
#!/bin/bash
for file in *
do
  [ -f $file ] || continue  # Skip non-files
  lines=$(wc -l <$file)
  [ $lines -gt 1 ] && echo $file >>/home/log.txt
done

Open in new window

0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Over the years I've spent many an hour playing on hardened, DMZ'd servers, with only a sub-set of the usual GNU toy's to keep me company; frequently I've needed to save and send log or data extracts from these server back to my PC, or to others, and…
Have you ever been frustrated by having to click seven times in order to retrieve a small bit of information from the web, always the same seven clicks, scrolling down and down until you reach your target? When you know the benefits of the command l…
Learn several ways to interact with files and get file information from the bash shell. ls lists the contents of a directory: Using the -a flag displays hidden files: Using the -l flag formats the output in a long list: The file command gives us mor…
In a recent question (https://www.experts-exchange.com/questions/29004105/Run-AutoHotkey-script-directly-from-Notepad.html) here at Experts Exchange, a member asked how to run an AutoHotkey script (.AHK) directly from Notepad++ (aka NPP). This video…
Suggested Courses

623 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question