Must declare the table variable

THe problem is here....since your table variable is local only to your current scope, you can't use dynamic sql to access it.

EXEC('SELECT job.jobs_id,job.jobs_title,job.jobs_refid,job.jobs_date,job.jobs_preview,company.companys_name,company.companys_id,city.citys_text,country.countrys_short
FROM @TempItems tmp
      LEFT JOIN jobs job ON job.jobs_id = tmp.jobs_id
      LEFT JOIN companys company ON company.companys_id = tmp.companys_id
      LEFT JOIN citys city ON city.citys_id = tmp.citys_id
      LEFT JOIN countrys country ON country.countrys_id = tmp.countrys_id
WHERE ID >= @startRowIndex'+ @SearchTerms + @CountryString)

you can change your table variable to be a global temp table ##tempItems, and it will fix your problem.

why are you using the table variable at all?  it looks like you're  just returning data, so its really not necessary.

sorry guys Im completly lost...

Are their any pages that can help me... Im just trying to page some results based on some keywords and options... it works fine if I hardcode everything in...(without the exec)

please try to use my code as I posted it...

apart from that, reread my explanation:

the problem is that the temp table (variable) is not known inside the dynamic sql (as that has a different scope, so the @table variable declared outside of exec() is not visible inside of exec() ).

@angel... well it made by that error except I got a new one (same kinda thing)

Must declare the scalar variable "@startRowIndex".

@chapmandew & @Sharath_123
How would this scenario run under pressure? Is it good for high traffic?

Thanks Guys

As your conditions in the WHERE clause vary with the variables (@SearchTerms , @CountryString ), you need to build to the dynamic sql.

At first shot, i always avoid using dynamic sql until it is necessary. If used, then use temp tables instead of table variables to avoid error like this.

In the attached script of my last post, i haven't updated the table variable to temp table in all places. check that and modify accordingly.

@Sharath_123

I tried the attached code, works fine unless I put a search term in... as soon as I do that I get

Msg 102, Level 15, State 1, Line 7
Incorrect syntax near '('.

set ANSI_NULLS ON
set QUOTED_IDENTIFIER ON
go
 
ALTER PROCEDURE [dbo].[JobSearch]
(
	@startRowIndex int,
	@maximumRows int,
	@firstString varchar(50)='',
	@secondString varchar(50)='',
	@thirdString varchar(50)='',
	@CountryRequest int = 0
)
AS
 
create TABLE #TempItems 
(
	ID int IDENTITY,
	jobs_id uniqueidentifier,
	jobs_title varchar(255),
	jobs_refid bigint,
	jobs_date smalldatetime,
	jobs_preview varchar(500),
	companys_name varchar(200),
	companys_id bigint,
	citys_text varchar(50),
	countrys_short varchar(50),
	jobs_citys_id int,
	jobs_countrys_id int,
	citys_id numeric(18, 0),
	countrys_id numeric(18, 0),
	jobs_description text,
	jobs_keywords text
)
 
 
DECLARE @SearchTerms nvarchar(500);
IF NOT @firstString = ''
 BEGIN
 SET @SearchTerms = '(' + @firstString + ')'
END
IF NOT @secondString = '' AND NOT @SearchTerms = ''
 BEGIN
 SET @SearchTerms = @SearchTerms + ' OR (' + @secondString + ')'
END
IF NOT @thirdString = '' AND NOT @SearchTerms = ''
 BEGIN
 SET @SearchTerms = @SearchTerms + ' OR (' + @thirdString + ')'
END
IF NOT @SearchTerms = ''
 BEGIN
 SET @SearchTerms =  ' AND (CONTAINS (job.jobs_title,' + @SearchTerms + ') OR CONTAINS (job.jobs_description,' + @SearchTerms + ') OR CONTAINS (job.jobs_keywords,' + @SearchTerms + '))'
END
 
DECLARE @CountryString varchar(20);
IF NOT @CountryRequest = 0
 BEGIN
 SET @CountryString = ' AND jobs_citys_id = ' + @CountryRequest
END
 
DECLARE @maxRow int
 
SET @maxRow = (@startRowIndex + @maximumRows) - 1 
SET ROWCOUNT @maxRow
 
INSERT INTO #TempItems (jobs_id,jobs_title,jobs_refid,jobs_date,jobs_preview,companys_name,companys_id,citys_text,countrys_short,jobs_citys_id,jobs_countrys_id,citys_id,countrys_id,jobs_description,jobs_keywords)
SELECT jobs_id,jobs_title,jobs_refid,jobs_date,jobs_preview,companys_name,companys_id,citys_text,countrys_short,jobs_citys_id,jobs_countrys_id,citys_id,countrys_id,jobs_description,jobs_keywords
FROM jobs
LEFT JOIN companys ON companys_id = jobs_companys_id
LEFT JOIN citys ON citys_id = jobs_citys_id
LEFT JOIN countrys ON countrys_id = jobs_countrys_id
ORDER BY jobs_date DESC
 
SET ROWCOUNT @maximumRows
 
EXEC('SELECT job.jobs_id,job.jobs_title,job.jobs_refid,job.jobs_date,job.jobs_preview,company.companys_name,company.companys_id,city.citys_text,country.countrys_short
FROM #TempItems tmp
	LEFT JOIN jobs job ON job.jobs_id = tmp.jobs_id
	LEFT JOIN companys company ON company.companys_id = tmp.companys_id
	LEFT JOIN citys city ON city.citys_id = tmp.citys_id
	LEFT JOIN countrys country ON country.countrys_id = tmp.countrys_id
WHERE ID >= '+ @startRowIndex + ' '+ @SearchTerms + @CountryString)
 
SET ROWCOUNT 0
DROP TABLE #TempItems

Select allOpen in new window

Run this and check the dynamic sql executed for any syntax errors. I am not sure what are you doing in these parameters @startRowIndex ,@SearchTerms and @CountryString.
So better try to print your dynamic sql and debug the error. you can post the dynamic sql here for any assistance.

set ANSI_NULLS ON
set QUOTED_IDENTIFIER ON
go
 
ALTER PROCEDURE [dbo].[JobSearch]
(
	@startRowIndex int,
	@maximumRows int,
	@firstString varchar(50)='',
	@secondString varchar(50)='',
	@thirdString varchar(50)='',
	@CountryRequest int = 0
)
AS
 
create TABLE #TempItems 
(
	ID int IDENTITY,
	jobs_id uniqueidentifier,
	jobs_title varchar(255),
	jobs_refid bigint,
	jobs_date smalldatetime,
	jobs_preview varchar(500),
	companys_name varchar(200),
	companys_id bigint,
	citys_text varchar(50),
	countrys_short varchar(50),
	jobs_citys_id int,
	jobs_countrys_id int,
	citys_id numeric(18, 0),
	countrys_id numeric(18, 0),
	jobs_description text,
	jobs_keywords text
)
 
 
DECLARE @SearchTerms nvarchar(500);
IF NOT @firstString = ''
 BEGIN
 SET @SearchTerms = '(' + @firstString + ')'
END
IF NOT @secondString = '' AND NOT @SearchTerms = ''
 BEGIN
 SET @SearchTerms = @SearchTerms + ' OR (' + @secondString + ')'
END
IF NOT @thirdString = '' AND NOT @SearchTerms = ''
 BEGIN
 SET @SearchTerms = @SearchTerms + ' OR (' + @thirdString + ')'
END
IF NOT @SearchTerms = ''
 BEGIN
 SET @SearchTerms =  ' AND (CONTAINS (job.jobs_title,' + @SearchTerms + ') OR CONTAINS (job.jobs_description,' + @SearchTerms + ') OR CONTAINS (job.jobs_keywords,' + @SearchTerms + '))'
END
 
DECLARE @CountryString varchar(20);
IF NOT @CountryRequest = 0
 BEGIN
 SET @CountryString = ' AND jobs_citys_id = ' + @CountryRequest
END
 
DECLARE @maxRow int
 
SET @maxRow = (@startRowIndex + @maximumRows) - 1 
SET ROWCOUNT @maxRow
 
INSERT INTO #TempItems (jobs_id,jobs_title,jobs_refid,jobs_date,jobs_preview,companys_name,companys_id,citys_text,countrys_short,jobs_citys_id,jobs_countrys_id,citys_id,countrys_id,jobs_description,jobs_keywords)
SELECT jobs_id,jobs_title,jobs_refid,jobs_date,jobs_preview,companys_name,companys_id,citys_text,countrys_short,jobs_citys_id,jobs_countrys_id,citys_id,countrys_id,jobs_description,jobs_keywords
FROM jobs
LEFT JOIN companys ON companys_id = jobs_companys_id
LEFT JOIN citys ON citys_id = jobs_citys_id
LEFT JOIN countrys ON countrys_id = jobs_countrys_id
ORDER BY jobs_date DESC
 
SET ROWCOUNT @maximumRows
 
print('SELECT job.jobs_id,job.jobs_title,job.jobs_refid,job.jobs_date,job.jobs_preview,company.companys_name,company.companys_id,city.citys_text,country.countrys_short
FROM #TempItems tmp
	LEFT JOIN jobs job ON job.jobs_id = tmp.jobs_id
	LEFT JOIN companys company ON company.companys_id = tmp.companys_id
	LEFT JOIN citys city ON city.citys_id = tmp.citys_id
	LEFT JOIN countrys country ON country.countrys_id = tmp.countrys_id
WHERE ID >= '+ @startRowIndex + ' '+ @SearchTerms + @CountryString)
 
SET ROWCOUNT 0
DROP TABLE #TempItems

Select allOpen in new window