• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 545
  • Last Modified:

Stored procedure nested output

I have a stored procedure that I want to return all those fields in a table that are null throughout the records. Basically will show unused fields in a table. I am passing @TableName as an input parameter and intend to use the output as a simple column on a report in SSRS.

PROBLEM: I can't get the output of a stored procedure. It has a nested execute statement and is only returning one field.
SProc is below.

Grateful thanks in advanced.
USE [Metastorm]
GO
/****** Object:  StoredProcedure [dbo].[usp_ReportPackNullFields]    Script Date: 05/05/2009 11:02:35 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[usp_ReportPackNullFields]
	@TableName varchar(100)
AS
BEGIN
    SET NOCOUNT ON;
	DECLARE @query nvarchar(max);
	DECLARE @Colname nvarchar(100);
    DECLARE @column sysname;
    DECLARE columns_cursor CURSOR FOR
    	SELECT c.name
    	FROM sys.tables t JOIN sys.columns c ON t.object_id = c.object_id
    	WHERE t.name = @tablename AND c.is_nullable = 1;
    OPEN columns_cursor;
    FETCH NEXT FROM columns_cursor INTO @column;
    WHILE (@@FETCH_STATUS = 0)
    BEGIN
    	SET @query = N'
    	DECLARE @c int;
		DECLARE @column nvarchar(100);
		SELECT @c = COUNT(*) FROM ' + @tablename + ' WHERE ' + @column + N' IS NOT NULL
    	IF (@c = 0)
			SELECT (''' + @column + N''') AS NullColumn;'
		EXECUTE (@query);
		FETCH NEXT FROM columns_cursor INTO @column;
    END
    CLOSE columns_cursor;
    DEALLOCATE columns_cursor;
    SET NOCOUNT OFF;
END;

Open in new window

0
BrightRaven
Asked:
BrightRaven
  • 2
1 Solution
 
pivarCommented:
Hi,

You can fill a temptable and return it at the end of the sp.

/peter


USE [Metastorm]
GO
/****** Object:  StoredProcedure [dbo].[usp_ReportPackNullFields]    Script Date: 05/05/2009 11:02:35 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[usp_ReportPackNullFields]
        @TableName varchar(100)
AS
BEGIN
    SET NOCOUNT ON;
 
CREATE table #result (Nullcolumn varchar(100))
 
        DECLARE @query nvarchar(max);
        DECLARE @Colname nvarchar(100);
    DECLARE @column sysname;
    DECLARE columns_cursor CURSOR FOR
        SELECT c.name
        FROM sys.tables t JOIN sys.columns c ON t.object_id = c.object_id
        WHERE t.name = @tablename AND c.is_nullable = 1;
    OPEN columns_cursor;
    FETCH NEXT FROM columns_cursor INTO @column;
    WHILE (@@FETCH_STATUS = 0)
    BEGIN
        SET @query = N'
        DECLARE @c int;
                DECLARE @column nvarchar(100);
                SELECT @c = COUNT(*) FROM ' + @tablename + ' WHERE ' + @column + N' IS NOT NULL
        IF (@c = 0)
                SELECT (''' + @column + N''') AS NullColumn;'
        INSERT INTO #result
                EXECUTE (@query);
        END
                FETCH NEXT FROM columns_cursor INTO @column;
    END
    CLOSE columns_cursor;
    DEALLOCATE columns_cursor;
 
    SELECT * FROM #result
 
    SET NOCOUNT OFF;
END;

Open in new window

0
 
pivarCommented:
Sorry, a typo. Remove END after EXECUTE(@query), like this
USE [Metastorm]
GO
/****** Object:  StoredProcedure [dbo].[usp_ReportPackNullFields]    Script Date: 05/05/2009 11:02:35 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[usp_ReportPackNullFields]
        @TableName varchar(100)
AS
BEGIN
    SET NOCOUNT ON;
 
CREATE table #result (Nullcolumn varchar(100))
 
        DECLARE @query nvarchar(max);
        DECLARE @Colname nvarchar(100);
    DECLARE @column sysname;
    DECLARE columns_cursor CURSOR FOR
        SELECT c.name
        FROM sys.tables t JOIN sys.columns c ON t.object_id = c.object_id
        WHERE t.name = @tablename AND c.is_nullable = 1;
    OPEN columns_cursor;
    FETCH NEXT FROM columns_cursor INTO @column;
    WHILE (@@FETCH_STATUS = 0)
    BEGIN
        SET @query = N'
        DECLARE @c int;
                DECLARE @column nvarchar(100);
                SELECT @c = COUNT(*) FROM ' + @tablename + ' WHERE ' + @column + N' IS NOT NULL
        IF (@c = 0)
                SELECT (''' + @column + N''') AS NullColumn;'
        INSERT INTO #result
                EXECUTE (@query);
                FETCH NEXT FROM columns_cursor INTO @column;
    END
    CLOSE columns_cursor;
    DEALLOCATE columns_cursor;
 
    SELECT * FROM #result
 
    SET NOCOUNT OFF;
END;

Open in new window

0
 
BrightRavenBusiness AnalystAuthor Commented:
Many thanks. Works a treat.
0

Featured Post

Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now