Solved

Index was out of range. Must be non-negative and less than the size of the collection error when using checkbox list

Posted on 2009-05-05
10
681 Views
Last Modified: 2013-12-17
I have a checkbox list that I use to assign membership accounts to roles.  However if I don't check a role in the checkbox list I get

Index was out of range. Must be non-negative and less than the size of the collection

See my code below
foreach (ListItem rolebox in UserRoles.Items)
            {
                if (rolebox.Selected)
                {
                    if (!Roles.IsUserInRole(UserName, rolebox.Text))
                    {
                        Roles.AddUserToRole(UserName, rolebox.Text);
                        if (rolebox.Text == "test")
                        {
					//then add to community server                                                         Communitytest.CreateCommunityServerAccount(UserName);
                        }
                    }
                }
                else 
                {
                    if (Roles.IsUserInRole(UserName, rolebox.Text))
                    {
                        Roles.RemoveUserFromRole(UserName, rolebox.Text);
                        //remove from community server                        if (rolebox.Text == "Advocate")
                        {
                            Communitytest.RemoveCommunityServerAccount(UserName);
                        }
                    }
                }
            }

Open in new window

0
Comment
Question by:mugsey
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 4
10 Comments
 
LVL 6

Expert Comment

by:DanielWillmott
ID: 24305007
What line is the error happening on?
0
 
LVL 9

Expert Comment

by:tculler
ID: 24305011
Well, first things first, on line 19, was that a copy/paste error, or does your code really have that if-statement condition commented out? If it is commented out, that may be the source. The brackets are still valid, but it will just always execute that RemoveCommunityServerAccount method call, which may be throwing the exception.
0
 

Author Comment

by:mugsey
ID: 24305129
Sorry it was a cut and paste job.  Both of the

if (rolebox.Text == "test")

should say "test" and not advocate.  

I think the problem is when no checkbox is selected and I try and do the update?
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
LVL 6

Expert Comment

by:DanielWillmott
ID: 24305147
But where is the error happening? There doesn't seem to be anything wrong here. I'm wondering is there is a problem in the function Communitytest.RemoveCommunityServerAccount().
0
 

Author Comment

by:mugsey
ID: 24305212
Yes I will have a look and check
0
 

Author Comment

by:mugsey
ID: 24305689
Yes it is with the RemoveCommunityServerAccount method call.

Now its a web service that is failing when returning null.  So I need to check if its null so I can handle it.

I have  

CSUser = CommunityServerWebService.GetUsers(query)[0];

but that is were I am getting the error

I am doing this here
http://dev.communityserver.com/forums/p/506234/646354.aspx#646354



0
 
LVL 6

Expert Comment

by:DanielWillmott
ID: 24305770
Could you post some more code where the 'CSUser = CommunityServerWebService.GetUsers(query)[0];' line is located?
 
0
 

Author Comment

by:mugsey
ID: 24305850
Yes here you are

 
 
MembershipService NPWebSservice = new MembershipService(CommunityServerURL, "admin", CSapiKey);
        MembershipUser mu = Membership.GetUser(userName);
        if (mu != null)
        {
            User newCSUser;
            UserQuery query = new UserQuery();
            query.Usernames.Add(userName);
            newCSUser = NPWebSservice.GetUsers(query).FirstOrDefault(o => o.Username == userName);
            //existingCSUser = NPWebSservice.GetUsers(query)[0];
            
            if (newCSUser == null)
            {
                newCSUser = new User();
                newCSUser.Username = mu.UserName;
                etc etc...
 
                // add to community server
                User createdCSUser = NPWebSservice.AddUser(newCSUser);                
                createdCSUser.Status.AccountStatus = UserAccountStatus.Approved;
                etc etc
                NPWebSservice.UpdateUser(createdCSUser);
            }
        }

Open in new window

0
 

Author Comment

by:mugsey
ID: 24305872
Sorry I put back the line

existingCSUser = NPWebSservice.GetUsers(query)[0];

as per the documentation but I need to check for null if no records exist
0
 
LVL 6

Accepted Solution

by:
DanielWillmott earned 500 total points
ID: 24310640
I'm not totally sure I'm following what you're trying to do here, but it this what you mean?

MembershipService NPWebSservice = new MembershipService(CommunityServerURL, "admin", CSapiKey);
MembershipUser mu = Membership.GetUser(userName);
if (mu != null)
{
    User newCSUser;
    UserQuery query = new UserQuery();
    query.Usernames.Add(userName);
    User existingCSUser = NPWebSservice.GetUsers(query)[0].FirstOrDefault(o => o.Username == userName);
    
    if (existingCSUser == null)
    {
        newCSUser = new User();
        newCSUser.Username = mu.UserName;
        etc etc...
 
        // add to community server
        User createdCSUser = NPWebSservice.AddUser(newCSUser);                
        createdCSUser.Status.AccountStatus = UserAccountStatus.Approved;
        etc etc
        NPWebSservice.UpdateUser(createdCSUser);
    }
}

Open in new window

0

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Just a quick little trick I learned recently.  Now that I'm using jQuery with abandon in my asp.net applications, I have grown tired of the following syntax:      (CODE) I suppose it just offends my sense of decency to put inline VBScript on a…
Many of us here at EE write code. Many of us write exceptional code; just as many of us write exception-prone code. As we all should know, exceptions are a mechanism for handling errors which are typically out of our control. From database errors, t…
Attackers love to prey on accounts that have privileges. Reducing privileged accounts and protecting privileged accounts therefore is paramount. Users, groups, and service accounts need to be protected to help protect the entire Active Directory …
Are you ready to implement Active Directory best practices without reading 300+ pages? You're in luck. In this webinar hosted by Skyport Systems, you gain insight into Microsoft's latest comprehensive guide, with tips on the best and easiest way…

752 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question