• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 690
  • Last Modified:

Index was out of range. Must be non-negative and less than the size of the collection error when using checkbox list

I have a checkbox list that I use to assign membership accounts to roles.  However if I don't check a role in the checkbox list I get

Index was out of range. Must be non-negative and less than the size of the collection

See my code below
foreach (ListItem rolebox in UserRoles.Items)
            {
                if (rolebox.Selected)
                {
                    if (!Roles.IsUserInRole(UserName, rolebox.Text))
                    {
                        Roles.AddUserToRole(UserName, rolebox.Text);
                        if (rolebox.Text == "test")
                        {
					//then add to community server                                                         Communitytest.CreateCommunityServerAccount(UserName);
                        }
                    }
                }
                else 
                {
                    if (Roles.IsUserInRole(UserName, rolebox.Text))
                    {
                        Roles.RemoveUserFromRole(UserName, rolebox.Text);
                        //remove from community server                        if (rolebox.Text == "Advocate")
                        {
                            Communitytest.RemoveCommunityServerAccount(UserName);
                        }
                    }
                }
            }

Open in new window

0
mugsey
Asked:
mugsey
  • 5
  • 4
1 Solution
 
DanielWillmottCommented:
What line is the error happening on?
0
 
tcullerCommented:
Well, first things first, on line 19, was that a copy/paste error, or does your code really have that if-statement condition commented out? If it is commented out, that may be the source. The brackets are still valid, but it will just always execute that RemoveCommunityServerAccount method call, which may be throwing the exception.
0
 
mugseyAuthor Commented:
Sorry it was a cut and paste job.  Both of the

if (rolebox.Text == "test")

should say "test" and not advocate.  

I think the problem is when no checkbox is selected and I try and do the update?
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
DanielWillmottCommented:
But where is the error happening? There doesn't seem to be anything wrong here. I'm wondering is there is a problem in the function Communitytest.RemoveCommunityServerAccount().
0
 
mugseyAuthor Commented:
Yes I will have a look and check
0
 
mugseyAuthor Commented:
Yes it is with the RemoveCommunityServerAccount method call.

Now its a web service that is failing when returning null.  So I need to check if its null so I can handle it.

I have  

CSUser = CommunityServerWebService.GetUsers(query)[0];

but that is were I am getting the error

I am doing this here
http://dev.communityserver.com/forums/p/506234/646354.aspx#646354



0
 
DanielWillmottCommented:
Could you post some more code where the 'CSUser = CommunityServerWebService.GetUsers(query)[0];' line is located?
 
0
 
mugseyAuthor Commented:
Yes here you are

 
 
MembershipService NPWebSservice = new MembershipService(CommunityServerURL, "admin", CSapiKey);
        MembershipUser mu = Membership.GetUser(userName);
        if (mu != null)
        {
            User newCSUser;
            UserQuery query = new UserQuery();
            query.Usernames.Add(userName);
            newCSUser = NPWebSservice.GetUsers(query).FirstOrDefault(o => o.Username == userName);
            //existingCSUser = NPWebSservice.GetUsers(query)[0];
            
            if (newCSUser == null)
            {
                newCSUser = new User();
                newCSUser.Username = mu.UserName;
                etc etc...
 
                // add to community server
                User createdCSUser = NPWebSservice.AddUser(newCSUser);                
                createdCSUser.Status.AccountStatus = UserAccountStatus.Approved;
                etc etc
                NPWebSservice.UpdateUser(createdCSUser);
            }
        }

Open in new window

0
 
mugseyAuthor Commented:
Sorry I put back the line

existingCSUser = NPWebSservice.GetUsers(query)[0];

as per the documentation but I need to check for null if no records exist
0
 
DanielWillmottCommented:
I'm not totally sure I'm following what you're trying to do here, but it this what you mean?

MembershipService NPWebSservice = new MembershipService(CommunityServerURL, "admin", CSapiKey);
MembershipUser mu = Membership.GetUser(userName);
if (mu != null)
{
    User newCSUser;
    UserQuery query = new UserQuery();
    query.Usernames.Add(userName);
    User existingCSUser = NPWebSservice.GetUsers(query)[0].FirstOrDefault(o => o.Username == userName);
    
    if (existingCSUser == null)
    {
        newCSUser = new User();
        newCSUser.Username = mu.UserName;
        etc etc...
 
        // add to community server
        User createdCSUser = NPWebSservice.AddUser(newCSUser);                
        createdCSUser.Status.AccountStatus = UserAccountStatus.Approved;
        etc etc
        NPWebSservice.UpdateUser(createdCSUser);
    }
}

Open in new window

0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 5
  • 4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now