Solved

Add datagridviewRows to List<>  c#

Posted on 2009-05-05
9
701 Views
Last Modified: 2012-05-06
Hi all,

On my form I have a DataGridView wich the user can fill manuel with document lines (invoice).
When the user clicks the save doc button the document gets saved to the db and with that new record ID I then Save the documentlines into the db.
Only problem I have is that when there are say 3 rows in the DataGridView it save 3 times the last added row and not row 1,2 and 3.
Below is my code.

So I have a problem somewhere with iterating through the DataGridView but can't find what is wrong..

Thx for any help.

Grts.



#region AddLinesToList
          // Add lines to List and fill DocumentBLL.DocRegel
          // _localDocBLL is a class wich contains a List with _localRegelBLL items
          for (int i = 0; i < dataGridViewDocLijnen.Rows.Count; i++)
          {
           // Here i Fill the _localRegelBLL properties with the values of the datagridview
          // but something goes wrong here. It adds the last line as many times a there are rows...
            _localRegelBLL.Id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[0].Value);
            _localRegelBLL.Aantal = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[1].Value);
            _localRegelBLL.Rgl_oms_id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[2].Value);
            _localRegelBLL.Eenheid = dataGridViewDocLijnen.Rows[i].Cells[4].Value.ToString();
            _localRegelBLL.EenheidsPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[5].Value);
            _localRegelBLL.TotaalPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[6].Value);
            _localRegelBLL.Rgl_doc_id = docId;
            _localDocBLL.DocRegel.Add(_localRegelBLL);
          }
          #endregion
 
          // Save document lines
          bool saveDocLines = _localDocBLL.SaveDocLines(_localDocBLL.DocRegel);

Open in new window

0
Comment
Question by:Pit76
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 4
9 Comments
 
LVL 9

Expert Comment

by:tculler
ID: 24309341
Where in your code is this code snippet? If it's in like a Confirm event (ie a button click or something), then it'll just append the same data 3 times (which is what's going wrong, correct?)
0
 

Author Comment

by:Pit76
ID: 24309391
Yes indeed. this is a part of the SaveButton_Click Event.
I first save the general info of the document (like customer, address etc) Then I get the new ID and then I want to save the doclines from the DataGridView. But indeed it saves the same line (lastline in DGV) 3 times or as much as there are lines in the DGV.

What a'm I doing wrong here?

Grts.
0
 
LVL 1

Expert Comment

by:pras_gupta
ID: 24309436
_localRegelBLL  is reference to the the object , Evenytime you assign the values to it  updates the reference and hence last object is reflected three time. What you need to do is Create a new object for _localRegelBLL in the for loop and then add it to the list. Hope this helps.
0
SharePoint Admin?

Enable Your Employees To Focus On The Core With Intuitive Onscreen Guidance That is With You At The Moment of Need.

 
LVL 9

Expert Comment

by:tculler
ID: 24309452
This has to do with the nature of reference types vs. value types. The invocation of the "Add" method on line 15 adds the reference of the same object for as many times as there are rows, which is not quite what you want. May I also suggest using a foreach loop? Your code will look something like this:
void AddLinesToList(DataGridView myDataGridView)
{
     foreach(DataRow row in myDataGridView.Rows)
     {
          // Create a NEW object that contains the fields you
          // need (the type of this object is whatever you declared
          // "_localRegelBLL" as. Make sure it is declared
          // inside the loop.
          _localDocBLL.DocRegel.Add(_localRegelBLL);
     }
     // Save lines, etc.
}

Open in new window

0
 

Author Comment

by:Pit76
ID: 24309489
So something more like this?
Every time it passes the loop create a NEW RegelBLL instance, fill it's prperties, add it to the _localDocBLL.DocRegel List and then dispose the_localRegelBLL?

Grts and thx for your help!
void AddLinesToList(DataGridView myDataGridView)
{
     foreach(DataRow row in myDataGridView.Rows)
     {
          // Create a NEW object that contains the fields you
          // need (the type of this object is whatever you declared
          // "_localRegelBLL" as. Make sure it is declared
          // inside the loop.
          RegelBLL _localRegelBLL = new RegelBLL();
 
           _localRegelBLL.Id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[0].Value);
            _localRegelBLL.Aantal = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[1].Value);
            _localRegelBLL.Rgl_oms_id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[2].Value);
            _localRegelBLL.Eenheid = dataGridViewDocLijnen.Rows[i].Cells[4].Value.ToString();
            _localRegelBLL.EenheidsPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[5].Value);
            _localRegelBLL.TotaalPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[6].Value);
            _localRegelBLL.Rgl_doc_id = docId;
 
          _localDocBLL.DocRegel.Add(_localRegelBLL);
          
          _localRegelBLL = null;
     }
     // Save lines, etc.
}

Open in new window

0
 
LVL 9

Expert Comment

by:tculler
ID: 24309491
Sorry, didn't check as well as I should have. In my post, DataRow should be DataGridViewRow. In the foreach loop, just mimic your code, except replace every instance of "dataGridViewDocLijnen.Rows[i]" with "row" (shortens the code quite a bit, eh? :)).

Let me know of further troubles, if any,
Nate
0
 

Author Comment

by:Pit76
ID: 24309527
K, thx for the help. Will test it tomorrow but it makes sence what you say so I think it'll work..

I'll let you know tomorrow.

Grts
0
 
LVL 9

Accepted Solution

by:
tculler earned 500 total points
ID: 24309554
Here, I'll just re-write the code for you :) that should be easier. Just copy/paste this method into your event handling method.
private void SaveButton_Click( System.Object sender, System.EventArgs evArgs )
{
	foreach(DataGridViewRow row in dataGridViewDocLijnen.Rows)
	{
		RegelBLL temp = new RegelBLL();
 
		temp.Id = System.Convert.ToInt32(row.Cells[0].Value);
		temp.Aantal = System.Convert.ToDouble(row.Cells[1].Value);
		temp.Rgl_oms_id = System.Convert.ToInt32(row.Cells[2].Value);
		temp.Eenheid = row.Cells[4].Value.ToString();
		temp.EenheidsPrijs = System.Convert.ToDouble(row.Cells[5].Value);
		temp.TotaalPrijs = System.Convert.ToDouble(row.Cells[6].Value);
		temp.Rgl_doc_id = docId;
 
		_localDocBLL.DocRegel.Add(temp);
 
		temp = null;
	}
	// Save here
}

Open in new window

0
 

Author Closing Comment

by:Pit76
ID: 31578237
Thx! It works perfect. Thx for your help!

Grts.
0

Featured Post

On Demand Webinar - Networking for the Cloud Era

This webinar discusses:
-Common barriers companies experience when moving to the cloud
-How SD-WAN changes the way we look at networks
-Best practices customers should employ moving forward with cloud migration
-What happens behind the scenes of SteelConnect’s one-click button

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Summary: Persistence is the capability of an application to store the state of objects and recover it when necessary. This article compares the two common types of serialization in aspects of data access, readability, and runtime cost. A ready-to…
It was really hard time for me to get the understanding of Delegates in C#. I went through many websites and articles but I found them very clumsy. After going through those sites, I noted down the points in a easy way so here I am sharing that unde…
This is a high-level webinar that covers the history of enterprise open source database use. It addresses both the advantages companies see in using open source database technologies, as well as the fears and reservations they might have. In this…
There's a multitude of different network monitoring solutions out there, and you're probably wondering what makes NetCrunch so special. It's completely agentless, but does let you create an agent, if you desire. It offers powerful scalability …

726 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question