Solved

Add datagridviewRows to List<>  c#

Posted on 2009-05-05
9
657 Views
Last Modified: 2012-05-06
Hi all,

On my form I have a DataGridView wich the user can fill manuel with document lines (invoice).
When the user clicks the save doc button the document gets saved to the db and with that new record ID I then Save the documentlines into the db.
Only problem I have is that when there are say 3 rows in the DataGridView it save 3 times the last added row and not row 1,2 and 3.
Below is my code.

So I have a problem somewhere with iterating through the DataGridView but can't find what is wrong..

Thx for any help.

Grts.



#region AddLinesToList

          // Add lines to List and fill DocumentBLL.DocRegel

          // _localDocBLL is a class wich contains a List with _localRegelBLL items

          for (int i = 0; i < dataGridViewDocLijnen.Rows.Count; i++)

          {

           // Here i Fill the _localRegelBLL properties with the values of the datagridview

          // but something goes wrong here. It adds the last line as many times a there are rows...

            _localRegelBLL.Id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[0].Value);

            _localRegelBLL.Aantal = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[1].Value);

            _localRegelBLL.Rgl_oms_id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[2].Value);

            _localRegelBLL.Eenheid = dataGridViewDocLijnen.Rows[i].Cells[4].Value.ToString();

            _localRegelBLL.EenheidsPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[5].Value);

            _localRegelBLL.TotaalPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[6].Value);

            _localRegelBLL.Rgl_doc_id = docId;

            _localDocBLL.DocRegel.Add(_localRegelBLL);

          }

          #endregion
 

          // Save document lines

          bool saveDocLines = _localDocBLL.SaveDocLines(_localDocBLL.DocRegel);

Open in new window

0
Comment
Question by:Pit76
  • 4
  • 4
9 Comments
 
LVL 9

Expert Comment

by:tculler
ID: 24309341
Where in your code is this code snippet? If it's in like a Confirm event (ie a button click or something), then it'll just append the same data 3 times (which is what's going wrong, correct?)
0
 

Author Comment

by:Pit76
ID: 24309391
Yes indeed. this is a part of the SaveButton_Click Event.
I first save the general info of the document (like customer, address etc) Then I get the new ID and then I want to save the doclines from the DataGridView. But indeed it saves the same line (lastline in DGV) 3 times or as much as there are lines in the DGV.

What a'm I doing wrong here?

Grts.
0
 
LVL 1

Expert Comment

by:pras_gupta
ID: 24309436
_localRegelBLL  is reference to the the object , Evenytime you assign the values to it  updates the reference and hence last object is reflected three time. What you need to do is Create a new object for _localRegelBLL in the for loop and then add it to the list. Hope this helps.
0
 
LVL 9

Expert Comment

by:tculler
ID: 24309452
This has to do with the nature of reference types vs. value types. The invocation of the "Add" method on line 15 adds the reference of the same object for as many times as there are rows, which is not quite what you want. May I also suggest using a foreach loop? Your code will look something like this:
void AddLinesToList(DataGridView myDataGridView)

{

     foreach(DataRow row in myDataGridView.Rows)

     {

          // Create a NEW object that contains the fields you

          // need (the type of this object is whatever you declared

          // "_localRegelBLL" as. Make sure it is declared

          // inside the loop.

          _localDocBLL.DocRegel.Add(_localRegelBLL);

     }

     // Save lines, etc.

}

Open in new window

0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 

Author Comment

by:Pit76
ID: 24309489
So something more like this?
Every time it passes the loop create a NEW RegelBLL instance, fill it's prperties, add it to the _localDocBLL.DocRegel List and then dispose the_localRegelBLL?

Grts and thx for your help!
void AddLinesToList(DataGridView myDataGridView)

{

     foreach(DataRow row in myDataGridView.Rows)

     {

          // Create a NEW object that contains the fields you

          // need (the type of this object is whatever you declared

          // "_localRegelBLL" as. Make sure it is declared

          // inside the loop.

          RegelBLL _localRegelBLL = new RegelBLL();
 

           _localRegelBLL.Id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[0].Value);

            _localRegelBLL.Aantal = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[1].Value);

            _localRegelBLL.Rgl_oms_id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[2].Value);

            _localRegelBLL.Eenheid = dataGridViewDocLijnen.Rows[i].Cells[4].Value.ToString();

            _localRegelBLL.EenheidsPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[5].Value);

            _localRegelBLL.TotaalPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[6].Value);

            _localRegelBLL.Rgl_doc_id = docId;
 

          _localDocBLL.DocRegel.Add(_localRegelBLL);

          

          _localRegelBLL = null;

     }

     // Save lines, etc.

}

Open in new window

0
 
LVL 9

Expert Comment

by:tculler
ID: 24309491
Sorry, didn't check as well as I should have. In my post, DataRow should be DataGridViewRow. In the foreach loop, just mimic your code, except replace every instance of "dataGridViewDocLijnen.Rows[i]" with "row" (shortens the code quite a bit, eh? :)).

Let me know of further troubles, if any,
Nate
0
 

Author Comment

by:Pit76
ID: 24309527
K, thx for the help. Will test it tomorrow but it makes sence what you say so I think it'll work..

I'll let you know tomorrow.

Grts
0
 
LVL 9

Accepted Solution

by:
tculler earned 500 total points
ID: 24309554
Here, I'll just re-write the code for you :) that should be easier. Just copy/paste this method into your event handling method.
private void SaveButton_Click( System.Object sender, System.EventArgs evArgs )

{

	foreach(DataGridViewRow row in dataGridViewDocLijnen.Rows)

	{

		RegelBLL temp = new RegelBLL();
 

		temp.Id = System.Convert.ToInt32(row.Cells[0].Value);

		temp.Aantal = System.Convert.ToDouble(row.Cells[1].Value);

		temp.Rgl_oms_id = System.Convert.ToInt32(row.Cells[2].Value);

		temp.Eenheid = row.Cells[4].Value.ToString();

		temp.EenheidsPrijs = System.Convert.ToDouble(row.Cells[5].Value);

		temp.TotaalPrijs = System.Convert.ToDouble(row.Cells[6].Value);

		temp.Rgl_doc_id = docId;
 

		_localDocBLL.DocRegel.Add(temp);
 

		temp = null;

	}

	// Save here

}

Open in new window

0
 

Author Closing Comment

by:Pit76
ID: 31578237
Thx! It works perfect. Thx for your help!

Grts.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Chat Room 1 43
Do you know how I could save the image array ELEMENTS as individual *.tiff files ? 2 37
Run time Error 4 34
C#  Radio button search for Date not DateTime 4 30
Extention Methods in C# 3.0 by Ivo Stoykov C# 3.0 offers extension methods. They allow extending existing classes without changing the class's source code or relying on inheritance. These are static methods invoked as instance method. This…
Calculating holidays and working days is a function that is often needed yet it is not one found within the Framework. This article presents one approach to building a working-day calculator for use in .NET.
Delivering innovative fully-managed cloud services for mission-critical applications requires expertise in multiple areas plus vision and commitment. Meet a few of the people behind the quality services of Concerto.
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …

937 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now