Solved

Add datagridviewRows to List<>  c#

Posted on 2009-05-05
9
669 Views
Last Modified: 2012-05-06
Hi all,

On my form I have a DataGridView wich the user can fill manuel with document lines (invoice).
When the user clicks the save doc button the document gets saved to the db and with that new record ID I then Save the documentlines into the db.
Only problem I have is that when there are say 3 rows in the DataGridView it save 3 times the last added row and not row 1,2 and 3.
Below is my code.

So I have a problem somewhere with iterating through the DataGridView but can't find what is wrong..

Thx for any help.

Grts.



#region AddLinesToList
          // Add lines to List and fill DocumentBLL.DocRegel
          // _localDocBLL is a class wich contains a List with _localRegelBLL items
          for (int i = 0; i < dataGridViewDocLijnen.Rows.Count; i++)
          {
           // Here i Fill the _localRegelBLL properties with the values of the datagridview
          // but something goes wrong here. It adds the last line as many times a there are rows...
            _localRegelBLL.Id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[0].Value);
            _localRegelBLL.Aantal = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[1].Value);
            _localRegelBLL.Rgl_oms_id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[2].Value);
            _localRegelBLL.Eenheid = dataGridViewDocLijnen.Rows[i].Cells[4].Value.ToString();
            _localRegelBLL.EenheidsPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[5].Value);
            _localRegelBLL.TotaalPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[6].Value);
            _localRegelBLL.Rgl_doc_id = docId;
            _localDocBLL.DocRegel.Add(_localRegelBLL);
          }
          #endregion
 
          // Save document lines
          bool saveDocLines = _localDocBLL.SaveDocLines(_localDocBLL.DocRegel);

Open in new window

0
Comment
Question by:Pit76
  • 4
  • 4
9 Comments
 
LVL 9

Expert Comment

by:tculler
ID: 24309341
Where in your code is this code snippet? If it's in like a Confirm event (ie a button click or something), then it'll just append the same data 3 times (which is what's going wrong, correct?)
0
 

Author Comment

by:Pit76
ID: 24309391
Yes indeed. this is a part of the SaveButton_Click Event.
I first save the general info of the document (like customer, address etc) Then I get the new ID and then I want to save the doclines from the DataGridView. But indeed it saves the same line (lastline in DGV) 3 times or as much as there are lines in the DGV.

What a'm I doing wrong here?

Grts.
0
 
LVL 1

Expert Comment

by:pras_gupta
ID: 24309436
_localRegelBLL  is reference to the the object , Evenytime you assign the values to it  updates the reference and hence last object is reflected three time. What you need to do is Create a new object for _localRegelBLL in the for loop and then add it to the list. Hope this helps.
0
Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

 
LVL 9

Expert Comment

by:tculler
ID: 24309452
This has to do with the nature of reference types vs. value types. The invocation of the "Add" method on line 15 adds the reference of the same object for as many times as there are rows, which is not quite what you want. May I also suggest using a foreach loop? Your code will look something like this:
void AddLinesToList(DataGridView myDataGridView)
{
     foreach(DataRow row in myDataGridView.Rows)
     {
          // Create a NEW object that contains the fields you
          // need (the type of this object is whatever you declared
          // "_localRegelBLL" as. Make sure it is declared
          // inside the loop.
          _localDocBLL.DocRegel.Add(_localRegelBLL);
     }
     // Save lines, etc.
}

Open in new window

0
 

Author Comment

by:Pit76
ID: 24309489
So something more like this?
Every time it passes the loop create a NEW RegelBLL instance, fill it's prperties, add it to the _localDocBLL.DocRegel List and then dispose the_localRegelBLL?

Grts and thx for your help!
void AddLinesToList(DataGridView myDataGridView)
{
     foreach(DataRow row in myDataGridView.Rows)
     {
          // Create a NEW object that contains the fields you
          // need (the type of this object is whatever you declared
          // "_localRegelBLL" as. Make sure it is declared
          // inside the loop.
          RegelBLL _localRegelBLL = new RegelBLL();
 
           _localRegelBLL.Id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[0].Value);
            _localRegelBLL.Aantal = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[1].Value);
            _localRegelBLL.Rgl_oms_id = Convert.ToInt32(dataGridViewDocLijnen.Rows[i].Cells[2].Value);
            _localRegelBLL.Eenheid = dataGridViewDocLijnen.Rows[i].Cells[4].Value.ToString();
            _localRegelBLL.EenheidsPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[5].Value);
            _localRegelBLL.TotaalPrijs = Convert.ToDouble(dataGridViewDocLijnen.Rows[i].Cells[6].Value);
            _localRegelBLL.Rgl_doc_id = docId;
 
          _localDocBLL.DocRegel.Add(_localRegelBLL);
          
          _localRegelBLL = null;
     }
     // Save lines, etc.
}

Open in new window

0
 
LVL 9

Expert Comment

by:tculler
ID: 24309491
Sorry, didn't check as well as I should have. In my post, DataRow should be DataGridViewRow. In the foreach loop, just mimic your code, except replace every instance of "dataGridViewDocLijnen.Rows[i]" with "row" (shortens the code quite a bit, eh? :)).

Let me know of further troubles, if any,
Nate
0
 

Author Comment

by:Pit76
ID: 24309527
K, thx for the help. Will test it tomorrow but it makes sence what you say so I think it'll work..

I'll let you know tomorrow.

Grts
0
 
LVL 9

Accepted Solution

by:
tculler earned 500 total points
ID: 24309554
Here, I'll just re-write the code for you :) that should be easier. Just copy/paste this method into your event handling method.
private void SaveButton_Click( System.Object sender, System.EventArgs evArgs )
{
	foreach(DataGridViewRow row in dataGridViewDocLijnen.Rows)
	{
		RegelBLL temp = new RegelBLL();
 
		temp.Id = System.Convert.ToInt32(row.Cells[0].Value);
		temp.Aantal = System.Convert.ToDouble(row.Cells[1].Value);
		temp.Rgl_oms_id = System.Convert.ToInt32(row.Cells[2].Value);
		temp.Eenheid = row.Cells[4].Value.ToString();
		temp.EenheidsPrijs = System.Convert.ToDouble(row.Cells[5].Value);
		temp.TotaalPrijs = System.Convert.ToDouble(row.Cells[6].Value);
		temp.Rgl_doc_id = docId;
 
		_localDocBLL.DocRegel.Add(temp);
 
		temp = null;
	}
	// Save here
}

Open in new window

0
 

Author Closing Comment

by:Pit76
ID: 31578237
Thx! It works perfect. Thx for your help!

Grts.
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Article by: Ivo
C# And Nullable Types Since 2.0 C# has Nullable(T) Generic Structure. The idea behind is to allow value type objects to have null values just like reference types have. This concerns scenarios where not all data sources have values (like a databa…
This article introduced a TextBox that supports transparent background.   Introduction TextBox is the most widely used control component in GUI design. Most GUI controls do not support transparent background and more or less do not have the…
Microsoft Active Directory, the widely used IT infrastructure, is known for its high risk of credential theft. The best way to test your Active Directory’s vulnerabilities to pass-the-ticket, pass-the-hash, privilege escalation, and malware attacks …
Although Jacob Bernoulli (1654-1705) has been credited as the creator of "Binomial Distribution Table", Gottfried Leibniz (1646-1716) did his dissertation on the subject in 1666; Leibniz you may recall is the co-inventor of "Calculus" and beat Isaac…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question