Solved

PHP While inside While problem

Posted on 2009-05-05
8
248 Views
Last Modified: 2013-12-12
I am trying to run a while script inside another while script, but it stops after one result.
What am I doing wrong?
<?php $cat_sql="SELECT * FROM cb_categories ORDER BY id ASC"; // Get all the categories and forums.

	$cat_result=mysql_query($cat_sql);

	while($cat_rows=mysql_fetch_array($cat_result)){ // Show next cateogry.

	?>

	<div class="index_cat_top"><font face="Comic Sans MS, cursive"><b><?php echo $cat_rows['name']; ?></b></font></div>

	<div class="index_cat_mid"><center><?php 

        $forum_sql="SELECT * FROM cb_forums WHERE category_id = $cat_rows[id] ORDER BY forum_id ASC";

        $forum_result=mysql_query($forum_sql);

        ?>

        <table width="820px" border="0" align="center" cellpadding="3" cellspacing="1" bgcolor="#CCCCCC">     

        <?php

        while($forum_rows=mysql_fetch_array($forum_result) or die(mysql_error())){ // Get all the forums in the category 

        ?>

        <tr>

        <td bgcolor="#FFFFFF"><? echo $forum_rows['forum_id']; ?></td>

        <td bgcolor="#FFFFFF"><a href="view_topic.php?id=<? echo $forum_rows['forum_id']; ?>"><? echo $forum_rows['name']; ?></a><BR></td>

        </tr>

        <?php } ?>

        </table></center>

    </div>

	<div class="index_cat_bot"></div>

    <br /><br />

<?php } ?>

Open in new window

0
Comment
Question by:DevinPitcher
8 Comments
 
LVL 19

Expert Comment

by:Michael701
ID: 24311200
which loop is stopping?

I really don't see any syntax issues.

try this

        $cat_result=mysql_query($cat_sql);
echo "categories: ". mysql_num_rows($cat_result) ."<br />\n";

let's see how many records are getting returned.

btw: if you just use echo statments you won't have to be switching in and out of php and your code should look cleaner.

see attached
        while($cat_rows=mysql_fetch_array($cat_result)){ // Show next cateogry.

        echo "<div class='index_cat_top'><font face='Comic Sans MS, cursive'><b>".$cat_rows['name']. "</b></font></div>\n";

        echo "<div class='index_cat_mid'><center>\n"; 

        $forum_sql="SELECT * FROM cb_forums WHERE category_id = $cat_rows[id] ORDER BY forum_id ASC";

        $forum_result=mysql_query($forum_sql);

        echo "<table width='820px' border=0 align='center' cellpadding=3 cellspacing=1 bgcolor='#CCCCCC'>\n";

        while($forum_rows=mysql_fetch_array($forum_result) or die(mysql_error())){ // Get all the forums in the category 

Open in new window

0
 

Author Comment

by:DevinPitcher
ID: 24312868
@Michael701

3 results, like I have in the database.
0
 
LVL 2

Expert Comment

by:-pio-
ID: 24313373
Hi,
At first sight I see no problem with the code but

I would change this line:

$forum_sql="SELECT * FROM cb_forums WHERE category_id = $cat_rows[id] ORDER BY forum_id ASC";

to this:

$forum_sql="SELECT * FROM cb_forums WHERE category_id = ".$cat_rows[id]." ORDER BY forum_id ASC";

Regards,
Peter
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 

Author Comment

by:DevinPitcher
ID: 24313733
@-pio-

I will try that when I get home. That looks like it just may work.
0
 
LVL 19

Expert Comment

by:Michael701
ID: 24315714
Did you view (verify) that the generated html is valid? Can you post a sample of the generated html?
0
 

Author Comment

by:DevinPitcher
ID: 24318193
Found the issue: Line 12 above.
the or die command had messed it up. Works great now.
while($forum_rows=mysql_fetch_array($forum_result) or die(mysql_error())){ // Get all the forums in the category

Open in new window

0
 

Accepted Solution

by:
ee_auto earned 0 total points
ID: 24599836
Question PAQ'd, 250 points refunded, and stored in the solution database.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Both Easy and Powerful How easy is PHP? http://lmgtfy.com?q=how+easy+is+php (http://lmgtfy.com?q=how+easy+is+php)  Very easy.  It has been described as "a programming language even my grandmother can use." How powerful is PHP?  http://en.wikiped…
I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

25 Experts available now in Live!

Get 1:1 Help Now