Solved

how can i get back to tryp block after an exception was thrown?

Posted on 2009-05-06
10
249 Views
Last Modified: 2013-12-17
hello experts,

i loop trought a DateTime[],
while looping i get current element,
i need the precedent elemnet too!
the prob is that for the first element there's no precendent.

i dont want to test if it's first to avoid the IndexOutOfException to raise,

my question:
what can i do, if there's a possibility, in order to continue the process after the Exception was
throws, is there a way to get back  to the try block with incrementing, the index, here 's my i variable?

i add the code,

all infos are welcome.
thanks in advance.
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            try
            {
                for (int i = 1; i < aDrainDateList.Length; i++ )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
 
            return _allDrains;
        }

Open in new window

0
Comment
Question by:toshi_
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 8

Assisted Solution

by:OBonio
OBonio earned 100 total points
ID: 24313692
I would aim not to throw the exception!  Checking whether you are on the first element or not is far better than letting an exception be thrown!

That said, try this :



private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            for (int i = 1; i < aDrainDateList.Length; i++ )
            {
                DateTime current_drain = aDrainDateList[index];
                DateTime  last_drain;
                try
                {
                  last_drain = = aDrainDateList[index-1]; 
                } 
                catch(IndexOutOfRangeException)
                {
                  last_drain = null;
                }
 
                if(last_drain!=null)
                {
                  _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                  _allDrains.Add(_tempDrain);
                }
            }
 
            return _allDrains;
        }

Open in new window

0
 
LVL 16

Assisted Solution

by:CuteBug
CuteBug earned 100 total points
ID: 24313702
Place the try catch block within your for loop and in the catch section you can add continue;
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            for (int i = 1; i < aDrainDateList.Length; i++ )
            {
                  try
                  {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                  }
                  catch(IndexOutOfRangeException){
                    continue;
                  }                
            }
 
            return _allDrains;
        }

Open in new window

0
 
LVL 9

Assisted Solution

by:tillgeffken
tillgeffken earned 100 total points
ID: 24313713
From my point of view its bad practice to aim for exceptions, that's why they're called exceptions. What's the purpose of this? Your Drain class requires a last_drain so why not skip it alltogther?

private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 1;
 
            try
            {
                for (int i = 2; i < aDrainDateList.Length; i++ )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
 
            return _allDrains;
        }

Open in new window

0
MIM Survival Guide for Service Desk Managers

Major incidents can send mastered service desk processes into disorder. Systems and tools produce the data needed to resolve these incidents, but your challenge is getting that information to the right people fast. Check out the Survival Guide and begin bringing order to chaos.

 
LVL 16

Expert Comment

by:CuteBug
ID: 24313722
Obonio's has provided a better solution.
0
 
LVL 9

Expert Comment

by:tillgeffken
ID: 24313763
I don't see the point in even processing index 0 when you already know that it can only fail.
0
 
LVL 16

Expert Comment

by:CuteBug
ID: 24313764
Another method is to loop backward. This will solve it altogether.

After the loop ends, just reverse the resultant array.
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            try
            {
                for (int i = aDrainDateList.Length - 1; i > 0; i-- )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
 
            // Reverse the order
            Array.Reverse(_allDrains);
 
            return _allDrains;
        }

Open in new window

0
 
LVL 4

Accepted Solution

by:
cauos earned 200 total points
ID: 24313813
yes Obonio's has provided a better solution.but the error occured in the index not index - 1 (he started the for loop from 1 )
 for (int i = 1; i < aDrainDateList.Length; i++ )
            {
                DateTime current_drain;
                DateTime  last_drain =aDrainDateList[index-1];                
                try
                {
                   current_drain = aDrainDateList[index];
                } 
                catch(IndexOutOfRangeException)
                {
                 current_drain= null;
                }
 
                if(current_drain!=null)
                {
                  _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                  _allDrains.Add(_tempDrain);
                }
            }

Open in new window

0
 
LVL 9

Expert Comment

by:tillgeffken
ID: 24313847
I still think there is no problem in the first place. You're creating one by trying to parse data of which you know that it doesn't exist. Or am i missing something?
0
 
LVL 4

Expert Comment

by:cauos
ID: 24313937
you right tillgeffken, there is no logic by doing this if he want to return the array list before end the method he can add the finally statement and return the array list.
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 1;
 
            try
            {
                for (int i = 2; i < aDrainDateList.Length; i++ )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
        finally
         {
            return _allDrains;
         }
        }

Open in new window

0
 
LVL 9

Expert Comment

by:tillgeffken
ID: 24314014
Actually i left the Exception in there because i was too lazy to delete it. The following should be just fine (at least you won't get an IndexOutOfRangeException)

private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
{
 Drain _tempDrain = null;
 ArrayList _allDrains = new ArrayList();
 int index = 1;
 
 for (int i = 2; i < aDrainDateList.Length; i++ )
 {
  DateTime current_drain = aDrainDateList[index];
  DateTime  last_drain = aDrainDateList[index-1];
  _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
  _allDrains.Add(_tempDrain);
 }
 return _allDrains;
}

Open in new window

0

Featured Post

Master Your Team's Linux and Cloud Stack!

The average business loses $13.5M per year to ineffective training (per 1,000 employees). Keep ahead of the competition and combine in-person quality with online cost and flexibility by training with Linux Academy.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
C#.NET and microsoft certification. 3 42
VB: Convert 2 dates to specific format 24 48
Switching Visual Studio 2015 to normal debug display 3 28
VB.NET 2008 - SQL Timeout 9 26
IP addresses can be stored in a database in any of several ways.  These ways may vary based on the volume of the data.  I was dealing with quite a large amount of data for user authentication purpose, and needed a way to minimize the storage.   …
Recently while returning home from work my wife (another .NET developer) was murmuring something. On further poking she said that she has been assigned a task where she has to serialize and deserialize objects and she is afraid of serialization. Wha…
Established in 1997, Technology Architects has become one of the most reputable technology solutions companies in the country. TA have been providing businesses with cost effective state-of-the-art solutions and unparalleled service that is designed…

825 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question