Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

how can i get back to tryp block after an exception was thrown?

Posted on 2009-05-06
10
Medium Priority
?
257 Views
Last Modified: 2013-12-17
hello experts,

i loop trought a DateTime[],
while looping i get current element,
i need the precedent elemnet too!
the prob is that for the first element there's no precendent.

i dont want to test if it's first to avoid the IndexOutOfException to raise,

my question:
what can i do, if there's a possibility, in order to continue the process after the Exception was
throws, is there a way to get back  to the try block with incrementing, the index, here 's my i variable?

i add the code,

all infos are welcome.
thanks in advance.
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            try
            {
                for (int i = 1; i < aDrainDateList.Length; i++ )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
 
            return _allDrains;
        }

Open in new window

0
Comment
Question by:toshi_
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 8

Assisted Solution

by:OBonio
OBonio earned 400 total points
ID: 24313692
I would aim not to throw the exception!  Checking whether you are on the first element or not is far better than letting an exception be thrown!

That said, try this :



private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            for (int i = 1; i < aDrainDateList.Length; i++ )
            {
                DateTime current_drain = aDrainDateList[index];
                DateTime  last_drain;
                try
                {
                  last_drain = = aDrainDateList[index-1]; 
                } 
                catch(IndexOutOfRangeException)
                {
                  last_drain = null;
                }
 
                if(last_drain!=null)
                {
                  _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                  _allDrains.Add(_tempDrain);
                }
            }
 
            return _allDrains;
        }

Open in new window

0
 
LVL 16

Assisted Solution

by:CuteBug
CuteBug earned 400 total points
ID: 24313702
Place the try catch block within your for loop and in the catch section you can add continue;
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            for (int i = 1; i < aDrainDateList.Length; i++ )
            {
                  try
                  {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                  }
                  catch(IndexOutOfRangeException){
                    continue;
                  }                
            }
 
            return _allDrains;
        }

Open in new window

0
 
LVL 9

Assisted Solution

by:tillgeffken
tillgeffken earned 400 total points
ID: 24313713
From my point of view its bad practice to aim for exceptions, that's why they're called exceptions. What's the purpose of this? Your Drain class requires a last_drain so why not skip it alltogther?

private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 1;
 
            try
            {
                for (int i = 2; i < aDrainDateList.Length; i++ )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
 
            return _allDrains;
        }

Open in new window

0
NEW Veeam Agent for Microsoft Windows

Backup and recover physical and cloud-based servers and workstations, as well as endpoint devices that belong to remote users. Avoid downtime and data loss quickly and easily for Windows-based physical or public cloud-based workloads!

 
LVL 16

Expert Comment

by:CuteBug
ID: 24313722
Obonio's has provided a better solution.
0
 
LVL 9

Expert Comment

by:tillgeffken
ID: 24313763
I don't see the point in even processing index 0 when you already know that it can only fail.
0
 
LVL 16

Expert Comment

by:CuteBug
ID: 24313764
Another method is to loop backward. This will solve it altogether.

After the loop ends, just reverse the resultant array.
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 0;
 
            try
            {
                for (int i = aDrainDateList.Length - 1; i > 0; i-- )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
 
            // Reverse the order
            Array.Reverse(_allDrains);
 
            return _allDrains;
        }

Open in new window

0
 
LVL 4

Accepted Solution

by:
cauos earned 800 total points
ID: 24313813
yes Obonio's has provided a better solution.but the error occured in the index not index - 1 (he started the for loop from 1 )
 for (int i = 1; i < aDrainDateList.Length; i++ )
            {
                DateTime current_drain;
                DateTime  last_drain =aDrainDateList[index-1];                
                try
                {
                   current_drain = aDrainDateList[index];
                } 
                catch(IndexOutOfRangeException)
                {
                 current_drain= null;
                }
 
                if(current_drain!=null)
                {
                  _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                  _allDrains.Add(_tempDrain);
                }
            }

Open in new window

0
 
LVL 9

Expert Comment

by:tillgeffken
ID: 24313847
I still think there is no problem in the first place. You're creating one by trying to parse data of which you know that it doesn't exist. Or am i missing something?
0
 
LVL 4

Expert Comment

by:cauos
ID: 24313937
you right tillgeffken, there is no logic by doing this if he want to return the array list before end the method he can add the finally statement and return the array list.
private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
        {
            Drain _tempDrain = null;
            ArrayList _allDrains = new ArrayList();
            int index = 1;
 
            try
            {
                for (int i = 2; i < aDrainDateList.Length; i++ )
                {
                    DateTime current_drain = aDrainDateList[index];
                    DateTime  last_drain = aDrainDateList[index-1];
                    _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
                    _allDrains.Add(_tempDrain);
                }
            }catch(IndexOutOfRangeException)
            {
                
            }
        finally
         {
            return _allDrains;
         }
        }

Open in new window

0
 
LVL 9

Expert Comment

by:tillgeffken
ID: 24314014
Actually i left the Exception in there because i was too lazy to delete it. The following should be just fine (at least you won't get an IndexOutOfRangeException)

private ArrayList GetDrainsObj(DateTime[] aDrainDateList)
{
 Drain _tempDrain = null;
 ArrayList _allDrains = new ArrayList();
 int index = 1;
 
 for (int i = 2; i < aDrainDateList.Length; i++ )
 {
  DateTime current_drain = aDrainDateList[index];
  DateTime  last_drain = aDrainDateList[index-1];
  _tempDrain = new Drain(id_, Ecolog_.Id_int, current_drain, last_drain, DateTime.Now);
  _allDrains.Add(_tempDrain);
 }
 return _allDrains;
}

Open in new window

0

Featured Post

Learn Veeam advantages over legacy backup

Every day, more and more legacy backup customers switch to Veeam. Technologies designed for the client-server era cannot restore any IT service running in the hybrid cloud within seconds. Learn top Veeam advantages over legacy backup and get Veeam for the price of your renewal

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article describes relatively difficult and non-obvious issues that are likely to arise when creating COM class in Visual Studio and deploying it by professional MSI-authoring tools. It is assumed that the reader is already familiar with the cla…
Hello there! As a developer I have modified and refactored the unit tests which was written by fellow developers in the past. On the course, I have gone through various misconceptions and technical challenges when it comes to implementation. I would…
In response to a need for security and privacy, and to continue fostering an environment members can turn to for support, solutions, and education, Experts Exchange has created anonymous question capabilities. This new feature is available to our Pr…
In a question here at Experts Exchange (https://www.experts-exchange.com/questions/29062564/Adobe-acrobat-reader-DC.html), a member asked how to create a signature in Adobe Acrobat Reader DC (the free Reader product, not the paid, full Acrobat produ…
Suggested Courses

886 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question