• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1787
  • Last Modified:

Pass form values in coldfusion

Hello experts.
I need help to decide wich method i should use to pass form values from two search pages (two search forms) to one result page and one detailpage.
To build this i have used Url variables.
On the result page i have two link to the searchpage1 Or 2 depending on a Url variable and using
<cfswitch and cfcase.
The first link is :New search
And the second  to Edit the search fields using the url variables:
I also handle the number of records with a form.
And the function sort by that works with url variables too.

I have also  alink to the detail page.
On the detail page are these two links for new search and edit search and a third one that goes to the result page(not back)

The question is how can i pass the search values from page to another page.
f.e if i choose 20 for number of records than i loose the search values in URl.If i add #CGI.Query_String# to URL i get more than once the value for the records.
And than from the result page to the detail and than back how can i pass the values back.
Do i have to use Form variables instead of Url.Do i have to use cookies or session?
Please help.
Here are part of the codes .
The first search page:
<cfform action="Results.cfm" method="get" name="SearchForm" id="SearchForm">
Price from
<cfselect name="S_Preisvon">
  <option value="" <cfif  url.S_Preisvon EQ "" > selected="selected"</cfif>>All</option>
   <cfoutput query="q_preisvon">
   <option value="#q_preisvon.PRB_Id#" <cfif  listfind(q_preisvon.PRB_Id,url.S_Preisvon) > selected="selected"</cfif>>#q_preisvon.PRB# &##8364;</option>
     </cfoutput>
</cfselect></br>
Price to                        
  <cfselect name="S_Preisbis">
     <option value="" <cfif  url.S_Preisbis EQ "" >selected="selected"</cfif>>All</option>
      <cfoutput query="q_preisbis">
       <option value="#q_preisbis.PRB_Id#" <cfif  listfind(q_preisbis.PRB_Id,url.S_Preisbis)> selected="selected"</cfif>>#q_preisbis.PRB# &##8364;</option>
      </cfoutput>
   </cfselect></br>
Results per page
  <cfselect class="selectleftbottom" name="nrecords">
                  <option value="5" <cfif Url.nrecords EQ 5 > selected="selected"</cfif>>5 </option>
                  <option value="10" <cfif Url.nrecords EQ 10> selected="selected"</cfif>>10 </option>
                  <option value="20" <cfif Url.nrecords EQ 20 > selected="selected"</cfif>>20 </option>
                  <option value="30" <cfif Url.nrecords EQ 30 > selected="selected"</cfif>>30 </option>
                  <option value="50" <cfif Url.nrecords EQ 50 > selected="selected"</cfif>>50 </option>
                  <option value="100" <cfif Url.nrecords EQ 100 > selected="selected"</cfif>>100 </option>
        </cfselect> 
</cfform>        
 
 
Result page:
<cffunction name="cleanOrderBy" returntype="string">
  <cfargument name="theValue" type="string">
  <cfargument name="defaultSort" type="string">
  <cfif REFindNoCase("[\w,]{1,50}\s+(asc|desc)\s*",theValue,1)>
    <cfset matches = REFindNoCase("[\w,]{1,50}\s+(asc|desc)\s*",theValue,1,"true")>
    <cfreturn Mid(theValue,matches.pos[1],matches.len[1])/>
  </cfif>
  <cfreturn defaultSort/>
</cffunction>
<cfset CurrentPage=GetFileFromPath(GetBaseTemplatePath())>
<cfparam name="PageNum_artikel" default="1">
<cfparam name="url.nrecords" default="10">
<cfparam name="url.tfm_orderby" default="Price">
<cfparam name="url.tfm_order" default="ASC">
<cfset sql_orderby = cleanOrderBy("#tfm_orderby# #tfm_order#","Price")>
<cfif true eq true>
<cfquery name="artikel" datasource="#request.dsn#">
SELECT SELECT  a.Art_ID,a.Mobile_Sub_ID,a.Name,a.Price,a.Datein
WHERE (0=0
<cfif isdefined("Url.S_Preisvon")>
   <cfif Url.S_Preisvon NEQ "">      
  AND a.Price >= <cfqueryparam value="#URL.S_Preisvon#" cfsqltype="cf_sql_numeric">
      </cfif>
    </cfif>            
<cfif isDefined ("Url.S_Preisbis")>
 <cfif Url.S_Preisbis NEQ "">
 AND  a.Price <= <cfqueryparam value="#URL.S_Preisbis#" cfsqltype="cf_sql_numeric">
       </cfif>
     </cfif>
  </cfquery>
    <cfset QueryString_artikel=Iif(CGI.QUERY_STRING NEQ "",DE("&"&CGI.QUERY_STRING),DE(""))>
</cfif>
<cfset MaxRows_artikel="#url.nrecords#">
<cfset StartRow_artikel=Min((PageNum_artikel-1)*MaxRows_artikel+1,Max(artikel.RecordCount,1))>
<cfset EndRow_artikel=Min(StartRow_artikel+MaxRows_artikel-1,artikel.RecordCount)>
<cfset TotalPages_artikel=Ceiling(artikel.RecordCount/MaxRows_artikel)>
<cfset QueryString_artikel=Iif(CGI.QUERY_STRING NEQ "",DE("&"&XMLFormat(CGI.QUERY_STRING)),DE(""))>
<cfset tempPos=ListContainsNoCase(QueryString_artikel,"PageNum_artikel=","&")>
<cfif tempPos NEQ 0>
  <cfset QueryString_artikel=ListDeleteAt(QueryString_artikel,tempPos,"&")>
</cfif>
 
 
<cfscript>
TFM_LimitLinksEndCount = 10;
TFM_startLink = Max(1,PageNum_artikel - int(TFM_LimitLinksEndCount/2));
TFM_temp = TFM_startLink + TFM_LimitLinksEndCount - 1;
TFM_endLink = min(TFM_temp, TotalPages_artikel);
If (TFM_endLink NEQ TFM_temp) {
  TFM_startLink = max(1,TFM_endLink - TFM_LimitLinksEndCount + 1);
}
</cfscript>
<cfscript>
//sort column headers for artikel
tfm_saveParams = "";
tfm_keepParams = "";
if(tfm_order EQ "ASC") {
	tfm_order = "DESC";
}else{
	tfm_order = "ASC";
}
if(ListLen(tfm_saveParams)GT 0) {
	tfm_params=ListToArray(tfm_saveParams,",");
	For (i=1; i LTE ArrayLen(tfm_params); i=i+1) {
  		if(isDefined(tfm_params[i])) {
      			tfm_temp = tfm_params[i];
			if(isDefined("form." & tfm_params[i])) tfm_temp = "form." & tfm_params[i];
      			tfm_keepParams = tfm_keepParams &  LCase(tfm_params[i]) & "=" & URLEncodedFormat(Evaluate(tfm_temp)) & "&";
		}
	}
}
tfm_orderbyURL = CGI.SCRIPT_NAME & "?" & tfm_keepParams & "tfm_order=" & tfm_order & "&tfm_orderby=";
</cfscript>
  
<!--- script for nrecords --->
<script language="JavaScript">
<!--
     function slappy() {
          document.changy.submit();
     }
//-->
</script> 
<!--- end --->
 
<!--- Body --->
<!--- the links --->
<a href=<cfswitch expression="#url.S_Mobile_Sub_ID#">
<cfcase value="1">
  "Search/Search.cfm?Mobile_Sub_ID=1"
  </cfcase>
  <cfcase value="2">
  "Search/Search.cfm?Mobile_Sub_ID=2"
  </cfcase>
</cfswitch>>New Search</a>
<a href=<cfswitch expression="#url.S_Mobile_Sub_ID#">
  <cfcase value="1">
  "Search/Search.cfm?Mobile_Sub_ID=1&<cfoutput>#CGI.QUERY_STRING#</cfoutput>"
  </cfcase>
  <cfcase value="2">
  "Search/Search.cfm?Mobile_Sub_ID=2&<cfoutput>#CGI.QUERY_STRING#</cfoutput>"
  </cfcase></cfswitch>>Edit  Search criteria</a>
 
 
<!--- the form for nrecords--->
<form action="Results.cfm?lite=Results<cfif (isdefined("url.pagenumber"))>&pagenumber=#url.pagenumber#</cfif>&S_Mobile_Sub_Id=<cfoutput>#artikel.Mobile_Sub_id#</cfoutput>" method="get" name="changy" id="changy">
      <div align="right">Results per page :
        <select  id="nrecords"name="nrecords" onChange="slappy();" class="Resultnumber">
            <cfloop index="kk" list="5,10,20,30,50,100">
              <option value="<cfoutput>#kk#</cfoutput>" 
	  <cfif kk is url.nrecords>selected</cfif> > <cfoutput>#kk#</cfoutput> </option>
            </cfloop>
          </select>
      </div>
    </form>
    <!--- end --->
	
<!--- the sort by code --->
<a href="<cfoutput>#tfm_orderbyURL#</cfoutput>Art_ID&nrecords=<cfoutput>#nrecords#</cfoutput>">Day Insert</a>                  
 <a href="<cfoutput>#tfm_orderbyURL#</cfoutput>Price&nrecords=<cfoutput>#nrecords#</cfoutput>">Price</a>   
 
 
 <!--- in the query output is the link to the detailpage--->
 <a href="Detail.cfm?Art_ID=#URLEncodedFormat(artikel.Art_ID)#" title="Detailansicht" target="_blank">Detail</a>

Open in new window

0
Panos
Asked:
Panos
  • 7
  • 3
2 Solutions
 
azadisaryevCommented:
you can use either SESSION or FORM vars for this - they both have their pros and cons:

1) FORM vars:
pros:
each form, if a user decides to open several tabs with your search form, will be unique and post its own values to the action page
cons:
you will have to re-create the form (using hidden fields if you do not need to display and form fields to the user) on each and every page, grabbing posted form vars and populating a new form with them. all your 'links' to other pages that use these form vars will have to be form posts, not your regular href links.

2) SESSION vars:
pros:
no need to re-create form on every page of the process
cons:
unless you implement some unique form identifier, pass it along to other pages (i.e. as a URL or FORM variable) and create a separate session structure for each unique form, if a user opens several tabs with your search form you may end up overwriting your session vars with values from a from opened in a different tab, confusing the hell out of your users...

so, basically, in either case there will be some sort of duplication of variables, either as a new session structure or a new form...

the FORM way will be easier if your results pagination is javascript (client-side) based: it's harder to put a client-side ui selection (like currently viewed page, or number of results per page if that's an option you provide) into session scope than to populate a hidden form field with a little js...

i will try to make a quick example for you and post it here.

Azadi
0
 
PanosAuthor Commented:
Hi azadi.
Could this articel help too?
http://tutorial55.easycfm.com/
0
 
azadisaryevCommented:
yes, something like that will let you create a copy of submitted form from its values, or create a query string to add to a link url.

a slightly 'better' equivalent of it is using array notation instead of evaluate() function:

A) create a query string from submitted form fields and their values:
<cfloop index="thefield" list="#form.fieldnames#">
    <cfset querystring = thefield & "=" & form[thefield] & "&">
</cfloop>
<cfset querystring = "?" & left(querystring, len(querystring)-1)>

this querystring can be added to a link that takes users back to results page, or to editing search criteria page...

<cfoutput><a href="somepage.cfm#querystring#">...</a></cfoutput>

B) create a new hidden form from submitted form fields and their values:
<form ...>
<cfoutput>
<cfloop index="thefield" list="#form.fieldnames#">
<input type="hidden" name="#thefield#" value="#form[thefield]#" />
</cfloop>
</cfoutput>
</form>

you can then use a link with a little javascript in onclick event that set's the form's action page and submits it...

there is no 'uiversal' way to deal with your situation. the best way for you to approach the issue (to use session scope, or re-create forms, or use url variables, or a combination of these) will be determined by your data, your application setup and how much time you can devote to this.

Azadi
0
Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

 
PanosAuthor Commented:
Hi azadi.
Thank you fo your help and the detailed description and i think i'm very near  to solve my problem.
I tried the A) but when i click on the link (on the same page) i get the error Element FIELDNAMES is undefined in FORM and in the url has been added only one form field and his value.
And as i want first of all to submit to the page that i'm allready (result page)please help with the script that i need in the B) case.
0
 
PanosAuthor Commented:
Hi again.
I did add :
<cfparam name="form.fieldnames" default="">
<cfparam name="querystring" default="">
Now the next error i have is:
The 2 parameter of the Left function, which is now -1, must be a positive integer
0
 
azadisaryevCommented:
both A) and B) will only work AFTER the form has been submitted.

it looks like you are trying to use these methods on the same page as your form, not on the form;s action page...

Azadi
0
 
PanosAuthor Commented:
Because i m on the resut page and want to set the numbers of the records or the order by function i use this on the same page
0
 
PanosAuthor Commented:
Hi azadi.
I tried this to another page , i have no error but the code passes only the last formfield and value
0
 
PanosAuthor Commented:
My form is on the searchpage.
action page is now in my example testfields.cfm and there is the link.
Here is the testfields.cfm with all the variations.
<cfparam name="form.fieldnames" default="">
<cfparam name="querystring" default="">

<cfloop index="thefield" list="#form.fieldnames#" >
    <cfset fields="#thefield# = #evaluate(thefield)#">
    <cfoutput>#fields#</cfoutput><br>
</cfloop>

<cfloop index="thefield" list="#form.fieldnames#">
    <cfset querystring = thefield & "=" & form[thefield] & "&">
</cfloop>
<cfset querystring = "?" & left(querystring, len(querystring)-1)>

<cfoutput><a href="testfields.cfm#querystring#">test</a></cfoutput>



B.
<form action="testfields.cfm">
<cfoutput>
<cfloop index="thefield" list="#form.fieldnames#">
<input type="hidden" name="#thefield#" value="#form[thefield]#" />

</cfloop>
</cfoutput><input name="" type="submit" />
</form>
0
 
PanosAuthor Commented:
Hi azadi.
Looking around in the code from sites with these functions i saw that they use forms with hidden fields and some have different action pages end not the same.
I will try to separate each function now and make new questions
Thank you for your help.
regards
Panos
0

Featured Post

Become an Android App Developer

Ready to kick start your career in 2018? Learn how to build an Android app in January’s Course of the Month and open the door to new opportunities.

  • 7
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now