Running .bat file in some different thread or wait .bat file response till some given time

you should be reading stderr as well as stdout

to kill it after a certain time you can use a Timer, or run it in a separate thread and use Thread..join() method to wait a certain amount of time before killing it

Many thanks for your help

Where in above code I should call my method

FindNewMail.runbatch((strNewsletterID, newsletterOutlookConf, newsletterBO);

and wait to for max  30 min process to execute in different thread.

Thanks again for your response.

you would add above to runBatch()

public static void runbatch(String strNewsletterID, NewsletterOutlookConfBO newsletterOutlookConf, NewsletterBO newsletterBO)
            throws Exception

 Runtime runtime = Runtime.getRuntime();
  Process process = runtime.exec(commandLine);
  /* Set up process I/O. */
  ...
  Worker worker = new Worker(process);
  worker.start();
  .....


If you want it done in a separate thread then the easiest would be to call runBatch() form a new thread
(a utility method could be used for that)


new Thread(new Runnable() {
   public void run() {
       runBatch(.....
   }
});

Many Thanks,

If I use
new Thread(new Runnable() {
   public void run() {
       runBatch(.....
   }
});

Then how can I destroy thread after max 30 min. if thread not broken

because my batch file will run in infinite loop and running batch depends on the request comes from external source.

So, if my process nit completed then I wanted my thread to live max after 30 min.

If my process completes then my thread should be destroyed instantly rather than waiting for 30 min

Many Thanks

the code I posted earlier will handle that

Hi,

Sorry for the late response, Now I am trying code as you have suggested.

I get error

Exception in thread "main" java.lang.NoSuchMethodError: smecoutlook.FindNewMail.runbatch(Ljava/lang/String;Lcom/pbms/smecoutlook/businessobjects/NewsletterOutlookConfBO;Lcom/pbms/smecoutlook/businessobjects/NewsletterMailsBO;)V
        at com.pbms.smecoutlook.businesslogic.ProcessRequests.createNewSubsequentCampaign(ProcessRequests.java:758)
        at com.pbms.smecoutlook.businesslogic.ProcessRequests.processSetUpRequest(ProcessRequests.java:113)
        at smecoutlook.FindNewMail.handleNewMail(FindNewMail.java:246)
        at smecoutlook.FindNewMail.findnewMails(FindNewMail.java:105)
        at smecoutlook.SMECOutlookMain.main(SMECOutlookMain.java:69)
Java Result: 1
BUILD SUCCESSFUL (total time: 42 seconds)


AND MY MAIN LOOP ALSO EXISTS


public Integer runbatch(String strNewsletterID, NewsletterOutlookConfBO newsletterOutlookConf, NewsletterMailsBO newsletterMailsBO)
            throws Exception
    {

        final String strnewsletterIDF =  strNewsletterID;
        final NewsletterOutlookConfBO newsletterOutlookConfF =  newsletterOutlookConf;
        final NewsletterMailsBO newsletterMailsBOF =  newsletterMailsBO;

        Process p  = Runtime.getRuntime().exec("cmd /C "+newsletterOutlookConf.BatchFilePath+ " "+
                                            newsletterMailsBO.newsletterBO.NewsletterAction+ " "+strNewsletterID+" "+ newsletterMailsBO.FromAddress+" "+ newsletterMailsBO.newsletterBO.NewsletterRefno);


        BufferedReader in = new BufferedReader(
                                         new InputStreamReader(p.getInputStream()));
                     String line = null;
                     while ((line = in.readLine()) != null) {
                         System.out.println(line);
                     }


    Worker worker = new Worker(p);
    worker.start();

    try {
    worker.join(100000000);

    if (worker.exit != null)
      return worker.exit;
    else
      throw new TimeoutException();
  } catch(InterruptedException ex) {
    worker.interrupt();
    Thread.currentThread().interrupt();
    throw ex;
  } finally {
    p.destroy();
  }
       
    }
   
   
   


AND WHEN I am running below code

My code is not going even in main thread


public void runbatch(String strNewsletterID, NewsletterOutlookConfBO newsletterOutlookConf, NewsletterMailsBO newsletterMailsBO)
            throws Exception
    {

        final String strnewsletterIDF =  strNewsletterID;
        final NewsletterOutlookConfBO newsletterOutlookConfF =  newsletterOutlookConf;
        final NewsletterMailsBO newsletterMailsBOF =  newsletterMailsBO;

        Thread thread = new Thread(new Runnable() {

            public void run() {
                try
                {
                    runBatchProcessInThread(strnewsletterIDF, newsletterOutlookConfF, newsletterMailsBOF);
                }catch(Exception ex)
                {
                    mL.error("Error in running batch process", ex);
                }
            }
        });



        /*
//                     Process p = Runtime.getRuntime().exec("c:\\EyeDropper.exe");
                        System.out.print("Running .bat file from location "+newsletterOutlookConf.BatchFilePath);
                       
                      Process p = Runtime.getRuntime().exec("cmd /C "+newsletterOutlookConf.BatchFilePath+ " "+
                                            newsletterMailsBO.newsletterBO.NewsletterAction+ " "+strNewsletterID+" "+ newsletterMailsBO.FromAddress+" "+ newsletterMailsBO.newsletterBO.NewsletterRefno);

/ **************************** NO NEEDS FOLLOWING IF RUN C:\EYEDRIOPPER.EXE *************** /
                     BufferedReader in = new BufferedReader(
                                         new InputStreamReader(p.getInputStream()));
                     String line = null;
                     while ((line = in.readLine()) != null) {
                         System.out.println(line);
                     }

/***************************************************************************************** /
 
 */

    }
   
   
Please guide

Many Thanks for your co-operation

error suggests you have changed one class with recompiling others. Try rebuilding all your classes.

Thanks, But which one is the correct code

As if I see my attached code

I am executing batch file first and then latter on I am starting worker process.

But in this case if my .bat processhangs for some reason then it will never come to worker process line

Please guide

Many Thanks

public Integer runbatch(String strNewsletterID, NewsletterOutlookConfBO newsletterOutlookConf, NewsletterMailsBO newsletterMailsBO)
            throws Exception
    {
 
        final String strnewsletterIDF =  strNewsletterID;
        final NewsletterOutlookConfBO newsletterOutlookConfF =  newsletterOutlookConf;
        final NewsletterMailsBO newsletterMailsBOF =  newsletterMailsBO;
 
        Process p  = Runtime.getRuntime().exec("cmd /C "+newsletterOutlookConf.BatchFilePath+ " "+
                                            newsletterMailsBO.newsletterBO.NewsletterAction+ " "+strNewsletterID+" "+ newsletterMailsBO.FromAddress+" "+ newsletterMailsBO.newsletterBO.NewsletterRefno);
 
 
        BufferedReader in = new BufferedReader(
                                         new InputStreamReader(p.getInputStream()));
                     String line = null;
                     while ((line = in.readLine()) != null) {
                         System.out.println(line);
                     }
 
 
    Worker worker = new Worker(p);
    worker.start();
 
    try {
    worker.join(100000000);
 
    if (worker.exit != null)
      return worker.exit;
    else
      throw new TimeoutException();
  } catch(InterruptedException ex) {
    worker.interrupt();
    Thread.currentThread().interrupt();
    throw ex;
  } finally {
    p.destroy();
  }
        
    }

Select allOpen in new window

because your ProcessRequests class is failing to call it
recompile ProcessRequests.java

Thanks,

I am using below code as you have suggested.

For test I am trying to wait for my process to wait for max 100 milli seconds and if it does not respond then exit the process and my main loop continue.

And I wanted this in always in new thread

But my code is not working well. It is waiting for long if my process do not respond for long

For test purpose I have slept my application calling from batch file for

Thread.sleep(1000000000);

And it is waiting for long to respond which I donot wanted

Please guide

Many Thanks

public Integer runbatch(String strNewsletterID, NewsletterOutlookConfBO newsletterOutlookConf, NewsletterMailsBO newsletterMailsBO)
            throws Exception
    {
 
        final String strnewsletterIDF =  strNewsletterID;
        final NewsletterOutlookConfBO newsletterOutlookConfF =  newsletterOutlookConf;
        final NewsletterMailsBO newsletterMailsBOF =  newsletterMailsBO;
 
        Process p  = Runtime.getRuntime().exec("cmd /C "+newsletterOutlookConf.BatchFilePath+ " "+
                                            newsletterMailsBO.newsletterBO.NewsletterAction+ " "+strNewsletterID+" "+ newsletterMailsBO.FromAddress+" "+ newsletterMailsBO.newsletterBO.NewsletterRefno);
 
 
        BufferedReader in = new BufferedReader(
                                         new InputStreamReader(p.getInputStream()));
                     String line = null;
                     while ((line = in.readLine()) != null) {
                         System.out.println(line);
                     }
 
 
    Worker worker = new Worker(p);
    worker.start();
 
    try {
    worker.join(100);
 
    if (worker.exit != null)
      return worker.exit;
    else
      throw new TimeoutException();
  } catch(InterruptedException ex) {
    worker.interrupt();
    Thread.currentThread().interrupt();
    throw ex;
  } finally {
    p.destroy();
  }
        
    }

Select allOpen in new window

Many Thanks