asked on

Contact page returning JSON

Hey,

I have my contact page here: http://bestqualitypools.info/contact - when I fill out the form and hit submit I get:

{"success": true}

And if you submit it blank:

{"success": false, "errors": ["State can't be empty", "Message can't be empty", "Product can't be empty", "Email can't be empty", "Email should be like xxx@yyy.zzz", "First name can't be empty", "Last name can't be empty"]}

I am not sure why it is not submitting the form, my controller/model is here:

CONTACT_REQUEST.RB
 
 
class ContactRequest
  include Validatable
 
  attr_accessor :email, :first_name, :last_name, :message, :state, :product
 
 
  validates_presence_of :email, :first_name, :last_name, :message, :state, :product
  validates_format_of    :email,
                         :with => %r{\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z}i, :message => "should be like xxx@yyy.zzz"
 
 
end
 
 
INDEX_CONTROLLER.RB
 
class IndexController < ApplicationController
  def index
    
  end
  
  def pools
    
  end  
  
  def grills
 
  end
  
  def spa
    
  end
  
  def equipment
    
  end
  
  def patio
    
  end
  
  def contact
          if request.post?
            output = ""
            
            @contact = ContactRequest.new
            
            @contact.email = params[:contact]['email']
            @contact.product = params[:contact]['product']
            @contact.first_name = params[:contact]['first_name']
            @contact.last_name = params[:contact]['last_name']
            @contact.state = params[:contact]['state']
            @contact.message = params[:contact]['message']
 
            if @contact.valid?
              
              Notifications.deliver_contact_request(params[:contact])
              render :text => {:success => true}.to_json
              return
            end
            
            render :text => {:success => false, :errors => @contact.errors.full_messages}.to_json
            
            return
          end
  end
  
  def sales
    @promo_image = PromoImage.find(:first)
    
    if @promo_image.nil?
      @partial = "no_sales"
    else
      @partial = "current_sales"
    end
  end
end
 
 
Any ideas on what I can do to get that to work? Not sure why it is doing that.

Open in new window

cminear

In the ContactRequest model object, you have the 'validates_presence_of' set. If you compare the fields included in this line with the error messages, you will see there is one error message for each and every one of those fields. The 'validates_presence_of' is a model callback which makes sure the model is not saved to the database without those fields having a value. When this validation fails, the model object is not saved, and an Error object is added to the model object, which includes one or more error messages.

You also have an extra error message, which corresponds to the 'validates_format_of'. Quite simply, an empty string does not match the format you've specified for an email address.

Not knowing exactly what you're trying to accomplish, you typically want the same form redisplayed to the user, along with the error messages. The way to display the errors for the model object is to remove the 'render :text (:success => false, ..." line from the controller and add
<%= error_messages_for @contact %>
(for your case) at the top of the form view template (app/views/index/contact.rhtml, or something like this). If you do this, the fields which caused the errors should also be bordered by a red outline, to help call out the problem fields.