Solved

upload file to FTP

Posted on 2009-05-12
12
749 Views
Last Modified: 2012-08-14
hi All,
         i'm trying to upload a file to FTP server. but i'm not able to upload and could not any err message. please verify mycode and help me

strucking at this line        
OutputStream os= cconn.openUploadStream(targetfile); // STRUCKING HERE

IF not can u plz some links code snippets for upload to FTP

FTPupload.java
=======================
import java.io.File;
import java.io.FileInputStream;
import java.io.OutputStream;
 
 
public class FTPupload {
    protected FTPclientConn cconn;
    public final String localfile;
    public final String targetfile;
 
    public FTPupload(String _host, String _user, String _password,
         String _localfile, String _targetfile) {
  cconn= new FTPclientConn(_host, _user, _password);
  localfile= _localfile;
  targetfile= _targetfile;
  doit();
    }
    public FTPupload(String _host, String _user, String _password, String _file) {
  cconn= new FTPclientConn(_host, _user, _password);
  localfile= _file;
  targetfile= _file;
  doit();
    }
 
    protected void doit() {
  try {
 
       OutputStream os= cconn.openUploadStream(targetfile); // STRUCKING HERE
 
       FileInputStream is=  new FileInputStream(localfile);
      byte[] buf= new byte[16384];
      int c;
      while (true) {
    //System.out.print(".");
    c= is.read(buf);
    if (c<= 0)  break;
    //System.out.print("[");
    os.write(buf, 0, c);
    //System.out.print("]");
      }
      os.close();
      is.close();
      cconn.close(); // section 3.2.5 of RFC1738
  } catch (Exception E) {
      System.err.println(E.getMessage());
      E.printStackTrace();
  }
    }
 
    public static void main(String args[]) {
  // Usage: FTPupload host, user, password, file
//  new FTPupload(args[0], args[1], args[2], args[3]);
     new FTPupload("xxx.xx.xx.xx:21","UN","PWD","C:\\Test.txt","Upload\\test.txt");  	
    }
 
}
 
 
 
 
 
 
FTPClientConn.java
================================
 
import java.io.*;
import java.net.*;
 
 
class FTPclientConn {
    public final String host;
    public final String user;
    protected final String password;
    protected URLConnection urlc;
 
    public FTPclientConn(String _host, String _user, String _password) {
  host= _host;  user= _user;  password= _password;
  urlc = null;
    }
    protected URL makeURL(String targetfile) throws MalformedURLException  {
  if (user== null)
      return new URL("ftp://"+ host+ "/"+ targetfile+ ";type=i");
  else
      return new URL("ftp://"+ user+ ":"+ password+ "@"+ host+ "/"+ targetfile+ ";type=i");
    }
 
    protected InputStream openDownloadStream(String targetfile) throws Exception {
  URL url= makeURL(targetfile);
  urlc = url.openConnection();
  InputStream is = urlc.getInputStream();
  return is;
    }
 
    protected OutputStream openUploadStream(String targetfile) throws Exception {
  URL url= makeURL(targetfile);
  urlc = url.openConnection();
  OutputStream os = urlc.getOutputStream();
  return os;
    }
 
    protected void close() {
  urlc= null;
    }
}

Open in new window

0
Comment
Question by:websyn
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 6
  • 4
  • 2
12 Comments
 
LVL 92

Expert Comment

by:objects
ID: 24362997
>      new FTPupload("xxx.xx.xx.xx:21","UN","PWD","C:\\Test.txt","Upload\\test.txt");    


try:

     new FTPupload("xxx.xx.xx.xx:21","UN","PWD","C:\\Test.txt","Upload/test.txt");    

0
 
LVL 20

Expert Comment

by:ChristoferDutz
ID: 24363001
If this is not part of a homework or something similar, why reinvent the wheel?

Thry this allready finished FTP Client for java from the apache guys:
http://commons.apache.org/net/
0
 
LVL 92

Expert Comment

by:objects
ID: 24363003
commons net provides a nicer ftp client if you're interested

http://commons.apache.org/net/

0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 

Author Comment

by:websyn
ID: 24363289
getting this err
java.io.FileNotFoundException: CWD devt2009: 550 devt2009: The system cannot find the file specified.
0
 
LVL 92

Expert Comment

by:objects
ID: 24363302
check your paths are correct and the required directory exists

0
 

Author Comment

by:websyn
ID: 24363321
Path is correct and able to upload from my FTP client but not thru program
0
 
LVL 92

Expert Comment

by:objects
ID: 24363338
same user and relative path?

whats the devt2009 directory it is referring to?

0
 
LVL 92

Expert Comment

by:objects
ID: 24363343
acually thats an absolute path you are using

0
 
LVL 20

Expert Comment

by:ChristoferDutz
ID: 24363344
I think your approach is not going to lead you to the result you want.
I couldn't find any of the FTP protocol communication. All you do, is to connect to a certain host and port and then sent all the data ...

The URLConnection does only the simplest of the simple processing. I doubt it implements the FTP protocol specified here: http://www.ietf.org/rfc/rfc959.txt

Here is a link on best practices regarding Java and FTP. They state your current approach only works in some conditions and is propably going to fail in most cases:
http://www.nsftools.com/tips/JavaFtp.htm
0
 

Author Comment

by:websyn
ID: 24363498
@Objects
for absolute n relative paths getting same err.
0
 

Author Comment

by:websyn
ID: 24370737
Can anyone Please give the working sample
0
 
LVL 92

Accepted Solution

by:
objects earned 500 total points
ID: 24370769
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
by zero exception 10 70
jsp error 6 47
American Express @Work site and Java 4 68
Java Inheritance super keyword use 8 38
Java had always been an easily readable and understandable language.  Some relatively recent changes in the language seem to be changing this pretty fast, and anyone that had not seen any Java code for the last 5 years will possibly have issues undeā€¦
In this post we will learn how to connect and configure Android Device (Smartphone etc.) with Android Studio. After that we will run a simple Hello World Program.
This tutorial will introduce the viewer to VisualVM for the Java platform application. This video explains an example program and covers the Overview, Monitor, and Heap Dump tabs.
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.

726 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question