Solved

SQL QUery issue

Posted on 2009-05-12
5
180 Views
Last Modified: 2012-05-06
I am not sure how i could perform a sub query within a query.

Typically, i am trying to compute the Score for all correct answer and score for all wrong answer and finally calculate the total score.

I put up a SQL but need some guidance. Thanks in advance.
CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
	@EXAM_REFERENCE_CODE nvarchar(50),
	@USER_ID int,
	@REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
	EXAM_REF_CODE,
	USER_ID,
	REQUESTOR_ID,
	SCORE_YES,
	SCORE_NO,
	SCORE_FINAL,
	CREATE_DATE
)
SELECT
 
	@EXAM_REFERENCE_CODE,
	@USER_ID,
	@REQUESTOR_ID, 
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_YES ,
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID <>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_NO,
	SUM(SCORE_YES, SCORE_NO) AS SCORE_TOTAL
	getdate()
 
FROM
	
	EXAMINATION_SCHEDULER_VIEW CESV

Open in new window

0
Comment
Question by:TECH_NET
  • 3
  • 2
5 Comments
 
LVL 8

Expert Comment

by:Bobaran98
ID: 24370932
Okay, I see a few errors in your code, but they're all minor:
  1. Your subqueries need to be enclosed in parentheses (the ending parenthesis before the AS clause).
  2. You can't use SUM() to determine your SCORE_TOTAL... instead, simply add the values together like this:  (SCORE_YES+SCORE_NO) AS SCORE_TOTAL.
  3. You need a comma after SCORE_TOTAL and before getdate().
  4. Not withstanding what I said in point #2, I don't think SCORE_TOTAL will calculate properly as is since it's totaling the values of two other columns from the same select statement... you may need to add another level of subquery to make it work, but that's simple.
In short, I'd rewrite your code as follows:

CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
        EXAM_REF_CODE,
        USER_ID,
        REQUESTOR_ID,
        SCORE_YES,
        SCORE_NO,
        SCORE_FINAL,
        CREATE_DATE
)
SELECT
 
        @EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	TT.SCORE_YES,
	TT.SCORE_NO,
	(TT.SCORE_YES + TT.SCORE_NO) AS SCORE_TOTAL,
	GETDATE()
 
FROM (
 
	SELECT
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_YES,
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_NO
	 
	FROM	
		EXAMINATION_SCHEDULER_VIEW CESV
 
) TT

Open in new window

0
 
LVL 8

Accepted Solution

by:
Bobaran98 earned 500 total points
ID: 24370965
Actually, looking at your code a bit closer, I suddenly realize you're only inserting one record here.  If that's true, I think you might find the following code a bit simpler:

(Mind you I think the following should work, but I'm a bit rusty, I couldn't test it, and I don't currently have access to any of my old stored procedures for comparison.)

:-)


CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
DECLARE @SCORE_YES int,
	@SCORE_NO int,
	@SCORE_FINAL int
 
SET @SCORE_YES = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)
SET @SCORE_NO = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)
SET @SCORE_FINAL = @SCORE_YES + @SCORE_NO
 
INSERT INTO TEST_SCORE_CARD VALUES
(
	@EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	@SCORE_YES,
	@SCORE_NO,
	@SCORE_FINAL,
	GETDATE()
)

Open in new window

0
 

Author Comment

by:TECH_NET
ID: 24371092
I get the following error
 Incorrect syntax near ')'.
0
 

Author Closing Comment

by:TECH_NET
ID: 31580819
The final query was missing a END. (BEGIN END BLOCK). Thanks for everything.

The explaination was simple and easy to follow.
0
 
LVL 8

Expert Comment

by:Bobaran98
ID: 24371166
Great!  Sorry about that END block... trying to go from memory here! :-)
0

Featured Post

Optimizing Cloud Backup for Low Bandwidth

With cloud storage prices going down a growing number of SMBs start to use it for backup storage. Unfortunately, business data volume rarely fits the average Internet speed. This article provides an overview of main Internet speed challenges and reveals backup best practices.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Testing connection to sql 7 63
Sql Permission 6 67
Urgent help needed! Unable to to paste in query designer 29 48
Unable to save view in SSMS 21 73
by Mark Wills Attending one of Rob Farley's seminars the other day, I heard the phrase "The Accidental DBA" and fell in love with it. It got me thinking about the plight of the newcomer to SQL Server...  So if you are the accidental DBA, or, simp…
Data architecture is an important aspect in Software as a Service (SaaS) delivery model. This article is a study on the database of a single-tenant application that could be extended to support multiple tenants. The application is web-based develope…

821 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question