• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 186
  • Last Modified:

SQL QUery issue

I am not sure how i could perform a sub query within a query.

Typically, i am trying to compute the Score for all correct answer and score for all wrong answer and finally calculate the total score.

I put up a SQL but need some guidance. Thanks in advance.
CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
	@EXAM_REFERENCE_CODE nvarchar(50),
	@USER_ID int,
	@REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
	EXAM_REF_CODE,
	USER_ID,
	REQUESTOR_ID,
	SCORE_YES,
	SCORE_NO,
	SCORE_FINAL,
	CREATE_DATE
)
SELECT
 
	@EXAM_REFERENCE_CODE,
	@USER_ID,
	@REQUESTOR_ID, 
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_YES ,
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID <>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_NO,
	SUM(SCORE_YES, SCORE_NO) AS SCORE_TOTAL
	getdate()
 
FROM
	
	EXAMINATION_SCHEDULER_VIEW CESV

Open in new window

0
TECH_NET
Asked:
TECH_NET
  • 3
  • 2
1 Solution
 
Bobaran98Commented:
Okay, I see a few errors in your code, but they're all minor:
  1. Your subqueries need to be enclosed in parentheses (the ending parenthesis before the AS clause).
  2. You can't use SUM() to determine your SCORE_TOTAL... instead, simply add the values together like this:  (SCORE_YES+SCORE_NO) AS SCORE_TOTAL.
  3. You need a comma after SCORE_TOTAL and before getdate().
  4. Not withstanding what I said in point #2, I don't think SCORE_TOTAL will calculate properly as is since it's totaling the values of two other columns from the same select statement... you may need to add another level of subquery to make it work, but that's simple.
In short, I'd rewrite your code as follows:

CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
        EXAM_REF_CODE,
        USER_ID,
        REQUESTOR_ID,
        SCORE_YES,
        SCORE_NO,
        SCORE_FINAL,
        CREATE_DATE
)
SELECT
 
        @EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	TT.SCORE_YES,
	TT.SCORE_NO,
	(TT.SCORE_YES + TT.SCORE_NO) AS SCORE_TOTAL,
	GETDATE()
 
FROM (
 
	SELECT
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_YES,
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_NO
	 
	FROM	
		EXAMINATION_SCHEDULER_VIEW CESV
 
) TT

Open in new window

0
 
Bobaran98Commented:
Actually, looking at your code a bit closer, I suddenly realize you're only inserting one record here.  If that's true, I think you might find the following code a bit simpler:

(Mind you I think the following should work, but I'm a bit rusty, I couldn't test it, and I don't currently have access to any of my old stored procedures for comparison.)

:-)


CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
DECLARE @SCORE_YES int,
	@SCORE_NO int,
	@SCORE_FINAL int
 
SET @SCORE_YES = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)
SET @SCORE_NO = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)
SET @SCORE_FINAL = @SCORE_YES + @SCORE_NO
 
INSERT INTO TEST_SCORE_CARD VALUES
(
	@EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	@SCORE_YES,
	@SCORE_NO,
	@SCORE_FINAL,
	GETDATE()
)

Open in new window

0
 
TECH_NETAuthor Commented:
I get the following error
 Incorrect syntax near ')'.
0
 
TECH_NETAuthor Commented:
The final query was missing a END. (BEGIN END BLOCK). Thanks for everything.

The explaination was simple and easy to follow.
0
 
Bobaran98Commented:
Great!  Sorry about that END block... trying to go from memory here! :-)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: CompTIA Healthcare IT Tech

This course will help prep you to earn the CompTIA Healthcare IT Technician certification showing that you have the knowledge and skills needed to succeed in installing, managing, and troubleshooting IT systems in medical and clinical settings.

  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now