Solved

SQL QUery issue

Posted on 2009-05-12
5
178 Views
Last Modified: 2012-05-06
I am not sure how i could perform a sub query within a query.

Typically, i am trying to compute the Score for all correct answer and score for all wrong answer and finally calculate the total score.

I put up a SQL but need some guidance. Thanks in advance.
CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]

(

	@EXAM_REFERENCE_CODE nvarchar(50),

	@USER_ID int,

	@REQUESTOR_ID int

)

AS
 

BEGIN
 

INSERT INTO TEST_SCORE_CARD

(

	EXAM_REF_CODE,

	USER_ID,

	REQUESTOR_ID,

	SCORE_YES,

	SCORE_NO,

	SCORE_FINAL,

	CREATE_DATE

)

SELECT
 

	@EXAM_REFERENCE_CODE,

	@USER_ID,

	@REQUESTOR_ID, 

	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_YES ,

	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID <>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_NO,

	SUM(SCORE_YES, SCORE_NO) AS SCORE_TOTAL

	getdate()
 

FROM

	

	EXAMINATION_SCHEDULER_VIEW CESV

Open in new window

0
Comment
Question by:TECH_NET
  • 3
  • 2
5 Comments
 
LVL 8

Expert Comment

by:Bobaran98
ID: 24370932
Okay, I see a few errors in your code, but they're all minor:
  1. Your subqueries need to be enclosed in parentheses (the ending parenthesis before the AS clause).
  2. You can't use SUM() to determine your SCORE_TOTAL... instead, simply add the values together like this:  (SCORE_YES+SCORE_NO) AS SCORE_TOTAL.
  3. You need a comma after SCORE_TOTAL and before getdate().
  4. Not withstanding what I said in point #2, I don't think SCORE_TOTAL will calculate properly as is since it's totaling the values of two other columns from the same select statement... you may need to add another level of subquery to make it work, but that's simple.
In short, I'd rewrite your code as follows:

CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]

(

        @EXAM_REFERENCE_CODE nvarchar(50),

        @USER_ID int,

        @REQUESTOR_ID int

)

AS

 

BEGIN

 

INSERT INTO TEST_SCORE_CARD

(

        EXAM_REF_CODE,

        USER_ID,

        REQUESTOR_ID,

        SCORE_YES,

        SCORE_NO,

        SCORE_FINAL,

        CREATE_DATE

)

SELECT

 

        @EXAM_REFERENCE_CODE,

        @USER_ID,

        @REQUESTOR_ID,

	TT.SCORE_YES,

	TT.SCORE_NO,

	(TT.SCORE_YES + TT.SCORE_NO) AS SCORE_TOTAL,

	GETDATE()
 

FROM (
 

	SELECT

		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_YES,

		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_NO

	 

	FROM	

		EXAMINATION_SCHEDULER_VIEW CESV
 

) TT

Open in new window

0
 
LVL 8

Accepted Solution

by:
Bobaran98 earned 500 total points
ID: 24370965
Actually, looking at your code a bit closer, I suddenly realize you're only inserting one record here.  If that's true, I think you might find the following code a bit simpler:

(Mind you I think the following should work, but I'm a bit rusty, I couldn't test it, and I don't currently have access to any of my old stored procedures for comparison.)

:-)



CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]

(

        @EXAM_REFERENCE_CODE nvarchar(50),

        @USER_ID int,

        @REQUESTOR_ID int

)

AS
 

BEGIN
 

DECLARE @SCORE_YES int,

	@SCORE_NO int,

	@SCORE_FINAL int
 

SET @SCORE_YES = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)

SET @SCORE_NO = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)

SET @SCORE_FINAL = @SCORE_YES + @SCORE_NO
 

INSERT INTO TEST_SCORE_CARD VALUES

(

	@EXAM_REFERENCE_CODE,

        @USER_ID,

        @REQUESTOR_ID,

	@SCORE_YES,

	@SCORE_NO,

	@SCORE_FINAL,

	GETDATE()

)

Open in new window

0
 

Author Comment

by:TECH_NET
ID: 24371092
I get the following error
 Incorrect syntax near ')'.
0
 

Author Closing Comment

by:TECH_NET
ID: 31580819
The final query was missing a END. (BEGIN END BLOCK). Thanks for everything.

The explaination was simple and easy to follow.
0
 
LVL 8

Expert Comment

by:Bobaran98
ID: 24371166
Great!  Sorry about that END block... trying to go from memory here! :-)
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
sql calculate reminders 11 69
Incremental load example 2 52
Why do I get extra rows when I do inner join? 12 38
Getting max record but maybe not use Group BY 2 15
This article will describe one method to parse a delimited string into a table of data.   Why would I do that you ask?  Let's say that you need to pass multiple parameters into a stored procedure to search for.  For our sake, we'll say that we wa…
Recently, when I was asked to create a new SQL 2005 cluster, Microsoft released a new service pack for MS SQL 2005 what is Service Pack 3. When I finished the installation of MS SQL 2005 I found myself troubled why the installation of SP3 failed …
This tutorial gives a high-level tour of the interface of Marketo (a marketing automation tool to help businesses track and engage prospective customers and drive them to purchase). You will see the main areas including Marketing Activities, Design …
With the power of JIRA, there's an unlimited number of ways you can customize it, use it and benefit from it. With that in mind, there's bound to be things that I wasn't able to cover in this course. With this summary we'll look at some places to go…

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

23 Experts available now in Live!

Get 1:1 Help Now