Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
?
Solved

SQL QUery issue

Posted on 2009-05-12
5
Medium Priority
?
185 Views
Last Modified: 2012-05-06
I am not sure how i could perform a sub query within a query.

Typically, i am trying to compute the Score for all correct answer and score for all wrong answer and finally calculate the total score.

I put up a SQL but need some guidance. Thanks in advance.
CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
	@EXAM_REFERENCE_CODE nvarchar(50),
	@USER_ID int,
	@REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
	EXAM_REF_CODE,
	USER_ID,
	REQUESTOR_ID,
	SCORE_YES,
	SCORE_NO,
	SCORE_FINAL,
	CREATE_DATE
)
SELECT
 
	@EXAM_REFERENCE_CODE,
	@USER_ID,
	@REQUESTOR_ID, 
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_YES ,
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID <>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_NO,
	SUM(SCORE_YES, SCORE_NO) AS SCORE_TOTAL
	getdate()
 
FROM
	
	EXAMINATION_SCHEDULER_VIEW CESV

Open in new window

0
Comment
Question by:TECH_NET
  • 3
  • 2
5 Comments
 
LVL 8

Expert Comment

by:Bobaran98
ID: 24370932
Okay, I see a few errors in your code, but they're all minor:
  1. Your subqueries need to be enclosed in parentheses (the ending parenthesis before the AS clause).
  2. You can't use SUM() to determine your SCORE_TOTAL... instead, simply add the values together like this:  (SCORE_YES+SCORE_NO) AS SCORE_TOTAL.
  3. You need a comma after SCORE_TOTAL and before getdate().
  4. Not withstanding what I said in point #2, I don't think SCORE_TOTAL will calculate properly as is since it's totaling the values of two other columns from the same select statement... you may need to add another level of subquery to make it work, but that's simple.
In short, I'd rewrite your code as follows:

CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
        EXAM_REF_CODE,
        USER_ID,
        REQUESTOR_ID,
        SCORE_YES,
        SCORE_NO,
        SCORE_FINAL,
        CREATE_DATE
)
SELECT
 
        @EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	TT.SCORE_YES,
	TT.SCORE_NO,
	(TT.SCORE_YES + TT.SCORE_NO) AS SCORE_TOTAL,
	GETDATE()
 
FROM (
 
	SELECT
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_YES,
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_NO
	 
	FROM	
		EXAMINATION_SCHEDULER_VIEW CESV
 
) TT

Open in new window

0
 
LVL 8

Accepted Solution

by:
Bobaran98 earned 2000 total points
ID: 24370965
Actually, looking at your code a bit closer, I suddenly realize you're only inserting one record here.  If that's true, I think you might find the following code a bit simpler:

(Mind you I think the following should work, but I'm a bit rusty, I couldn't test it, and I don't currently have access to any of my old stored procedures for comparison.)

:-)


CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
DECLARE @SCORE_YES int,
	@SCORE_NO int,
	@SCORE_FINAL int
 
SET @SCORE_YES = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)
SET @SCORE_NO = (SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE)
SET @SCORE_FINAL = @SCORE_YES + @SCORE_NO
 
INSERT INTO TEST_SCORE_CARD VALUES
(
	@EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	@SCORE_YES,
	@SCORE_NO,
	@SCORE_FINAL,
	GETDATE()
)

Open in new window

0
 

Author Comment

by:TECH_NET
ID: 24371092
I get the following error
 Incorrect syntax near ')'.
0
 

Author Closing Comment

by:TECH_NET
ID: 31580819
The final query was missing a END. (BEGIN END BLOCK). Thanks for everything.

The explaination was simple and easy to follow.
0
 
LVL 8

Expert Comment

by:Bobaran98
ID: 24371166
Great!  Sorry about that END block... trying to go from memory here! :-)
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In this article I will describe the Copy Database Wizard method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
In this article we will get to know that how can we recover deleted data if it happens accidently. We really can recover deleted rows if we know the time when data is deleted by using the transaction log.
When cloud platforms entered the scene, users and companies jumped on board to take advantage of the many benefits, like the ability to work and connect with company information from various locations. What many didn't foresee was the increased risk…
How can you see what you are working on when you want to see it while you to save a copy? Add a "Save As" icon to the Quick Access Toolbar, or QAT. That way, when you save a copy of a query, form, report, or other object you are modifying, you…

571 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question