asked on

SQL QUery issue

I am not sure how i could perform a sub query within a query.

Typically, i am trying to compute the Score for all correct answer and score for all wrong answer and finally calculate the total score.

I put up a SQL but need some guidance. Thanks in advance.

CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
	@EXAM_REFERENCE_CODE nvarchar(50),
	@USER_ID int,
	@REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
	EXAM_REF_CODE,
	USER_ID,
	REQUESTOR_ID,
	SCORE_YES,
	SCORE_NO,
	SCORE_FINAL,
	CREATE_DATE
)
SELECT
 
	@EXAM_REFERENCE_CODE,
	@USER_ID,
	@REQUESTOR_ID, 
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_YES ,
	SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID <>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE AS SCORE_NO,
	SUM(SCORE_YES, SCORE_NO) AS SCORE_TOTAL
	getdate()
 
FROM
	
	EXAMINATION_SCHEDULER_VIEW CESV

Open in new window

Bobaran98

Okay, I see a few errors in your code, but they're all minor:

Your subqueries need to be enclosed in parentheses (the ending parenthesis before the AS clause).
You can't use SUM() to determine your SCORE_TOTAL... instead, simply add the values together like this: (SCORE_YES+SCORE_NO) AS SCORE_TOTAL.
You need a comma after SCORE_TOTAL and before getdate().
Not withstanding what I said in point #2, I don't think SCORE_TOTAL will calculate properly as is since it's totaling the values of two other columns from the same select statement... you may need to add another level of subquery to make it work, but that's simple.

In short, I'd rewrite your code as follows:

CREATE PROCEDURE [dbo].[ExamMode_PostTestScores]
(
        @EXAM_REFERENCE_CODE nvarchar(50),
        @USER_ID int,
        @REQUESTOR_ID int
)
AS
 
BEGIN
 
INSERT INTO TEST_SCORE_CARD
(
        EXAM_REF_CODE,
        USER_ID,
        REQUESTOR_ID,
        SCORE_YES,
        SCORE_NO,
        SCORE_FINAL,
        CREATE_DATE
)
SELECT
 
        @EXAM_REFERENCE_CODE,
        @USER_ID,
        @REQUESTOR_ID,
	TT.SCORE_YES,
	TT.SCORE_NO,
	(TT.SCORE_YES + TT.SCORE_NO) AS SCORE_TOTAL,
	GETDATE()
 
FROM (
 
	SELECT
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID=QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_YES,
		(SELECT SUM(MARK_ALLOCATED) FROM CESV WHERE CORRECT_ANSWER_ID<>QUESTION_RESPONSE_ID AND EXAM_REFERENCE_CODE=@EXAM_REFERENCE_CODE) AS SCORE_NO
	 
	FROM	
		EXAMINATION_SCHEDULER_VIEW CESV
 
) TT

Open in new window

ASKER CERTIFIED SOLUTION

Bobaran98

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

TECH_NET

ASKER

I get the following error
Incorrect syntax near ')'.

TECH_NET

ASKER

The final query was missing a END. (BEGIN END BLOCK). Thanks for everything.

The explaination was simple and easy to follow.

Bobaran98

Great! Sorry about that END block... trying to go from memory here! :-)