Solved

How to insert multiple records from a select query result?

Posted on 2009-05-12
2
186 Views
Last Modified: 2012-05-06
There are 30 exchanges reference rates each day needs to carry down to next day. I use the following SQL to select the yesterday's result and hope to insert them to the same table but with different date.

However, it just insert the last record of previous day.

How should I write the SP?


ALTER PROCEDURE [dbo].[SP_Update_Exchanges] 
@fordate datetime
AS
BEGIN
BEGIN TRAN TRAN_SP_Ex
Declare @currencyid int
Declare @currency nvarchar(50)
Declare @referencerate decimal(18,6)
Declare @buy decimal(18,6)
Declare @sell decimal(18,6)
 
SET NOCOUNT ON;
select * from exchanges where systemdate = @fordate
if @@rowcount <> 1
      begin
            SELECT @currencyid=currencyid, @currency=currency, 
            @referencerate=referencerate, @buy=buy, @sell=sell from exchanges 
            where systemdate = datediff(day,1,@fordate)
 
            insert into exchanges (currencyid,currency,referencerate,buy,sell,systemdate) 
            values (@currencyid,@currency,@referencerate,@buy,@sell,@fordate)
      end
IF @@ERROR <> 0
	ROLLBACK TRAN TRAN_SP_Ex
ELSE
	COMMIT TRAN TRAN_SP_Ex
END

Open in new window

0
Comment
Question by:techques
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
2 Comments
 
LVL 39

Accepted Solution

by:
Pratima Pharande earned 50 total points
ID: 24371552
Try this
ALTER PROCEDURE [dbo].[SP_Update_Exchanges] 
@fordate datetime
AS
BEGIN
BEGIN TRAN TRAN_SP_Ex
 
 
SET NOCOUNT ON;
                 insert into exchanges (currencyid,currency,referencerate,buy,sell,systemdate) 
             SELECT currencyid, currency, 
            referencerate, buy, sell,@fordate from exchanges 
            where systemdate = datediff(day,1,@fordate)
    
IF @@ERROR <> 0
	ROLLBACK TRAN TRAN_SP_Ex
ELSE
	COMMIT TRAN TRAN_SP_Ex
END

Open in new window

0
 
LVL 31

Expert Comment

by:RiteshShah
ID: 24371739
this should work for you...



ALTER PROCEDURE [dbo].[SP_Update_Exchanges] 
@fordate datetime
AS
BEGIN
BEGIN TRAN TRAN_SP_Ex
 
 
SET NOCOUNT ON;
                 insert into exchanges (currencyid,currency,referencerate,buy,sell,systemdate) 
             SELECT currencyid, currency, 
            referencerate, buy, sell,@fordate from exchanges 
            where systemdate = dateadd(dd,-1,@fordate)
    
IF @@ERROR <> 0
        ROLLBACK TRAN TRAN_SP_Ex
ELSE
        COMMIT TRAN TRAN_SP_Ex
END

Open in new window

0

Featured Post

Guide to Performance: Optimization & Monitoring

Nowadays, monitoring is a mixture of tools, systems, and codes—making it a very complex process. And with this complexity, comes variables for failure. Get DZone’s new Guide to Performance to learn how to proactively find these variables and solve them before a disruption occurs.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Why is the output of this function is like this? 4 47
CROSS APPLY 4 69
Help  needed 3 52
Replication failure 1 31
I've encountered valid database schemas that do not have a primary key.  For example, I use LogParser from Microsoft to push IIS logs into a SQL database table for processing and analysis.  However, occasionally due to user error or a scheduled task…
Introduction: When running hybrid database environments, you often need to query some data from a remote db of any type, while being connected to your MS SQL Server database. Problems start when you try to combine that with some "user input" pass…
Nobody understands Phishing better than an anti-spam company. That’s why we are providing Phishing Awareness Training to our customers. According to a report by Verizon, only 3% of targeted users report malicious emails to management. With compan…

734 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question