Solved

ConcurrentModificationException while using addAll method

Posted on 2009-05-13
13
370 Views
Last Modified: 2012-05-06
                 these loop will read the values from the form and put it in requestList.
                  
                  for (int i = 1; i <= 1; i++) {
                         cdtls= new ContainerDetails();
                         cdtls.setContainerType(request.getParameter("ContainerType_"+i+"_1"));
                         cdtls.setContainerNumber(request.getParameter("ContainerNumber_"+i+"_2"));
                         cdtls.setContainerDesc(request.getParameter("ContainerDescription_"+i+"_3"));
                         AL.add(cdtls);
                  }

                         ArrayList requestList=al;

                        //this list will give me first 10 records for the particular booking id;

                         ArrayList dataBaseList =DAO.getDBDetails(bookingId);

                  
                  ArrayList addList= new ArrayList();
                  addList.add("10");

                  // compared the addList number versus the dataBaseList ContainerDetails object id, if both r
                  same then first i need to remove that id from dataBaseList and then add requestList to dataBaseList.
                  i am getting java.util.ConcurrentModificationException while doing addAll method.
                  whats wrong with this code?

                  if(addList != null && !addList.get(0).equals("") && addList.size() > 0)
                        {
                              for (Iterator iterator = addList.iterator(); iterator.hasNext();) {
                                    String addId = (String) iterator.next();
                                    
                                    for (Iterator iterator2 = dataBaseList.iterator(); iterator2
                                                .hasNext();) {
                                          ContainerDetails object = (ContainerDetails) iterator2.next();
                                    
                                          if(object.getId() == Integer.parseInt(addId))
                                          {
                                                iterator2.remove();
                                                dataBaseList.addAll(al);
            
                                          }

                              }
                           }
                        }
0
Comment
Question by:chaitu chaitu
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 4
  • 2
  • +2
13 Comments
 
LVL 12

Expert Comment

by:Gibu George
ID: 24375143
Are you using Threads in the application
0
 
LVL 20

Author Comment

by:chaitu chaitu
ID: 24375159
no
0
 
LVL 12

Expert Comment

by:Gibu George
ID: 24375191
What type of application is this is it a web application?
0
Transaction Monitoring Vs. Real User Monitoring

Synthetic Transaction Monitoring Vs. Real User Monitoring: When To Use Each Approach? In this article, we will discuss two major monitoring approaches: Synthetic Transaction and Real User Monitoring.

 
LVL 20

Author Comment

by:chaitu chaitu
ID: 24375220
yes
0
 
LVL 86

Expert Comment

by:CEHJ
ID: 24375407
The first loop will only execute once, is that your intention?
0
 
LVL 86

Accepted Solution

by:
CEHJ earned 500 total points
ID: 24375506
You can't addAll to dataBaseList while you're iterating it. Try instead:
        if(addList != null && !addList.get(0).equals("") && addList.size() > 0)
        {
            List temp = new ArrayList();
            for (Iterator iterator = addList.iterator(); iterator.hasNext();) {
                String addId = (String) iterator.next();
 
                for (Iterator iterator2 = dataBaseList.iterator(); iterator2
                        .hasNext();) {
                    ContainerDetails object = (ContainerDetails) iterator2.next();
 
                    if(object.getId() == Integer.parseInt(addId))
                    {   
                        iterator2.remove();
                        //dataBaseList.addAll(al);
                        temp.addAll(al);
 
                    }
 
                }   
            }   
            if (temp.size() > 0)
            {
                dataBaseList.addAll(temp);
            }
        }

Open in new window

0
 
LVL 92

Expert Comment

by:objects
ID: 24380229
why not use a Map (keyed on id), that way you would not even need to loop at all.
using the appropriate data structure can greatly simplify your code

0
 
LVL 5

Expert Comment

by:avya2k
ID: 24381903
As per specifications, you can not modify contents while iterating a collection
Instead collect all contents in temparory list and add it to main list after iteration
0
 
LVL 20

Author Comment

by:chaitu chaitu
ID: 24382038
objects,

can you give me some hint what you are trying to tell?
0
 
LVL 92

Expert Comment

by:objects
ID: 24382046
for example if you had a map keyed on id you would not need to loop through every element looking for a particular id.

0
 
LVL 86

Expert Comment

by:CEHJ
ID: 24383323
>>Instead collect all contents in temparory list and add it to main list after iteration

(which is what happens in the code i posted)

chaituu, what result do you get when you run that?
0
 
LVL 20

Author Comment

by:chaitu chaitu
ID: 24392159
CEHJ,

ur solution is working.i thought i am doing some unwanted code thats why i am taking objects suggestion.
0
 
LVL 86

Expert Comment

by:CEHJ
ID: 24412017
:-)
0

Featured Post

Enroll in June's Course of the Month

June’s Course of the Month is now available! Experts Exchange’s Premium Members, Team Accounts, and Qualified Experts have access to a complimentary course each month as part of their membership—an extra way to sharpen your skills and increase training.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This was posted to the Netbeans forum a Feb, 2010 and I also sent it to Verisign. Who didn't help much in my struggles to get my application signed. ------------------------- Start The idea here is to target your cell phones with the correct…
Introduction Java can be integrated with native programs using an interface called JNI(Java Native Interface). Native programs are programs which can directly run on the processor. JNI is simply a naming and calling convention so that the JVM (Java…
Viewers learn about the “for” loop and how it works in Java. By comparing it to the while loop learned before, viewers can make the transition easily. You will learn about the formatting of the for loop as we write a program that prints even numbers…
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.

717 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question