Sql statment correct?

I get an error on this:
"UPDATE t_account SET blance = @summa WHERE accountid = @id"

There isnt any value for one or more parameters is the error


string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";
            
            OleDbConnection cn = new OleDbConnection(myConnectionString);
            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))
            {
 
                cmd.Parameters.Add("@id", OleDbType.Integer).Value = id;
                cmd.Parameters.Add("@summa", OleDbType.Integer).Value = summa;           
 
                cn.Open();
                cmd.ExecuteNonQuery();
                cn.Close();
            }

Open in new window

MickeysAsked:
Who is Participating?
 
abelCommented:
So not go for the SQL string concatenation proposed in the first answer, that will make you liable for SQL injection attacks. You should stay with the Parameter approach at all times (or further abstractions like ORMs offer)

You are using the @-sign in the Parameters.Add. You should remove it:

string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";
            
OleDbConnection cn = new OleDbConnection(myConnectionString);
using (OleDbCommand cmd = new OleDbCommand(sql2, cn))
{ 
    cmd.Parameters.Add("id", OleDbType.Integer).Value = id;
    cmd.Parameters.Add("summa", OleDbType.Integer).Value = summa;           
    cn.Open();
    cmd.ExecuteNonQuery();
    cn.Close();
}

Open in new window

0
 
Pratima PharandeCommented:
try this
 string sql2 = "UPDATE t_account SET blance =" + summa + "WHERE accountid =" + id;
 
            OleDbConnection cn = new OleDbConnection(myConnectionString);
            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))
            {
                 cn.Open();
                cmd.ExecuteNonQuery();
                cn.Close();
            }

Open in new window

0
 
abelCommented:
So == Do (first word)
0
Ultimate Tool Kit for Technology Solution Provider

Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.

 
MickeysAuthor Commented:
I havent tried pratima_mcs: suggesstion since that is the incorrect way to go.

Abel: That dindt help. Same error
0
 
Pratima PharandeCommented:
try this

I think you missed
cmd.CommandType = CommandType.Text;
string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";
            
            OleDbConnection cn = new OleDbConnection(myConnectionString);
            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))
            {
 cmd.CommandType = CommandType.Text; 
                cmd.Parameters.Add("@id", OleDbType.Integer).Value = id;
                cmd.Parameters.Add("@summa", OleDbType.Integer).Value = summa;           
 
                cn.Open();
                cmd.ExecuteNonQuery();
                cn.Close();
            }

Open in new window

0
 
MickeysAuthor Commented:
no Same error. :-/

There are more columns in the table but I dont need to have them in the sql statment when I am just gonna update one of the columns, right?
0
 
MickeysAuthor Commented:
Here are the database. It is t_account.

database.bmp
0
 
Anurag ThakurTechnical ManagerCommented:
try this one
http://www.java2s.com/Code/ASP/ADO.net-Database/UsedirectSQLtoinsertC.htm
            string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";
            
            OleDbConnection cn = new OleDbConnection(myConnectionString);
            cn.Open();
            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))
            {
                cmd.CommandType = CommandType.Text; 
                cmd.Parameters.Add("@id", OleDbType.Integer).Value = id;
                cmd.Parameters.Add("@summa", OleDbType.Integer).Value = summa;
                cmd.ExecuteNonQuery();
                cn.Close();
            }

Open in new window

0
 
Pratima PharandeCommented:
yes ..correct
0
 
MickeysAuthor Commented:
sorry same error. I have used exactly that code for SELECT and INSERT and that works.
0
 
abelCommented:
Think that by now it is time to see what is generated, actually. There is a mismatch between a sql parameter and the name you give it. In the code that you show, it isn't there. Is it possible that the actual query is larger?

Can you apply a Trace on the SQL server to see what the actual code is that is sent to the server and paste that here?
0
 
MickeysAuthor Commented:
and the error is found. wrong spelling on the column name balance
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.