Solved

Sql statment correct?

Posted on 2009-05-15
12
235 Views
Last Modified: 2012-05-07
I get an error on this:
"UPDATE t_account SET blance = @summa WHERE accountid = @id"

There isnt any value for one or more parameters is the error


string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";

            

            OleDbConnection cn = new OleDbConnection(myConnectionString);

            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))

            {
 

                cmd.Parameters.Add("@id", OleDbType.Integer).Value = id;

                cmd.Parameters.Add("@summa", OleDbType.Integer).Value = summa;           
 

                cn.Open();

                cmd.ExecuteNonQuery();

                cn.Close();

            }

Open in new window

0
Comment
Question by:Mickeys
  • 5
  • 3
  • 3
  • +1
12 Comments
 
LVL 39

Assisted Solution

by:Pratima Pharande
Pratima Pharande earned 100 total points
ID: 24394573
try this
 string sql2 = "UPDATE t_account SET blance =" + summa + "WHERE accountid =" + id;
 

            OleDbConnection cn = new OleDbConnection(myConnectionString);

            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))

            {

                 cn.Open();

                cmd.ExecuteNonQuery();

                cn.Close();

            }

Open in new window

0
 
LVL 39

Accepted Solution

by:
abel earned 200 total points
ID: 24394643
So not go for the SQL string concatenation proposed in the first answer, that will make you liable for SQL injection attacks. You should stay with the Parameter approach at all times (or further abstractions like ORMs offer)

You are using the @-sign in the Parameters.Add. You should remove it:

string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";

            

OleDbConnection cn = new OleDbConnection(myConnectionString);

using (OleDbCommand cmd = new OleDbCommand(sql2, cn))

{ 

    cmd.Parameters.Add("id", OleDbType.Integer).Value = id;

    cmd.Parameters.Add("summa", OleDbType.Integer).Value = summa;           

    cn.Open();

    cmd.ExecuteNonQuery();

    cn.Close();

}

Open in new window

0
 
LVL 39

Expert Comment

by:abel
ID: 24394651
So == Do (first word)
0
 

Author Comment

by:Mickeys
ID: 24394965
I havent tried pratima_mcs: suggesstion since that is the incorrect way to go.

Abel: That dindt help. Same error
0
 
LVL 39

Expert Comment

by:Pratima Pharande
ID: 24395003
try this

I think you missed
cmd.CommandType = CommandType.Text;
string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";

            

            OleDbConnection cn = new OleDbConnection(myConnectionString);

            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))

            {

 cmd.CommandType = CommandType.Text; 

                cmd.Parameters.Add("@id", OleDbType.Integer).Value = id;

                cmd.Parameters.Add("@summa", OleDbType.Integer).Value = summa;           

 

                cn.Open();

                cmd.ExecuteNonQuery();

                cn.Close();

            }

Open in new window

0
 

Author Comment

by:Mickeys
ID: 24395118
no Same error. :-/

There are more columns in the table but I dont need to have them in the sql statment when I am just gonna update one of the columns, right?
0
U.S. Department of Agriculture and Acronis Access

With the new era of mobile computing, smartphones and tablets, wireless communications and cloud services, the USDA sought to take advantage of a mobilized workforce and the blurring lines between personal and corporate computing resources.

 

Author Comment

by:Mickeys
ID: 24395131
Here are the database. It is t_account.

database.bmp
0
 
LVL 26

Assisted Solution

by:Anurag Thakur
Anurag Thakur earned 200 total points
ID: 24395148
try this one
http://www.java2s.com/Code/ASP/ADO.net-Database/UsedirectSQLtoinsertC.htm
            string sql2 = "UPDATE t_account SET blance = @summa WHERE accountid = @id";

            

            OleDbConnection cn = new OleDbConnection(myConnectionString);

            cn.Open();

            using (OleDbCommand cmd = new OleDbCommand(sql2, cn))

            {

                cmd.CommandType = CommandType.Text; 

                cmd.Parameters.Add("@id", OleDbType.Integer).Value = id;

                cmd.Parameters.Add("@summa", OleDbType.Integer).Value = summa;

                cmd.ExecuteNonQuery();

                cn.Close();

            }

Open in new window

0
 
LVL 39

Expert Comment

by:Pratima Pharande
ID: 24395168
yes ..correct
0
 

Author Comment

by:Mickeys
ID: 24395418
sorry same error. I have used exactly that code for SELECT and INSERT and that works.
0
 
LVL 39

Expert Comment

by:abel
ID: 24396240
Think that by now it is time to see what is generated, actually. There is a mismatch between a sql parameter and the name you give it. In the code that you show, it isn't there. Is it possible that the actual query is larger?

Can you apply a Trace on the SQL server to see what the actual code is that is sent to the server and paste that here?
0
 

Author Closing Comment

by:Mickeys
ID: 31581882
and the error is found. wrong spelling on the column name balance
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I'm trying, I really am. But I've seen so many wrong approaches involving date(time) boundaries I despair about my inability to explain it. I've seen quite a few recently that define a non-leap year as 364 days, or 366 days and the list goes on. …
This article describes how to use the timestamp of existing data in a database to allow Tableau to calculate the prior work day instead of relying on case statements or if statements to calculate the days of the week.
As developers, we are not limited to the functions provided by the VBA language. In addition, we can call the functions that are part of the Windows operating system. These functions are part of the Windows API (Application Programming Interface). U…
With Microsoft Access, learn how to specify relationships between tables and set various options on the relationship. Add the tables: Create the relationship: Decide if you’re going to set referential integrity: Decide if you want cascade upda…

919 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now