Solved

passing function to a function?

Posted on 2009-05-15
9
285 Views
Last Modified: 2012-05-07
Hello, I am trying to pass a function to a function in PHP, but it seems that only the function that is being passed works.

The Value of woo_get_custom_banner('bannerIDside') is 10 and the only thing that shows up on the page is 10 but what SHOULD be showing up is a banner!

if I use
mba_display_banner(10);
the function works perfectly.

any ideas??
<div id="rightbanner">
<?php mba_display_banner(woo_get_custom_banner('bannerIDside')); ?>
</div>

Open in new window

0
Comment
Question by:b1xx1b
  • 5
  • 4
9 Comments
 
LVL 9

Expert Comment

by:wellhole
ID: 24398945
What does mba_display_banner(10) do for you? If it does the same thing as what you posted above, then your problem lies in mba_display_banner.
0
 

Author Comment

by:b1xx1b
ID: 24398951
if I use
mba_display_banner(10);
the function works perfectly and correctly displays the banner (with banner_id = 10)
0
 
LVL 9

Expert Comment

by:wellhole
ID: 24398959
Oops.. didn't read the whole thing. Are you absolutely sure woo_get_custom_banner is working correctly?
0
ScreenConnect 6.0 Free Trial

Discover new time-saving features in one game-changing release, ScreenConnect 6.0, based on partner feedback. New features include a redesigned UI, app configurations and chat acknowledgement to improve customer engagement!

 

Author Comment

by:b1xx1b
ID: 24398968
( i edited the post AFTER you commented ... you didn't miss it :))
yes, I am positive the function works perfectly.
0
 
LVL 9

Expert Comment

by:wellhole
ID: 24398977
Would you mind sharing both functions?
0
 

Author Comment

by:b1xx1b
ID: 24398995
sure here they are:

function mba_display_banner(&$banner_id) {
      global $MBPBannerAdsPlugin;
      global $banner_id;
      if ( !is_admin() ) {
            if ( intval($banner_id) > 0 ) {
                  $banner_filter = "id='$banner_id'";
            } else {
                  $banner_filter = "name='$banner_id'";
            }
            $sql = "SELECT id,url,link,in_new_win,ad_type,text_ad_code FROM $MBPBannerAdsPlugin->mban_banner_table WHERE status='1' AND {$banner_filter}";
            $rs  = mysql_query($sql);
            $id   = array();
            $url  = array();
            $link = array();
            $in_new_win = array();
            $text_ad_code = array();
            $zone_properties = array();
            while ( $data = @mysql_fetch_assoc($rs) ) {
                  $cnt++;
                  if ( $data['ad_type'] == 1 ) {
                        $id[] = $data['id'];
                        $text_ad_code[] = $data['text_ad_code'];
                  } else {
                        $id[]   = $data['id'];
                        $url[]  = $data['url'];
                        $link[] = $data['link'];
                        $in_new_win[] = $data['in_new_win'];
                  }
            }
            if ( count($id) > 0 ) {
                  $banner_output = $MBPBannerAdsPlugin->__mbanGetBanner($id,$url,$link,$in_new_win,$zone_properties,$text_ad_code);
                  echo $banner_output;
                  //echo $sql;
            }
      }
}



function woo_get_custom_banner($key) {

global $post;
$custom_field = get_post_meta($post->ID, $key, true);
if ($custom_field) {
      $custom_field = stripslashes($custom_field);
?>
<?php echo $custom_field; ?>
<?php
}
else { //else, return
      return;
}
}
0
 
LVL 9

Accepted Solution

by:
wellhole earned 500 total points
ID: 24399006
Well theres your problem. woo_get_customer_banner is ECHOING the result instead of returning it.
0
 

Author Comment

by:b1xx1b
ID: 24399007
Note:  I have used the function like this:
function mba_display_banner(&$banner_id)
and with the & like this
function mba_display_banner($banner_id)

and still does not work correctly.
0
 

Author Comment

by:b1xx1b
ID: 24399053
Thanks!  That did the trick.  duh.
0

Featured Post

Windows Server 2016: All you need to know

Learn about Hyper-V features that increase functionality and usability of Microsoft Windows Server 2016. Also, throughout this eBook, you’ll find some basic PowerShell examples that will help you leverage the scripts in your environments!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Author Note: Since this E-E article was originally written, years ago, formal testing has come into common use in the world of PHP.  PHPUnit (http://en.wikipedia.org/wiki/PHPUnit) and similar technologies have enjoyed wide adoption, making it possib…
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
The viewer will learn how to count occurrences of each item in an array.
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.

778 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question