?
Solved

Order By in Union

Posted on 2009-05-18
7
Medium Priority
?
182 Views
Last Modified: 2012-05-07
I want to add a Order By "O.CreatedOn Desc" to this SQL stored procedure but I keep getting this error:

The ORDER BY clause is invalid in views, inline functions, derived tables, subqueries, and common table expressions, unless TOP or FOR XML is also specified.

--How can I do this??
select   'Pending',count(*)
from
(
SELECT  
  
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2
      And O.SiteID = @SiteID
 
GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 
) a
 
Union
select  ',10',count(*)
from
(
SELECT
  
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2 and O.[Score] < 10
       And O.SiteID = @SiteID
 
GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 
) a

Open in new window

0
Comment
Question by:Camillia
  • 4
  • 2
7 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 2000 total points
ID: 24417100
can you explain why you need an order by in your query?
because, all it does in the end is to return 2 rows for the 2 counts ...
0
 
LVL 43

Expert Comment

by:pcelba
ID: 24417138
Union ALL could help
select   'Pending',count(*)
from
(
SELECT   
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2
      And O.SiteID = @SiteID
 GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 ORDER BY O.CreatedOn Desc
) a 
Union All
select  ',10',count(*)
from
(
SELECT
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2 and O.[Score] < 10
       And O.SiteID = @SiteID
 GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 ORDER BY O.CreatedOn Desc
) b

Open in new window

0
 
LVL 43

Expert Comment

by:pcelba
ID: 24417147
Of course, the union in above select does not make sense.
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
LVL 43

Expert Comment

by:pcelba
ID: 24417151
Not UNION but ORDER BY does not make sense, of course. Sorry.
0
 
LVL 7

Author Comment

by:Camillia
ID: 24417279
I want to bring back rows by order of date. Oldest date first. Why doesnt it make sense??
Let me try the UNion ALL and see. Maybe it doesnt make sense but let me see..
0
 
LVL 7

Author Comment

by:Camillia
ID: 24417287
I think you're right. I posted a wrong statement. Let me post back.
0
 
LVL 43

Expert Comment

by:pcelba
ID: 24417460
Now I understand.
0

Featured Post

Prepare for your VMware VCP6-DCV exam.

Josh Coen and Jason Langer have prepared the latest edition of VCP study guide. Both authors have been working in the IT field for more than a decade, and both hold VMware certifications. This 163-page guide covers all 10 of the exam blueprint sections.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

by Mark Wills Attending one of Rob Farley's seminars the other day, I heard the phrase "The Accidental DBA" and fell in love with it. It got me thinking about the plight of the newcomer to SQL Server...  So if you are the accidental DBA, or, simp…
In this article I will describe the Copy Database Wizard method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
Is your data getting by on basic protection measures? In today’s climate of debilitating malware and ransomware—like WannaCry—that may not be enough. You need to establish more than basics, like a recovery plan that protects both data and endpoints.…
Screencast - Getting to Know the Pipeline

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question