Solved

Order By in Union

Posted on 2009-05-18
7
176 Views
Last Modified: 2012-05-07
I want to add a Order By "O.CreatedOn Desc" to this SQL stored procedure but I keep getting this error:

The ORDER BY clause is invalid in views, inline functions, derived tables, subqueries, and common table expressions, unless TOP or FOR XML is also specified.

--How can I do this??
select   'Pending',count(*)
from
(
SELECT  
  
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2
      And O.SiteID = @SiteID
 
GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 
) a
 
Union
select  ',10',count(*)
from
(
SELECT
  
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2 and O.[Score] < 10
       And O.SiteID = @SiteID
 
GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 
) a

Open in new window

0
Comment
Question by:Camillia
  • 4
  • 2
7 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 24417100
can you explain why you need an order by in your query?
because, all it does in the end is to return 2 rows for the 2 counts ...
0
 
LVL 42

Expert Comment

by:pcelba
ID: 24417138
Union ALL could help
select   'Pending',count(*)
from
(
SELECT   
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2
      And O.SiteID = @SiteID
 GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 ORDER BY O.CreatedOn Desc
) a 
Union All
select  ',10',count(*)
from
(
SELECT
O.[Id] AS [Id],
O.[CreatedOn] AS [CreatedOn],
O.[Number] AS [Number],
O.[CustomerName] AS [CustomerName],
O.[BillingPhoneNumber] AS [BillingPhoneNumber], 
O.[Status] AS [Status],  
COALESCE(OHST.[Name], OHS.[Name]) AS [HoldStatus], 
O.[Score] AS [Score], 
SUM(CASE WHEN OI.[Status] = 1 THEN 0 
         ELSE OI.[ItemPrice] - OI.[DiscountAmount] END) 
        - MAX(O.[OrderDiscountAmount]) +  MAX(O.[TaxAmount]) + MAX(O.[ShippingPrice] - O.[ShippingDiscountAmount]) 
        AS [GrandTotal], 
isnull(Uc.[UserName],'') AS [CreatedBy]  
FROM [ORDOrder] O WITH (NOLOCK) 
    LEFT OUTER JOIN [aspnet_Users] Uc WITH (NOLOCK) ON Uc.[UserId] = O.[CreatedBy]  
    INNER JOIN [ORDOrderItem] OI WITH (NOLOCK) ON OI.[OrderId] = O.[Id] 
    LEFT OUTER JOIN [ORDOrderHoldStatus] OHS WITH (NOLOCK) ON OHS.[Id] = O.[HoldStatusId] 
    LEFT OUTER JOIN [ORDOrderHoldStatusText] OHST WITH (NOLOCK) ON OHST.[Id] = OHS.[Id] AND OHST.[LocaleId] = 1033 
WHERE O.[Status] = 2 and O.[Score] < 10
       And O.SiteID = @SiteID
 GROUP BY COALESCE(OHST.[Name], OHS.[Name]),
         O.[BillingPhoneNumber], 
         O.[CreatedOn], 
         O.[CustomerName], 
         O.[Id], 
         O.[Number], 
         O.[Score], 
         O.[Status], 
         Uc.[UserName] 
 ORDER BY O.CreatedOn Desc
) b

Open in new window

0
 
LVL 42

Expert Comment

by:pcelba
ID: 24417147
Of course, the union in above select does not make sense.
0
Ransomware-A Revenue Bonanza for Service Providers

Ransomware – malware that gets on your customers’ computers, encrypts their data, and extorts a hefty ransom for the decryption keys – is a surging new threat.  The purpose of this eBook is to educate the reader about ransomware attacks.

 
LVL 42

Expert Comment

by:pcelba
ID: 24417151
Not UNION but ORDER BY does not make sense, of course. Sorry.
0
 
LVL 7

Author Comment

by:Camillia
ID: 24417279
I want to bring back rows by order of date. Oldest date first. Why doesnt it make sense??
Let me try the UNion ALL and see. Maybe it doesnt make sense but let me see..
0
 
LVL 7

Author Comment

by:Camillia
ID: 24417287
I think you're right. I posted a wrong statement. Let me post back.
0
 
LVL 42

Expert Comment

by:pcelba
ID: 24417460
Now I understand.
0

Featured Post

Windows Server 2016: All you need to know

Learn about Hyper-V features that increase functionality and usability of Microsoft Windows Server 2016. Also, throughout this eBook, you’ll find some basic PowerShell examples that will help you leverage the scripts in your environments!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction This article will provide a solution for an error that might occur installing a new SQL 2005 64-bit cluster. This article will assume that you are fully prepared to complete the installation and describes the error as it occurred durin…
So every once in a while at work I am asked to export data from one table and insert it into another on a different server.  I hate doing this.  There's so many different tables and data types.  Some column data needs quoted and some doesn't.  What …
Nobody understands Phishing better than an anti-spam company. That’s why we are providing Phishing Awareness Training to our customers. According to a report by Verizon, only 3% of targeted users report malicious emails to management. With compan…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question