fflush not writing to file

Hello all,
I have a C++ class that I am using to act as a real time logger for a generic server application.  When the WriteLogEntry function is called it writes the log entry to the file stream.  After writing it out, I call fflush to move it into the file on the disk, however the data is not being written to the disk until fclose is called.  

My understanding of fflush was that it flushed the stream to the end device.  Is this a correct understanding?  If so what is going wrong here?  If not, how to I get the data written to disk without having to call fclose?  I need to be able to use the log file as a diagnostic tool without shutting down the server to get the data to the log.

Thanks much.
**************************
ServerLog.h
**************************
#ifndef SERVER_LOG_H
#define SERVER_LOG_H
 
#include <stdio.h>
#include <boost/algorithm/string.hpp>
 
using namespace std;
using namespace boost;
 
class ServerLog
{
public:
	static ServerLog* Instance();
	void WriteLogEntry(string entryData);
	~ServerLog(void);
 
protected:
	ServerLog(void);
 
private:
	static ServerLog* instance;
	static FILE* serverLogFile;
};
 
#endif /* SERVER_LOG_H */
 
**************************
ServerLog.cpp
**************************
#include "ServerLog.h"
 
FILE* ServerLog::serverLogFile = 0;
ServerLog* ServerLog::instance = 0;
 
ServerLog* ServerLog::Instance()
{
	if( instance == 0 )
	{
		instance = new ServerLog();
	}
	return instance;
}
 
ServerLog::ServerLog(void)
{
	serverLogFile = fopen("lcs_system.log", "a");
	int result = fflush(serverLogFile);
}
 
ServerLog::~ServerLog(void)
{
	fclose(serverLogFile);
}
 
void ServerLog::WriteLogEntry(string entryData)
{
	// todo: check write - throw exception if not correct
	int bytesWritten = fwrite(entryData.c_str(), sizeof(char), entryData.length(), serverLogFile);
}

Open in new window

LVL 1
edcAsked:
Who is Participating?
 
evilrixConnect With a Mentor Senior Software Engineer (Avast)Commented:
You have to call fflush after every write, not just when you open the file. Everytime you call it the write buffer will be flushed. In your code example you only flush when you open the file, what about in WriteLogEnrty()?
0
 
evilrixSenior Software Engineer (Avast)Commented:
0
 
edcAuthor Commented:
I don't freakin' believe I did that.  Thanks evilrix for pointing that out.  I'm going to go feel stupid for a few days :o).
0
 
evilrixSenior Software Engineer (Avast)Commented:
>> I don't freakin' believe I did that.
Sometime it just needs anotehr pair of eye -- I do things like that all the time :)

>> Thanks evilrix for pointing that out.
Very welcome
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.