Improve company productivity with a Business Account.Sign Up

x
?
Solved

Collection was modified; enumeration operation may not execute, enumerating through FileInfo

Posted on 2009-05-20
9
Medium Priority
?
1,293 Views
Last Modified: 2013-12-17
I have a collection of zipfiles in a FileInfo object, and as I loop through them, I determine if I need it or not. When I run the code, I get following runtime error message...

Collection was modified; enumeration operation may not execute

Here is a sample pseudo, of what I have going on. Is there a simple way to work around this without making things too hairy?  :-)
foreach (FileInfo zp in ZipFiles)
            {
			
					// Do some calculations. Determine if I don't need the zip file.
                    ZipFiles.Remove(zp);//remove zipfiles that I don't need
					
					// Do some calculations. Determine if I do need the zip file.
                    ZipFiles.Add(fi);//add some new zipfiles that I do need.
					
 
            }//end of foreach loop

Open in new window

0
Comment
Question by:silentthread2k
9 Comments
 
LVL 11

Assisted Solution

by:srikanthreddyn143
srikanthreddyn143 earned 200 total points
ID: 24433460
You cant add or remove from a collection while doing a loop on it. You have to clone that collection and make add/remove on it.
0
 
LVL 75

Assisted Solution

by:käµfm³d 👽
käµfm³d   👽 earned 800 total points
ID: 24433501
You cannot modify a list (ZipFiles) for which you are stepping through via an iterator. Try copying the list and modifying the copy.
public List<FileInfo> EditList(List<FileInfo> ZipFiles)
{
    List<FileInfo> tempList = new List<FileInfo>(ZipFiles);
 
    foreach (FileInfo zp in ZipFiles)
    {
        // Do some calculations. Determine if I don't need the zip file.
        tempList.Remove(zp);//remove zipfiles that I don't need
 
        // Do some calculations. Determine if I do need the zip file.
        tempList.Add(fi);//add some new zipfiles that I do need.
    }
 
    return tempList;
}

Open in new window

0
 
LVL 26

Assisted Solution

by:Anurag Thakur
Anurag Thakur earned 200 total points
ID: 24433821
to modify a collection you cannot use a foreach loop as if you remove the collection the indexers will be modified and and exception will be thrown

to achieve use a for loop and start from the last (highest count) and come back to 0 and if your calculations prove that it needs to be removed then you can achieve it easily
0
Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
LVL 3

Assisted Solution

by:mpf1748
mpf1748 earned 400 total points
ID: 24433912
Another way that I have used in the past is to traverse the list backwards and remove as a I go, but you will have to use a for loop instead of a foreach loop. This solution works better for removing, but you could also add items at the end of the list.
for (int i = ZipFiles.Count-1; i >= 0; i--)
{
  FileInfo zf = ZipFiles[i];
  if (<logic to remove>)
  {
    ZipFiles.Remove(zp);
  }
  if (<logic to add>)
  {
    ZipFiles.Add(<new zip file>);
  }
}

Open in new window

0
 
LVL 22

Assisted Solution

by:p_davis
p_davis earned 400 total points
ID: 24434135
you can use a foreach with a delegate

ZipFiles.ForEach(delegate (FileInfo zp)
            {
                       
                                        // Do some calculations. Determine if I don't need the zip file.
                    ZipFiles.Remove(zp);//remove zipfiles that I don't need
                                       
                                        // Do some calculations. Determine if I do need the zip file.
                    ZipFiles.Add(fi);//add some new zipfiles that I do need.
                                       
 
            });
//end of foreach loop
0
 
LVL 22

Expert Comment

by:p_davis
ID: 24434148
i really wouldn't recommend removing or adding in a for loop though
0
 

Accepted Solution

by:
silentthread2k earned 0 total points
ID: 24434197
Thanks, I will just modify the files and then just build the collection.
0
 

Author Comment

by:silentthread2k
ID: 24434217
Thanks.
0
 

Author Comment

by:silentthread2k
ID: 24434613
I accepted my solution, but let me know if you get awarded points, which is what I tried doing.
Thanks again.
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Calculating holidays and working days is a function that is often needed yet it is not one found within the Framework. This article presents one approach to building a working-day calculator for use in .NET.
Simulator games are perfect for generating sample realistic data streams, especially for learning data analysis. It is even useful for demoing offerings such as Azure stream analytics, PowerBI etc.
The video will let you know the exact process to import OST/PST files to the cloud based Office 365 mailboxes. Using Kernel Import PST to Office 365 tool, one can quickly import numerous OST/PST files to Office 365. Besides this, the tool also comes…
Watch the video to know the process of migration of Exchange or Office 365 mailboxes in absence of MS Outlook. It is an eminent tool which can easily migrate Public, Archive user mailboxes from one another Exchange server and Office 365. Kernel Migr…

606 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question