[Webinar] Streamline your web hosting managementRegister Today

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 4792
  • Last Modified:

C# WinForms: My picturebox image will not update?

C# Windows form. Picture box not updating.

I basically built a timer with gif numbers. I can set the pictureboxes from a buttonclick or from load events but when I try in a method the picturebox never updates? I am so confused.

Code is below.

Thanks,
KarlS2010
public partial class frmCountdown : Form
    {
        public frmCountdown()
        {
            InitializeComponent();
            picDay1.Image = Image.FromFile("images/4c.gif"); // WORKS GREAT!
        }
 
       public void Countdown()
        {
            //Start counting down from start to finish
            for (int i = 0; i < 3; i++)
            {
                this.picDay1.Image = Image.FromFile("images/4c.gif"); // WORKS FROM INIT BUT NOT HERE!?
                this.Refresh(); // NO HELP HERE?! Tried everything with and without this.
            }
            this.Refresh(); // NOPE
        }

Open in new window

0
KarlS2010
Asked:
KarlS2010
  • 4
  • 4
1 Solution
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
It's probably going by so fast that you can't even see it changing.

...plus, are you wanting to change the filename with the loop?

Something like:

        public void Countdown()
        {
            //Start counting down from start to finish
            for (int i = 0; i < 3; i++)
            {
                this.picDay1.Image = Image.FromFile("images/" + i.ToString() + "c.gif"); // <-- change image via "i"
                Application.DoEvents();  // allow the picturebox to refresh itself before continuing
                System.Threading.Thread.Sleep(1000); // one second delay to allow user to see it before it changes
            }
        }

Open in new window

0
 
tcullerCommented:
If the above isn't what you're thinking, the Invalidate() method may be what you're looking for. It basically forces a re-draw of the Control. Refresh seems to be stingy with me, so I use that when it comes to forcing a re-draw.
0
 
KarlS2010Author Commented:
Do not worry about the loop it is sjust there in fact remove it i your mind.
I also tried this with no luck:

       public void Countdown()
        {
            this.picDay1.Image = Image.FromFile("images/4c.gif"); // WORKS FROM INIT BUT NOT HERE!?
            this.Invalidate();    
            // this.Refresh(); // NO HELP HERE?!Karls2010
0
The new generation of project management tools

With monday.com’s project management tool, you can see what everyone on your team is working in a single glance. Its intuitive dashboards are customizable, so you can create systems that work for you.

 
KarlS2010Author Commented:
The only thing I do i call another form and then that form sends control back to the main form and then it will not update. Here is the complete code (driving me nuts!) I am sure it is simple but doh!
namespace Countdown
{
    public partial class frmCountdown : Form
    {
        public frmCountdown()
        {
            InitializeComponent();
            
        }
 
        // SETUP VARIABLES
        
        private void pictureBox15_Click(object sender, EventArgs e)
        {
            // SHOW THE OPTIONS FORM
            frmOptions frmOptionsDialog = new frmOptions();
            frmOptionsDialog.Show();
        }
 
        private void picShowElapsed_Click(object sender, EventArgs e)
        {
            // SHOW STATUS FORM
            frmStatus frmStatusDialog = new frmStatus();
            frmStatusDialog.Show();            
        }
 
        public void Countdown()
        {
            //Start counting down from start to finish
            this.picSec2.Image = Image.FromFile("images/2c.gif");
            picSec3.Image = Image.FromFile("images/1c.gif"); // ******************
            DoIt();
        }
 
        public void DoIt()
        {
            picSec3.Image = Image.FromFile("images/1c.gif"); // ******************\
        }
        
    }
}

Open in new window

0
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
"..and then that form sends control back to the main form..."

How are you giving control "back" to the main form?...I suspect that is where you are going wrong.
0
 
KarlS2010Author Commented:
errr... on the options form I just do a this.Hide(); and then ...

            frmCountdown Actor = new frmCountdown(); // Create an object!
            Actor.picDay1.Image = Image.FromFile("images/4c.gif"); // NOPE WONT CHANGE IT HERE EITHER
            Actor.Countdown(); // this is where I call the method on the main form that should change the image
0
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
...and there is the problem!

In this line:

    frmCountdown Actor = new frmCountdown(); // Create an object!

You are creating ANOTHER instance of frmCountdown and changing the image on that one...this instnace is actually invisible since it is never even shown.

What you need is a reference to the ALREADY OPEN instance of frmCountdown.

Explain to me the "flow" of the app and I can help you with a good solution.

One big question I have is does frmOptions itself have to make the change?...or should frmCountdown be making the change in response to an event/condition on or received from frmOptions?
0
 
KarlS2010Author Commented:
Thanks Idle -

Basically I have a countdown screen with an option button - someone clicks options and sets the start and stop dates and then clicks save (or whatever) and the form should start counting. I had trouble with static ad instance variables so I was trying to find a simple way to call Coutdown() (on the main form)  from my options form. I thought making an Actor object would work but you are prob right!

Do you need more what can I do to  make a a reference to the ALREADY OPEN instance of frmCountdown?

Thanks!
KarlS2010
0
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
What you can do is pass in the "main" form when you Show() the "options" form like this:

    frmOptions frmOptionsDialog = new frmOptions();
    frmOptionsDialog.Show(this); // <--- passing the main form to Show()

Then, in frmOptions, you can cast the "Owner" property back to the main form type:

    frmCountdown fcd = (frmCountdown)this.Owner;
    fcd.picDay1.Image = Image.FromFile("images/4c.gif");
    fcd.Countdown();

*You may have to change the Modifiers() property for "picDay1" to public.
0

Featured Post

Never miss a deadline with monday.com

The revolutionary project management tool is here!   Plan visually with a single glance and make sure your projects get done.

  • 4
  • 4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now