Javascript not firing from onclick event

Hi,

I am trying to fire a small javascript function from a form button.  The problem is that I can not even get it to fire when I click - if you look at the code I have put an alert at the top just to take a string to see if it is working.

What have I got wrong

Thanks
<form id="frm_app_button" name="frm_app_button" action="" method="post"> 
    <input type="text" name="AppId" id="AppId" />
    <input type="submit" name="Submit" value="Submit" id="submit" onclick="AppWarning('yes');"  />
    </form>
 
 
function AppWarning( str )
	{
	alert (str);
	var jstr = "The following ids will be approved.  Is this correct" ;
	var vals = document.frm_app_button.AppId.value;
	var x = jstr + ' ' + vals;
	var answer = Confirm: (x);
		{
		if (answer)
			alert("You said: Ok");
		else
			alert("You said: Cancel");
		}
	}

Open in new window

LVL 17
wobbledAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

mohan_sekarCommented:
Is the function defined within <script> tags?
0
wobbledAuthor Commented:
Yes it is - I just missed them off when copying them into the code window for the question
0
jmanGJHS97Commented:
You have to put your javascript inside script tags.

Also, as a test, try this:

<input type="submit" name="Submit" value="Submit" id="submit" onclick="AppWarning('yes'); return false;"  />

This should fire the alert but not submit the form.  It's possible the form is being submitted and killing your alert before you see it.

It looks like you're trying to do an "Are you sure?" button.  If that's the case, there are much simpler ways to do that.

Here's an example:

http://www.codingforums.com/showthread.php?t=143947
<form id="frm_app_button" name="frm_app_button" action="" method="post"> 
    <input type="text" name="AppId" id="AppId" />
    <input type="submit" name="Submit" value="Submit" id="submit" onclick="AppWarning('yes');"  />
    </form>
 
<script> 
function AppWarning( str )
        {
        alert (str);
        var jstr = "The following ids will be approved.  Is this correct" ;
        var vals = document.frm_app_button.AppId.value;
        var x = jstr + ' ' + vals;
        var answer = Confirm: (x);
                {
                if (answer)
                        alert("You said: Ok");
                else
                        alert("You said: Cancel");
                }
        }
</script>

Open in new window

0
mohan_sekarCommented:
small typo in your code -> change the original statement to var answer = confirm(x);
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
wobbledAuthor Commented:
Cheers for that - I didn't see the typo.

Thanks to everyone who posted a reply
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Web Languages and Standards

From novice to tech pro — start learning today.