Solved

Javascript not firing from onclick event

Posted on 2009-06-29
5
645 Views
Last Modified: 2013-11-19
Hi,

I am trying to fire a small javascript function from a form button.  The problem is that I can not even get it to fire when I click - if you look at the code I have put an alert at the top just to take a string to see if it is working.

What have I got wrong

Thanks
<form id="frm_app_button" name="frm_app_button" action="" method="post"> 

    <input type="text" name="AppId" id="AppId" />

    <input type="submit" name="Submit" value="Submit" id="submit" onclick="AppWarning('yes');"  />

    </form>
 
 

function AppWarning( str )

	{

	alert (str);

	var jstr = "The following ids will be approved.  Is this correct" ;

	var vals = document.frm_app_button.AppId.value;

	var x = jstr + ' ' + vals;

	var answer = Confirm: (x);

		{

		if (answer)

			alert("You said: Ok");

		else

			alert("You said: Cancel");

		}

	}

Open in new window

0
Comment
Question by:wobbled
  • 2
  • 2
5 Comments
 
LVL 15

Expert Comment

by:mohan_sekar
Comment Utility
Is the function defined within <script> tags?
0
 
LVL 17

Author Comment

by:wobbled
Comment Utility
Yes it is - I just missed them off when copying them into the code window for the question
0
 
LVL 9

Expert Comment

by:jmanGJHS97
Comment Utility
You have to put your javascript inside script tags.

Also, as a test, try this:

<input type="submit" name="Submit" value="Submit" id="submit" onclick="AppWarning('yes'); return false;"  />

This should fire the alert but not submit the form.  It's possible the form is being submitted and killing your alert before you see it.

It looks like you're trying to do an "Are you sure?" button.  If that's the case, there are much simpler ways to do that.

Here's an example:

http://www.codingforums.com/showthread.php?t=143947
<form id="frm_app_button" name="frm_app_button" action="" method="post"> 

    <input type="text" name="AppId" id="AppId" />

    <input type="submit" name="Submit" value="Submit" id="submit" onclick="AppWarning('yes');"  />

    </form>

 

<script> 

function AppWarning( str )

        {

        alert (str);

        var jstr = "The following ids will be approved.  Is this correct" ;

        var vals = document.frm_app_button.AppId.value;

        var x = jstr + ' ' + vals;

        var answer = Confirm: (x);

                {

                if (answer)

                        alert("You said: Ok");

                else

                        alert("You said: Cancel");

                }

        }

</script>

Open in new window

0
 
LVL 15

Accepted Solution

by:
mohan_sekar earned 250 total points
Comment Utility
small typo in your code -> change the original statement to var answer = confirm(x);
0
 
LVL 17

Author Closing Comment

by:wobbled
Comment Utility
Cheers for that - I didn't see the typo.

Thanks to everyone who posted a reply
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Styling your websites can become very complex. Here I'll show how SASS can help you better organize, maintain and reuse your CSS code.
This is a PowerShell web interface I use to manage some task as a network administrator. Clicking an action button on the left frame will display a form in the middle frame to input some data in textboxes, process this data in PowerShell and display…
In this tutorial viewers will learn how to position overlapping items using z-index in CSS. They will also learn the restrictions on the z-index property.  Create a new HTML document with an internal stylesheet.: Create a div in CSS and name it Red.…
In this tutorial viewers will learn how to embed Flash content in a webpage using HTML5. Ensure your DOCTYPE declaration is set to HTML5: "<!DOCTYPE html>": Use the <object> tag to embed Flash content.: To specify that the object is Flash content, d…

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now