• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 284
  • Last Modified:

Has anyone already written some version of this Clean up Instr function?

I am cleaning data right now, and I am starting with First and last names.  Our first name field may have as many as 3 - 5 "First names" in it.  The "Last Name" also contains multiple and or hyphenated names, and suffixes as well.  My plan is to make sure that the capitalization is correct.  I am using the InStr function to find spaces, and correct upper and lower case based on the spaces.  I started by putting some code in a query field, but the code gets real long real fast, depending on how many spaces you account for.  I quickly realized this would be better accomplished with a function.  Below is an example of what I want to clean:

First Name: RODRIGO ESTEBAN MIGUEL s/b Rodrigo Esteban Miguel
Last Name: Santos- JIMENEZ, JR. s/b Santos-Jimenez Jr.

I figured someone must have already written something similar to what I am looking for.  If not, any suggestions on the cleanest way to do this?

Thanks - Hubbs
0
Hubbsjp21
Asked:
Hubbsjp21
  • 6
  • 4
2 Solutions
 
Rey Obrero (Capricorn1)Commented:
you can use strconv()

strconv("RODRIGO ESTEBAN MIGUEL",3)  will give you  Rodrigo Esteban Miguel
0
 
Hubbsjp21Author Commented:
Hey Cap,

I guess I didn't look very hard for that function, 'cause I saw it and didn't read it.  Since that was so easy, can you suggest a way to add a period after any one character string withing the field?

i.e. Gerald S becomes Gerald S.
or J D becomes J. D.

Thanks - Hubbs
0
 
therealmongooseCommented:
You learn something every day... Just spent 15 minutes writing a function only to see cap's post.... every day's a school day. The below will however identify a single letter in a string and add a "." after it....
Watch out for rouge names though - e.g. MacKenzie etc....

Option Compare Database
Option Explicit
 
 
Function fncProperCase(strInString As String) As String
 
    Dim strWords() As String
    Dim strResult As String
    Dim x As Integer
    Dim varItem As Variant
    
    ReDim strWords(0)
    
    strInString = LCase(Trim(strInString))
        
    For x = 1 To Len(strInString)
    
        If Mid(strInString, x, 1) = " " Then
            strWords(UBound(strWords)) = UCase(Mid(strInString, 1, 1))
            
            If x > 1 Then
                strWords(UBound(strWords)) = Trim(strWords(UBound(strWords)) & Mid(Trim(strInString), 2, x - 2))
            End If
              
            If Len(strWords(UBound(strWords))) = 1 Then strWords(UBound(strWords)) = strWords(UBound(strWords)) & "."
          
            strInString = Trim(Right(strInString, Len(Trim(strInString)) - x))
            
            ReDim Preserve strWords(UBound(strWords) + 1)
            
            x = 1
            
        End If
    
    Next x
    
    strInString = Trim(strInString)
    
    strWords(UBound(strWords)) = UCase(Mid(strInString, 1, 1))
            
    If Len(strInString) > 1 Then
        strWords(UBound(strWords)) = strWords(UBound(strWords)) & Mid(Trim(strInString), 2, Len(Trim(strInString)) - 1)
    End If
    
    For Each varItem In strWords
    
        strResult = strResult & " " & varItem
        
    Next varItem
    
    strResult = Trim(strResult)
    
    fncProperCase = strResult
    
End Function

Open in new window

0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
Hubbsjp21Author Commented:
Nice work Mongoose

I have never seen the following before:
-  ReDim
-  Preserve
-  UBound (looked this up)

Everything works except the period.

Thanks - Hubbs
0
 
therealmongooseCommented:
redim preserve & ubound are used in array structures - useful if you need a holder for several values of the same type...
The code should work if there's a single letter in the string supplied - can you post an example of a data string that doesn't work...
I did thest the code with "THIS IS A TEST" and got "This Is A. Test"
 
0
 
Hubbsjp21Author Commented:
If you can very quickly, test it with "THIS Is A" and see if you get the correct result.  I think it may be because the single letter is the last letter.  In the mean time, I will set up the data to show you.
0
 
Hubbsjp21Author Commented:
Hey Mongoose,

I just tested "THIS IS A TEST" and "THIS IS A" in the immediate window, and the results were:

"THIS IS A TEST"  - This Is A. Test  (works fine)
"THIS IS A"  - This Is A (no period)

I appears by my limited analysis that it has something to do with the single character also being the last character.  Unfortunately, that is usually going to be the case for my purposes.  I have no idea how to fix it because I still am not even 50% sure how it works based on the functions(that are new to me) you used.

Hubbs
0
 
therealmongooseCommented:
Hi Hubbs,
 
You are correct it's the last character that wasn't being catered for... Here's an amended version....
 
Cheers,
 
Mongoose
 

Option Compare Database
Option Explicit
 
 
Function fncProperCase(strInString As String) As String
 
    Dim strWords() As String
    Dim strResult As String
    Dim x As Integer
    Dim varItem As Variant
    
    ReDim strWords(0)
    
    strInString = LCase(Trim(strInString))
        
    For x = 1 To Len(strInString)
    
        If Mid(strInString, x, 1) = " " Then
            strWords(UBound(strWords)) = UCase(Mid(strInString, 1, 1))
            
            If x > 1 Then
                strWords(UBound(strWords)) = Trim(strWords(UBound(strWords)) & Mid(Trim(strInString), 2, x - 2))
            End If
              
            If Len(strWords(UBound(strWords))) = 1 Then strWords(UBound(strWords)) = strWords(UBound(strWords)) & "."
          
            strInString = Trim(Right(strInString, Len(Trim(strInString)) - x))
            
            ReDim Preserve strWords(UBound(strWords) + 1)
            
            x = 1
            
        End If
    
    Next x
    
    strInString = Trim(strInString)
    
    strWords(UBound(strWords)) = UCase(Mid(strInString, 1, 1))
            
    If Len(strInString) > 1 Then
        strWords(UBound(strWords)) = strWords(UBound(strWords)) & Mid(Trim(strInString), 2, Len(Trim(strInString)) - 1)
    Else
        strWords(UBound(strWords)) = strWords(UBound(strWords)) & "."
    End If
    
    For Each varItem In strWords
    
        strResult = strResult & " " & varItem
        
    Next varItem
    
    strResult = Trim(strResult)
    
    fncProperCase = strResult
    
End Function

Open in new window

0
 
Hubbsjp21Author Commented:
Hi Mongoose,

I added the "If" clause below on the attached snippet in order to get the period at the end when necessary.  If you feel like making an adjustment to the code you sent to account for the single character being the last character, great.  If not, I am good to go.

Thanks for your snippet and input.

Hubbs


strResult = Trim(strResult)
    
    If InStr(Right(strResult, 2), " ") = 1 Then
    strResult = strResult & "."
    End If
    
    fncProperCase = strResult
    
    
End Function

Open in new window

0
 
Hubbsjp21Author Commented:
Mongoose - Looks like our comments "crossed in the mail".  I am going to split the points.  Thanks to both of you.

Hubbs
0
 
therealmongooseCommented:
Thanks Hubbs...
0

Featured Post

Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

  • 6
  • 4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now