Help with stored procedure


Hi Experts,
I am writing following code and stored procedure,but I am getting unexpected result.
If I execute the select statement in the procedure seperately the output is correct.
Is the way I am passing parameters is correct?
Your help is appreciated.
SqlCommand cmd = new SqlCommand("spsearchPersonForResettlement", cnn.connection());
        cmd.CommandType = CommandType.StoredProcedure;
 
        
        if (this.ddlVillage.SelectedValue != "Select Village")
        {
            cmd.Parameters.Add("@vid", SqlDbType.Int).Value = Convert.ToInt32(this.ddlVillage.SelectedValue);
        }
        else
        {
            cmd.Parameters.Add("@vid", SqlDbType.Int).Value = null;
        }
 
       
        cmd.Parameters.Add("@sno", SqlDbType.NVarChar).Value = this.txtSurveyNoAcquired.Text;
 
        if (this.txtPropertyNoAcquired.Text != "")
        {
            cmd.Parameters.Add("@propno", SqlDbType.Int).Value = Convert.ToInt32(this.txtPropertyNoAcquired.Text);
        }
        else
        {
            cmd.Parameters.Add("@propno", SqlDbType.Int).Value = null;
        }
 
        cmd.Parameters.Add("@lastname", SqlDbType.NVarChar).Value = this.txtLastName.Text;
        cmd.Parameters.Add("@firstname", SqlDbType.NVarChar).Value = this.txtFirstName.Text;
        cmd.Parameters.Add("@middlename", SqlDbType.NVarChar).Value = this.txtMiddleName.Text;
 
        cmd.Parameters.Add("@param", SqlDbType.NVarChar).Value = this.ddlOption.SelectedValue;
 
 
 
        SqlDataAdapter da = new SqlDataAdapter(cmd);
        DataSet ds = new DataSet();
        da.Fill(ds);
 
        this.GridView1.DataSource = ds;
        this.GridView1.DataBind();
 
 
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 
Create PROCEDURE [dbo].[spsearchPersonForResettlement]
	-- Add the parameters for the stored procedure here
	@param nvarchar(5),
	@lastname nvarchar(100) = null,
	@firstname nvarchar(100) = null,
	@middlename nvarchar(100) = null,
	@sno nvarchar(150) = null,
	@propno int = null,
	@vid int = null
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;
	
    -- Insert statements for procedure here
if @param = 'And'
Select distinct p.person_no,p.last_name,p.first_name,p.middle_name,p.address
from tbperson p inner join tbSurveryKhatedar sk on p.person_no = sk.person_no 
inner join tbGaothanPerson gp on p.person_no = gp.person_no 
	Where  	    sk.Village_id = Coalesce(@vid,Village_id)
		And     sk.new_servey_no = Coalesce(@sno,new_servey_no)
		And		gp.property_id = Coalesce(@propno,property_id)
		And		p.last_name = Coalesce(@lastname,last_name)
		And		p.first_name = Coalesce(@firstname,first_name)
		And		p.middle_name = Coalesce(@middlename,middle_name)
 
else
 
		Select distinct p.person_no,p.last_name,p.first_name,p.middle_name,p.address
from tbperson p inner join tbSurveryKhatedar sk on p.person_no = sk.person_no 
inner join tbGaothanPerson gp on p.person_no = gp.person_no 
	Where  	    sk.Village_id = Coalesce(@vid,Village_id)
		And     sk.new_servey_no = Coalesce(@sno,new_servey_no)
		And		gp.property_id = Coalesce(@propno,property_id)
		And		p.last_name = Coalesce(@lastname,last_name)
		And		p.first_name = Coalesce(@firstname,first_name)
		Or		p.middle_name = Coalesce(@middlename,middle_name)
END

Open in new window

LVL 8
Johny BravoAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Raja Jegan RSQL Server DBA & Architect, EE Solution GuideCommented:
Kindly change @param nvarchar(5) to @param varchar(5)

If your database is case sensitive, then make sure that value "And" is passed as input.If you pass some other values for @param it wont work.

Missing few alias names have been included.

Other than that no problem with the syntax
Create PROCEDURE [dbo].[spsearchPersonForResettlement]
        -- Add the parameters for the stored procedure here
        @param varchar(5),
        @lastname nvarchar(100) = null,
        @firstname nvarchar(100) = null,
        @middlename nvarchar(100) = null,
        @sno nvarchar(150) = null,
        @propno int = null,
        @vid int = null
AS
BEGIN
        -- SET NOCOUNT ON added to prevent extra result sets from
        -- interfering with SELECT statements.
        SET NOCOUNT ON;
        
    -- Insert statements for procedure here
if @param = 'And'
Select distinct p.person_no,p.last_name,p.first_name,p.middle_name,p.address
from tbperson p inner join tbSurveryKhatedar sk on p.person_no = sk.person_no 
inner join tbGaothanPerson gp on p.person_no = gp.person_no 
        Where       sk.Village_id = Coalesce(@vid,sk.Village_id)
                And     sk.new_servey_no = Coalesce(@sno,sk.new_servey_no)
                And             gp.property_id = Coalesce(@propno,gp.property_id)
                And             p.last_name = Coalesce(@lastname,p.last_name)
                And             p.first_name = Coalesce(@firstname,p.first_name)
                And             p.middle_name = Coalesce(@middlename,p.middle_name)
 
else
 
                Select distinct p.person_no,p.last_name,p.first_name,p.middle_name,p.address
from tbperson p inner join tbSurveryKhatedar sk on p.person_no = sk.person_no 
inner join tbGaothanPerson gp on p.person_no = gp.person_no 
        Where       sk.Village_id = Coalesce(@vid,sk.Village_id)
                And     sk.new_servey_no = Coalesce(@sno,sk.new_servey_no)
                And             gp.property_id = Coalesce(@propno,gp.property_id)
                And             p.last_name = Coalesce(@lastname,p.last_name)
                And             p.first_name = Coalesce(@firstname,p.first_name)
                Or              p.middle_name = Coalesce(@middlename,p.middle_name)
END

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Johny BravoAuthor Commented:
Thanks for your comment.

exec spsearchPersonForResettlement @vid=1,@sno=null,@propno=null,@lastname=null,@firstname=null,@middlename=null,@param=N'Or'

exec spsearchPersonForResettlement @vid=default,@sno=default,@propno=default,@lastname=default,@firstname=default,@middlename=default,@param=N'And'

I am getting same result for both the lines.
There is one improvement in asbove procedure.
If I execute the select statement with 'Or' and other values null.I am getting 440 records.But not with procedure.
And for 'And' I am getting 3 records for select statement.

But with procedure it is always showing me 3 records.
The stored proc is as follows.
Alter PROCEDURE [dbo].[spsearchPersonForResettlement]
	-- Add the parameters for the stored procedure here
		@param varchar(5),
        @lastname nvarchar(100) = null,
        @firstname nvarchar(100) = null,
        @middlename nvarchar(100) = null,
        @sno nvarchar(150) = null,
        @propno int = null,
        @vid int = null
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;
	
    -- Insert statements for procedure here
if @param = 'And'
Select distinct p.person_no,p.last_name,p.first_name,p.middle_name,p.address
from tbperson p inner join tbSurveryKhatedar sk on p.person_no = sk.person_no 
inner join tbGaothanPerson gp on p.person_no = gp.person_no 
	Where  	    sk.Village_id = Coalesce(@vid,Village_id)
		And     sk.new_servey_no = Coalesce(@sno,new_servey_no)
		And		gp.property_id = Coalesce(@propno,property_id)
		And		p.last_name = Coalesce(@lastname,last_name)
		And		p.first_name = Coalesce(@firstname,first_name)
		And		p.middle_name = Coalesce(@middlename,middle_name)
 
else if @param = 'Or'
 
		Select distinct p.person_no,p.last_name,p.first_name,p.middle_name,p.address
from tbperson p inner join tbSurveryKhatedar sk on p.person_no = sk.person_no 
inner join tbGaothanPerson gp on p.person_no = gp.person_no 
	 Where  	sk.Village_id = Coalesce(@vid,Village_id)
             And		p.first_name = Coalesce(@firstname,first_name)
             And		p.middle_name = Coalesce(@middlename,middle_name)
             And     sk.new_servey_no = Coalesce(@sno,new_servey_no)
             And		p.last_name = Coalesce(@lastname,last_name)
             Or		gp.property_id = Coalesce(@propno,property_id)
END

Open in new window

0
Chris LuttrellSenior Database ArchitectCommented:
the first thing I notice is that maybe this line should use DBNull.Value instead

cmd.Parameters.Add("@propno", SqlDbType.Int).Value = null;

cmd.Parameters.Add("@propno", SqlDbType.Int).Value = DBNull.Value;
0
10 Tips to Protect Your Business from Ransomware

Did you know that ransomware is the most widespread, destructive malware in the world today? It accounts for 39% of all security breaches, with ransomware gangsters projected to make $11.5B in profits from online extortion by 2019.

Johny BravoAuthor Commented:
Tried with it also.But same thing is happening. :(
0
Johny BravoAuthor Commented:
Sorry experts,that is my mistake.I was using inner join instead of left outer.
Thanks for your help.
0
Johny BravoAuthor Commented:
Thanks
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
.NET Programming

From novice to tech pro — start learning today.