Solved

sql server 2008: optimize store procedure ( more speed)-C# 2008

Posted on 2009-06-30
1
311 Views
Last Modified: 2013-12-17
sql server 2008: optimize store procedure ( more speed)-C# 2008.I want to make more speed store procedure in sql server 2008.I made store procedures via C# (visual studio 2008).Can I open connection only once?In order to maximize speed?And if any other suggestion I wiil accept them.  
public class StoredProceduresData
    {
        private static SqlConnection _conn;
        private LogFile log;
 
        public StoredProceduresData()
        {            
            log = new LogFile();           
        }
        public void CallSpInsertColumns(ArrayList nevId, ArrayList gameCode, int draw,
                                         int lotosRevision, ArrayList forecast, ArrayList odds,
                                         int totalMultiplier, DateTime time, int date,
                                         int columnNumber)
        {
            try
            {
                SqlCommand cmd;
                if (_conn.State == ConnectionState.Closed)
                    _conn.Open();
                if (columnNumber == 1)
                {                    
                    cmd = new SqlCommand("SP_INSERT_COLUMNS_1", _conn);
                    cmd.CommandType = CommandType.StoredProcedure;
                    cmd.Parameters.Add("@nevId", SqlDbType.BigInt).Value = (long)nevId[0];
                    cmd.Parameters.Add("@gameCode", SqlDbType.Int).Value = (int)gameCode[0];
                    cmd.Parameters.Add("@draw", SqlDbType.Int).Value = draw;
                    cmd.Parameters.Add("@lotosRevision", SqlDbType.Int).Value = lotosRevision;
                    cmd.Parameters.Add("@forecast", SqlDbType.Int).Value = (int)forecast[0];
                    cmd.Parameters.Add("@odds", SqlDbType.Decimal).Value = (float)odds[0];
                    cmd.Parameters.Add("@totalMultiplier", SqlDbType.Int).Value = totalMultiplier;
                    cmd.Parameters.Add("@time", SqlDbType.Time).Value = time.TimeOfDay;
                    cmd.Parameters.Add("@date", SqlDbType.Int).Value = date;
                    cmd.Parameters.Add("@columnNumber", SqlDbType.Int).Value = columnNumber;
 
                    cmd.ExecuteNonQuery();
                }
                else
                {                   
                    cmd = new SqlCommand(string.Format("SP_INSERT_COLUMNS_{0}", columnNumber), _conn);
                    cmd.CommandType = CommandType.StoredProcedure;
                    for (int ii = 1; ii <= columnNumber; ii++)
                    {
                        cmd.Parameters.Add(string.Format("@nevId_{0}", ii), SqlDbType.Int).Value = (long)nevId[ii - 1];
                        cmd.Parameters.Add(string.Format("@gameCode_{0}", ii), SqlDbType.SmallInt).Value = (int)gameCode[ii - 1];
                        cmd.Parameters.Add(string.Format("@odds_{0}", ii), SqlDbType.Decimal).Value = (float)odds[ii - 1];
                        cmd.Parameters.Add(string.Format("@forecast_{0}", ii), SqlDbType.SmallInt).Value = (int)forecast[ii - 1];
                    }
                    cmd.Parameters.Add("@draw", SqlDbType.Int).Value = draw;
                    cmd.Parameters.Add("@lotosRevision", SqlDbType.SmallInt).Value = lotosRevision;
                    cmd.Parameters.Add("@totalMultiplier", SqlDbType.Int).Value = totalMultiplier;
                    cmd.Parameters.Add("@time", SqlDbType.Time).Value = time.TimeOfDay;
                    cmd.Parameters.Add("@date", SqlDbType.Int).Value = date;
                    cmd.Parameters.Add("@columnNumber", SqlDbType.Int).Value = columnNumber;
 
                    cmd.ExecuteNonQuery();
                }
            }
 
            catch (Exception ex)
            {
                log.Log(ex.ToString());
                throw (ex);
            }
        }
        #region "Properties"
        public static SqlConnection SqlConnDatawarehouse
 //this is static in order to open only once!!! from Client!!!!!
        {
            get
            {
                return _conn;
            }
            set
            {
                _conn = value;
            }
        }
        #endregion
    }  
 
///--------------------------------------DEPLOY STORE PROCEDURE AS BELLOW-------------------------------------------
 
[Microsoft.SqlServer.Server.SqlProcedure]
    public static void SP_INSERT_COLUMNS_1(int nevId, int gameCode, int draw,
                                         int lotosRevision, int forecast, float odds,
                                         int totalMultiplier ,DateTime time, int date,
                                         int columnNumber)
    {       
        using (SqlConnection conn = new SqlConnection("Context Connection = true"))
        { 
            conn.Open();//--->CAN AVOID THIS?IN order to open only once?
            SqlCommand cmd = conn.CreateCommand();
         
            cmd.CommandText = string.Format("insert into Columns_{0} Values (@nevId, @gameCode, @draw, @lotosRevision, @forecast, @odds, @totalMultiplier, @date, @time )", columnNumber);
            cmd.Parameters.Add("@nevId", SqlDbType.Int).Value = nevId;
            cmd.Parameters.Add("gameCode", SqlDbType.SmallInt).Value = gameCode;
            cmd.Parameters.Add("@draw", SqlDbType.Int).Value = draw;
            cmd.Parameters.Add("@lotosRevision", SqlDbType.Int).Value = lotosRevision;
            cmd.Parameters.Add("@forecast", SqlDbType.Int).Value = forecast;
            cmd.Parameters.Add("@odds", SqlDbType.Decimal).Value = odds;
            cmd.Parameters.Add("@totalMultiplier", SqlDbType.Int).Value = totalMultiplier;
            cmd.Parameters.Add("@time", SqlDbType.Time).Value = time.TimeOfDay;
            cmd.Parameters.Add("@date", SqlDbType.Int).Value = date;
          
            
            SqlContext.Pipe.ExecuteAndSend(cmd);
            conn.Close();
        }
    }//....these are 30 stores procedures....SP_INSERT_COLUMNS_1,SP_INSERT_COLUMNS_2  e.t.c

Open in new window

0
Comment
Question by:nikavak
1 Comment
 
LVL 2

Accepted Solution

by:
sunil_mails earned 500 total points
ID: 24744367
Best option is to create SP with SQL in SQL 2008 and call it by passing the parameter from front end. Nothing gonna run faster than this.
0

Featured Post

Windows Server 2016: All you need to know

Learn about Hyper-V features that increase functionality and usability of Microsoft Windows Server 2016. Also, throughout this eBook, you’ll find some basic PowerShell examples that will help you leverage the scripts in your environments!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Wouldn’t it be nice if you could test whether an element is contained in an array by using a Contains method just like the one available on List objects? Wouldn’t it be good if you could write code like this? (CODE) In .NET 3.5, this is possible…
Today I had a very interesting conundrum that had to get solved quickly. Needless to say, it wasn't resolved quickly because when we needed it we were very rushed, but as soon as the conference call was over and I took a step back I saw the correct …
This Micro Tutorial will teach you how to censor certain areas of your screen. The example in this video will show a little boy's face being blurred. This will be demonstrated using Adobe Premiere Pro CS6.
In a recent question (https://www.experts-exchange.com/questions/28997919/Pagination-in-Adobe-Acrobat.html) here at Experts Exchange, a member asked how to add page numbers to a PDF file using Adobe Acrobat XI Pro. This short video Micro Tutorial sh…

808 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question