Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Availability using a for command in a batch file

Posted on 2009-06-30
5
221 Views
Last Modified: 2012-05-07
Hi everyone,
Guys im having a problem with a batch file using a for statement.

I have a text file listing computer names called "c:\computers.txt"
A batch file called check.bat

When I run check.bat, I want it to read c:\computers.txt, and for each computer, check if it can be pinged or not, and write either:

<Computername>:  Down
or
<Computername>:  Up

to the file:
availability.txt

I just cant seem to get this working.

Any help greatly appreciated.

If for example, i have 3 systems in computers.txt, the output I get when running the batch file is:

IP address must be specified.
IP address must be specified.
IP address must be specified.

and in the availabilty.txt file, I get:

: Down
: Down
: Down


I dont know where im going wrong :>)
@echo off
for /f %%c in (c:\computers.txt) do ( CALL :GETINFO)
 
:GETINFO
Set Availability=
ping -n 2 -w 100 %1
IF ERRORLEVEL 1 GOTO UP
goto UP
 
:UP
Set Availability=Up
 
:DOWN
Set Availability=Down
 
echo %1: %Availability%>>availability.txt

Open in new window

0
Comment
Question by:Simon336697
  • 3
  • 2
5 Comments
 
LVL 67

Expert Comment

by:sirbounty
ID: 24745297
Try this...
@echo off
setlocal enabledelayedexpansion
for /f %%c in (c:\computers.txt) do (
  call :GETINFO %%c
  echo %%c: !Availability!>>availability.txt
)
goto :eof
 
:GETINFO
if [%1]=[] goto :eof
Set Availability=
ping %1 -n 2 -w 100 
If %errorlevel%==1 goto DOWN
 
Set Availability=Up
goto :eof
 
:DOWN
Set Availability=Down

Open in new window

0
 
LVL 1

Author Comment

by:Simon336697
ID: 24745351
Hi sirbounty, hope you are well mate.
Sirbounty,

When i run your script, im getting the following mate :>)

=[] was unexpected at this time.
0
 
LVL 67

Accepted Solution

by:
sirbounty earned 500 total points
ID: 24745361
Try that once more...missed an = on line 10...
@echo off
setlocal enabledelayedexpansion
for /f %%c in (c:\computers.txt) do (
  call :GETINFO %%c
  echo %%c: !Availability!>>availability.txt
)
goto :eof
 
:GETINFO
if [%1]==[] goto :eof
Set Availability=
ping %1 -n 2 -w 100 
If %errorlevel%==1 goto DOWN
 
Set Availability=Up
goto :eof
 
:DOWN
Set Availability=Down

Open in new window

0
 
LVL 1

Author Comment

by:Simon336697
ID: 24745461
Sirb,

That works great mate.
Great to see you on here as always Sirb :>)
0
 
LVL 67

Expert Comment

by:sirbounty
ID: 24745601
Glad I could help once again. :^)
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

When you receive another warning that your shared drive is almost full and you have asked your users to clean out old files again and again, here is a single command that may help. This command will place all the files that have not been used rec…
If like me you are one who spends a lot of time working and scripting with cmd.exe, sometimes it is handy to be able to quickly view a calendar for a given month and year. This script will quickly do just that!  Save the code posted below to a .bat …
I've attached the XLSM Excel spreadsheet I used in the video and also text files containing the macros used below. https://filedb.experts-exchange.com/incoming/2017/03_w12/1151775/Permutations.txt https://filedb.experts-exchange.com/incoming/201…

860 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question