Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 236
  • Last Modified:

Availability using a for command in a batch file

Hi everyone,
Guys im having a problem with a batch file using a for statement.

I have a text file listing computer names called "c:\computers.txt"
A batch file called check.bat

When I run check.bat, I want it to read c:\computers.txt, and for each computer, check if it can be pinged or not, and write either:

<Computername>:  Down
or
<Computername>:  Up

to the file:
availability.txt

I just cant seem to get this working.

Any help greatly appreciated.

If for example, i have 3 systems in computers.txt, the output I get when running the batch file is:

IP address must be specified.
IP address must be specified.
IP address must be specified.

and in the availabilty.txt file, I get:

: Down
: Down
: Down


I dont know where im going wrong :>)
@echo off
for /f %%c in (c:\computers.txt) do ( CALL :GETINFO)
 
:GETINFO
Set Availability=
ping -n 2 -w 100 %1
IF ERRORLEVEL 1 GOTO UP
goto UP
 
:UP
Set Availability=Up
 
:DOWN
Set Availability=Down
 
echo %1: %Availability%>>availability.txt

Open in new window

0
Simon336697
Asked:
Simon336697
  • 3
  • 2
1 Solution
 
sirbountyCommented:
Try this...
@echo off
setlocal enabledelayedexpansion
for /f %%c in (c:\computers.txt) do (
  call :GETINFO %%c
  echo %%c: !Availability!>>availability.txt
)
goto :eof
 
:GETINFO
if [%1]=[] goto :eof
Set Availability=
ping %1 -n 2 -w 100 
If %errorlevel%==1 goto DOWN
 
Set Availability=Up
goto :eof
 
:DOWN
Set Availability=Down

Open in new window

0
 
Simon336697Author Commented:
Hi sirbounty, hope you are well mate.
Sirbounty,

When i run your script, im getting the following mate :>)

=[] was unexpected at this time.
0
 
sirbountyCommented:
Try that once more...missed an = on line 10...
@echo off
setlocal enabledelayedexpansion
for /f %%c in (c:\computers.txt) do (
  call :GETINFO %%c
  echo %%c: !Availability!>>availability.txt
)
goto :eof
 
:GETINFO
if [%1]==[] goto :eof
Set Availability=
ping %1 -n 2 -w 100 
If %errorlevel%==1 goto DOWN
 
Set Availability=Up
goto :eof
 
:DOWN
Set Availability=Down

Open in new window

0
 
Simon336697Author Commented:
Sirb,

That works great mate.
Great to see you on here as always Sirb :>)
0
 
sirbountyCommented:
Glad I could help once again. :^)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now