Link to home
Start Free TrialLog in
Avatar of wkolasa
wkolasaFlag for United States of America

asked on

javascript - math leaving off a digit

Hi,

I have a javascript that converts numbers to decimals (adds decimals if needed and does simple math).  It uses three fields to autoFill the 4th.  Field 1 is addition.  Field 2 subtraction.  Field 3 addition.  Field 4 should reflect the calculation of 1,2,3.  The problem is this.  If I type 20 into field 1, field four shows 2.00... and NOT 20.00.  This si probably a simple fix, and this was working great when I was using onChange instead of onKeyPress.  

Code is below.  Thank you very very much ... Wendi~
<script type="text/javascript">
 
function calc(){
  one = document.autoSumForm16.budget_income1.value;
  two = document.autoSumForm16.budget_income2.value;
  three = document.autoSumForm16.budget_income3.value;
      if (one >'' && two > '' && three > '' ) {
      var sum  = parseInt(one) - parseInt(two) + parseInt(three);
      
      var num = new NumberFormat(sum).toFormatted();
      document.autoSumForm16.budget_income4.value = num;
	  document.autoSumForm16.budget_exp4.value = num;
      }
      else  
      {
            alert ('Please enter a number.  No commas or letters.');
            }
}
 
 
function CurrencyFormatted(amount)
{
        var i = parseFloat(amount);
        if(isNaN(i)) { i = 0.00; }
        var minus = '';
        if(i < 0) { minus = '-'; }
        i = Math.abs(i);
        i = parseInt((i + .005) * 100);
        i = i / 100;
        s = new String(i);
        if(s.indexOf('.') < 0) { s += '.00'; }
        if(s.indexOf('.') == (s.length - 2)) { s += '0'; }
        s = minus + s;
        return s;
}
 
 
</script> 
 
<!--- These three fields calc the one below.  I want it to be where simply typing being the calculation, and instantly changes
      the number below --->
<input type="Text"  name="budget_income1" style="text-align:right;" onKeyPress="calc();" value="0">
<input type="Text"  name="budget_income2" style="text-align:right;" onKeyPress="calc();" value="0">
<input type="Text"  name="budget_income3" style="text-align:right;" onKeyPress="calc();" value="0">
 
 
<!--- This is the field being calculated by the 3 above --->
<input type="Text"  name="budget_income4"  style="text-align:right;" value="#getform.budget_income4#">

Open in new window

Avatar of wkolasa
wkolasa
Flag of United States of America image

ASKER

The issue is in the function calc()
Avatar of wkolasa

ASKER

The issue, which i haven't solved, is this.  Because of the onKeyPress instead of onChange, javascript doesn't know/care about decimals from the first three inputs.  In other words... if in the first field I type 10.00, field 4 = 10.00.  But if in the first field I type 1,   field 4 = 0.00
Avatar of wkolasa

ASKER

parseInt  is not digging the onKeyPress   but even knowing that I don't have a solution yet
Avatar of HonorGod
1. You don't want to be calling calc when a key is pressed.  This is a really bad idea...

2. To check for non-empty fields, change your if expression from this:

    if (one >'' && two > '' && three > '' ) {

    to this:

    if (one && two && three ) {

3. When you use parseInt(), be sure to include/specify the radix.  So, instead of using

    var sum  = parseInt(one) - parseInt(two) + parseInt(three);

    Use this instead:

    var sum  = parseInt( one, 10 ) - parseInt( two, 10 ) + parseInt( three, 10 );
Avatar of wkolasa

ASKER

Excellent.  Thank you.  I Know, beleive me I know this is a bad idea.  The client is demanding it.
Avatar of wkolasa

ASKER

I set the function as you outlined.  I'm still having the same problem though.  I tried to add decimals using toFixed... no good (probably a dumb idea, but I pretty new with javaScript).
Avatar of wkolasa

ASKER

The function simply doesn't see the first digit of the onKeyPress event
Looking at this I think you have made a simple problem very complicated. There are a number of easy ways of converting to numbers to  do arithmetic.  I can not test your code as it is incomplete., however

(1) Multiply a string by 1.0 converts it to a number
(2) num.toFixed(2) ouputs num to 2 decimal places
(3) isNaN(num) checks if num is a number

ASKER CERTIFIED SOLUTION
Avatar of Xxavier
Xxavier
Flag of Canada image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Avatar of wkolasa

ASKER

You're right, it is overly complicated.  Can't be helped.  Much of the code,  convoluted structure is already in place.  

Thank you very much!