Solved

Query Optimise

Posted on 2009-06-30
10
201 Views
Last Modified: 2012-05-07
How do i optimise this query ? The INNER LOOPS seem to take a hit on execution .
GO
 
DECLARE @Name1 nvarchar(100)
DECLARE @Name2 nvarchar(100)
DECLARE @Name3 nvarchar(100)
DECLARE @Name4 nvarchar(100)
 
DECLARE	@return_value int
declare @counter int
	set @counter = 0
	while @counter < 4650
BEGIN	
 
		 SET @Name1 = N'Name1'
		SET @Name2 = N'Name2'
		SET @Name3 = N'Name3'
		SET @Name4 = N'Name4'
		SET @Type = 1
		
		
 IF OBJECT_ID('tempdb..#SearchNames') IS NOT NULL DROP TABLE #SearchNames
 
CREATE TABLE #SearchNames
(
Names varchar(100)  NOT NULL
)
 
 
 
BEGIN   
SELECT * FROM oc_SDN WHERE Ent_Num IN 
			 (
		SELECT Ent_Num FROM oc_SDN A INNER JOIN #SearchNames B ON A.SDN_Name LIKE '%'  + B.Names  + '%'
			  )
OR Ent_Num IN ( 
		SELECT Ent_Num FROM oc_Aliases A INNER JOIN #SearchNames B ON A.Alt_Name LIKE '%'  + B.Names  + '%'
			  )
END
 
SET @counter = @counter +1
SELECT	'Return Value' = @return_value
END
 
GO

Open in new window

0
Comment
Question by:byte1
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 4
10 Comments
 
LVL 60

Expert Comment

by:Kevin Cross
ID: 24750937
Think something is missing from your code as you never put any data into the temp table and have two sets of BEGIN/END tags that seem out of place.
0
 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 24751200
How will you populate the #SearchNames ?
0
 

Author Comment

by:byte1
ID: 24751204
Sorry about that, I left some code.

if LEN(@Name1) > 0 BEGIN
SET @Name1 = replace(replace(replace(@Name1,' ','<>'),'><',''),'<>','%') 
INSERT INTO #SearchNames (Names) VALUES (@Name1)
END  
if LEN(@Name2) > 0 BEGIN	
SET @Name2 = replace(replace(replace(@Name2,' ','<>'),'><',''),'<>','%')  
INSERT INTO #SearchNames (Names) VALUES (@Name2)
END  
if LEN(@Name3) > 0 BEGIN
SET @Name3 =   replace(replace(replace(@Name3,' ','<>'),'><',''),'<>','%') 
INSERT INTO #SearchNames (Names) VALUES (@Name3)
 END  
if LEN(@Name4) > 0 BEGIN
SET @Name4 =  replace(replace(replace(@Name4,' ','<>'),'><',''),'<>','%') 
INSERT INTO #SearchNames (Names) VALUES (@Name4)
END  

Open in new window

0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 24751226
can you post the complete query
0
 

Author Comment

by:byte1
ID: 24751340

GO
 
DECLARE @Name1 nvarchar(100)
DECLARE @Name2 nvarchar(100)
DECLARE @Name3 nvarchar(100)
DECLARE @Name4 nvarchar(100)
DECLARE @Type int
 
DECLARE	@return_value int
declare @counter int
	set @counter = 0
	while @counter < 100
BEGIN	
 
		 SET @Name1 = N'Name1'
		SET @Name2 = N'Name2'
		SET @Name3 = N'Name3'
		SET @Name4 = N'Name4'
		SET @Type = 1
		
		
 IF OBJECT_ID('tempdb..#SearchNames') IS NOT NULL DROP TABLE #SearchNames
 
CREATE TABLE #SearchNames
(
Names varchar(100)  NOT NULL
)
 
if LEN(@Name1) > 0 BEGIN
SET @Name1 = replace(replace(replace(@Name1,' ','<>'),'><',''),'<>','%') 
INSERT INTO #SearchNames (Names) VALUES (@Name1)
END  
if LEN(@Name2) > 0 BEGIN	
SET @Name2 = replace(replace(replace(@Name2,' ','<>'),'><',''),'<>','%')  
INSERT INTO #SearchNames (Names) VALUES (@Name2)
END  
if LEN(@Name3) > 0 BEGIN
SET @Name3 =   replace(replace(replace(@Name3,' ','<>'),'><',''),'<>','%') 
INSERT INTO #SearchNames (Names) VALUES (@Name3)
 END  
if LEN(@Name4) > 0 BEGIN
SET @Name4 =  replace(replace(replace(@Name4,' ','<>'),'><',''),'<>','%') 
INSERT INTO #SearchNames (Names) VALUES (@Name4)
END  
 
if(@Type = 1)
BEGIN   
SELECT * FROM oc_SDN WHERE Ent_Num IN 
			 (
		SELECT Ent_Num FROM oc_SDN A INNER JOIN #SearchNames B ON A.SDN_Name LIKE '%'  + B.Names  + '%'
			  )
OR Ent_Num IN ( 
		SELECT Ent_Num FROM oc_Aliases A INNER JOIN #SearchNames B ON A.Alt_Name LIKE '%'  + B.Names  + '%'
			  )
END
ELSE
BEGIN
SELECT * FROM oc_SDN 
WHERE Ent_Num IN (
		SELECT Ent_Num FROM oc_SDN A INNER JOIN #SearchNames B ON A.SDN_Name = B.Names WHERE LEN(Names) > 0
			  )
OR Ent_Num IN ( 
		SELECT Ent_Num FROM oc_Aliases A INNER JOIN #SearchNames B ON A.Alt_Name = B.Names WHERE LEN(Names) > 0
			  )
END
 
SET @counter = @counter +1
SELECT	'Return Value' = @return_value
END
 
GO

Open in new window

0
 
LVL 75

Accepted Solution

by:
Aneesh Retnakaran earned 500 total points
ID: 24751423
try this
Also make sure that there is an index on all the joining columns, if you are using sql server 2005/2008 , go for include index
For table oc_SDN , the index should be   SDN_Name INCLUDE (Ent_Num )
and for oc_Aliases   Alt_Name INCLUDE (Ent_Num )
GO
 
DECLARE @Name1 nvarchar(100)
DECLARE @Name2 nvarchar(100)
DECLARE @Name3 nvarchar(100)
DECLARE @Name4 nvarchar(100)
DECLARE @Type int
 
DECLARE      @return_value int
declare @counter int
set @counter = 0 
IF OBJECT_ID('tempdb..#SearchNames') IS NOT NULL DROP TABLE #SearchNames 
CREATE TABLE #SearchNames ( Names varchar(100)  NOT NULL ) 
while @counter < 100
BEGIN      
	TRUNCATE TABLE #SearchNames
	SELECT @Name1 = N'Name1'
		, @Name2 = N'Name2'
		, @Name3 = N'Name3'
		, @Name4 = N'Name4'
		, @Type = 1
	            
	if LEN(@Name1) > 0 BEGIN
	SET @Name1 = replace(replace(replace(@Name1,' ','<>'),'><',''),'<>','%') 
	END  
	if LEN(@Name2) > 0 BEGIN      
	SET @Name2 = replace(replace(replace(@Name2,' ','<>'),'><',''),'<>','%')  
	END  
	if LEN(@Name3) > 0 BEGIN
	SET @Name3 =   replace(replace(replace(@Name3,' ','<>'),'><',''),'<>','%') 
	 END  
	if LEN(@Name4) > 0 BEGIN
	SET @Name4 =  replace(replace(replace(@Name4,' ','<>'),'><',''),'<>','%') 
	END   

	if(@Type = 1)
	BEGIN  
	 
		SELECT * FROM oc_SDN WHERE Ent_Num IN (
		SELECT Ent_Num FROM oc_SDN A WHERE CHARINDEX(@Name1,A.SDN_Name) >0 
		UNION 
		SELECT Ent_Num FROM oc_SDN A WHERE CHARINDEX(@Name2,A.SDN_Name) >0 
		UNION 
		SELECT Ent_Num FROM oc_SDN A WHERE CHARINDEX(@Name3,A.SDN_Name) >0 
		UNION 
		SELECT Ent_Num FROM oc_SDN A WHERE CHARINDEX(@Name4,A.SDN_Name) >0 
		)
		OR 
		Ent_Num IN ( 
		SELECT Ent_Num FROM oc_Aliases A WHERE CHARINDEX(@Name1,A.SDN_Name) >0 
		UNION 
		SELECT Ent_Num FROM oc_Aliases A WHERE CHARINDEX(@Name2,A.SDN_Name) >0 
		UNION 
		SELECT Ent_Num FROM oc_Aliases A WHERE CHARINDEX(@Name3,A.SDN_Name) >0 
		UNION 
		SELECT Ent_Num FROM oc_Aliases A WHERE CHARINDEX(@Name4,A.SDN_Name) >0 
		
		)
	END
	ELSE
	BEGIN
	INSERT INTO #SearchNames (Names) SELECT @Name1
	UNION SELECT @Name2
	UNION SELECT @Name3
	UNION SELECT @Name4
	DELETE FROM #SearchNames WHERE LEN(Names) = 0 
	SELECT * FROM oc_SDN 
	WHERE Ent_Num IN (
		SELECT Ent_Num FROM oc_SDN A INNER JOIN #SearchNames B ON A.SDN_Name = B.Names 
	)
	OR Ent_Num IN ( 
		SELECT Ent_Num FROM oc_Aliases A INNER JOIN #SearchNames B ON A.Alt_Name = B.Names 
	)
END
 
SET @counter = @counter +1
SELECT      'Return Value' = @return_value
END
 
GO

Open in new window

0
 

Author Comment

by:byte1
ID: 24754377
About the indexing , I was not able to create a - SDN_Name INCLUDE (Ent_Num ), but it did work the other way around, where Ent_Num was the index and SDN_Name was in the Included columns.

Ent_num int
SDN_Name nvarchar(max)


Error:
Column 'SDN_Name' in table 'dbo.oc_SDN' is of a type that is invalid for use as a key column in an index. (Microsoft SQL Server, Error: 1919)
0
 

Author Comment

by:byte1
ID: 24754573
Update :
I changed the SDN_Name datatype to nvarchar(150) which allowed me to create an index as specified.
0
 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 24755307
Is it faster ?
0
 

Author Comment

by:byte1
ID: 24773207
It did improve my search time. Thanks. But I wish i could do more improvements.
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I've encountered valid database schemas that do not have a primary key.  For example, I use LogParser from Microsoft to push IIS logs into a SQL database table for processing and analysis.  However, occasionally due to user error or a scheduled task…
INTRODUCTION: While tying your database objects into builds and your enterprise source control system takes a third-party product (like Visual Studio Database Edition or Red-Gate's SQL Source Control), you can achieve some protection using a sing…
In this video, viewers are given an introduction to using the Windows 10 Snipping Tool, how to quickly locate it when it's needed and also how make it always available with a single click of a mouse button, by pinning it to the Desktop Task Bar. Int…
Monitoring a network: why having a policy is the best policy? Michael Kulchisky, MCSE, MCSA, MCP, VTSP, VSP, CCSP outlines the enormous benefits of having a policy-based approach when monitoring medium and large networks. Software utilized in this v…

617 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question