Batch file scripting

Hi experts,

I'm trying to write a batch file for sourcing sql files into mysql.
My problem is in the execution of the for loops, it seems to not like external variables set in the batch file.

Below is the exact code i'm using for my batches

The batch is executed from command line

install world characters realmd

upon execution, the first call source runs fine.

When getting to the 1st loop, it fails out
'dbsource_pathsql'

what am i missing?

Code For 'install.bat'
@echo off
cls
 
REM Command line parameters: %1 = world db name, %2 = characters db name , %3 = realmd db name
 
Echo Installing Character Database ...
set db=%2
set source_path=.\tc2\sql
call source %db% %source_path%\characters.sql
 
Echo Installing Character Updates...
set source_path=.\tc2\sql\updates
for %sql in (4105_8030_01_characters_character_spell.sql 4105_8030_02_characters_character_action.sql 4209_characters_TDB.sql 4292_8072_01_characters_characters.sql 4292_8072_02_characters_characters.sql 4346_8098_characters.sql 4351_8104_01_characters.sql) do call source %db% %source_path%\%sql
 
Echo Installing RealmD Database
set source_path=.\tc2\sql
set db=%3
call source %db% %source_path%\realmd.sql
 
rem Echo Installing RealmD Updates...
rem set source_path=.\tc2\sql\updates
rem for %sql in () do call source %db% %source_path%\%sql
 
Echo Installing World Database...
set source_path=.\UDB\trunk\full_db
set db=%1
call source %db% %source_path%\UDB_0.11.5_Core_7681_SD2_1012.sql
 
Echo Installing World Update Packs...
set source_path=.\UDB\trunk\Updates\0.11.5_additions
for %sql in (380_corepatch_mangos_7682_to_7894.sql 380_updatepack_mangos.sql 381_corepatch_mangos_7895_to_8029.sql 381_updatepack_mangos.sql) DO call source %db% %source_path%\%sql
 
Echo Installing World Converter...
set source_path=.\DB\trunk\udb_to_tdb_converter
call source %db% %source_path%\UDB_381_to_TDB_TC2_4067_Converter.sql
 
Echo Installing World Strings...
set source_path=.\tc2\sql\full\
for %sql in (trinityscript_script_texts.sql world_script_waypoints.sql world_scripts_full.sql world_spell_full.sql) DO call source %db% %source_path%\%sql
 
Echo Installing World Updates...
set source_path=.\tc2\sql\updates
for %sql in (4081_world.sql 4105_8030_03_mangos_npc_trainer.sql 4115_world_sd2.sql 4154_world_script.sql 4159_world.sql 4174_world_script.sql 4176_world.sql 4209_world_TDB.sql 4211_world.sql 4216_world.sql 4217_world_spell_proc_event.sql 4222_world.sql 4225_world.sql 4233_world_spell_proc_event.sql 4234_world_spell_bonus_data_TDB.sql 4246_world_script.sql 4258_world_TDB.sql 4276_world_TDB.sql 4283_world_TDB.sql 4307_world_TDB.sql 4308_world_TDB.sql 4320_world_.sql 4321_world.sql 4346_8098_world.sql 4352_spell_bonus_data_full.sql) DO call source %db% %source_path%\%sql
 
Echo Done sourcing!
Echo Showing Errors...
type error_log.txt
pause
 
Code for 'source.bat'
@echo off
echo Sourcing %2
mysql -u<mylogin> -p<mypassword> -h192.168.1.105 %1 < %2 >> error_log.txt 2>&1

Open in new window

LVL 1
sgaggerjAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

sgaggerjAuthor Commented:
I think i found the answer....
using %sql seemed to be the problem (even %%sql).
I changed it to %%g and it's working.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Steve KnightIT ConsultancyCommented:
Yes it has to be one letter as you found... watch out as it is case sensitive too so %%a is diferent to %%b ... it might be neater to put the list of .sql files in a text file and read them with a for /f loop too as you could run into command line length issues with long lines too... ask if more info. needed .

Steve
0
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
Yes, as a FOR variable you only can use a single letter, and upper/lower case is honoured. This is because of the special treatment FOR variables get. A normal environment variable can have longer name, and case is ignored.
0
sgaggerjAuthor Commented:
@dragon-it

yea, I was thinking about moving them to a separate file, temporarily i pulled them all out of the command and used a set file_list= .... instead and then for %%g in (%file_list%).....
i might still do that

@both, thanks for the comments!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft DOS

From novice to tech pro — start learning today.