Batch file scripting

Posted on 2009-07-02
Medium Priority
Last Modified: 2012-05-07
Hi experts,

I'm trying to write a batch file for sourcing sql files into mysql.
My problem is in the execution of the for loops, it seems to not like external variables set in the batch file.

Below is the exact code i'm using for my batches

The batch is executed from command line

install world characters realmd

upon execution, the first call source runs fine.

When getting to the 1st loop, it fails out

what am i missing?

Code For 'install.bat'
@echo off
REM Command line parameters: %1 = world db name, %2 = characters db name , %3 = realmd db name
Echo Installing Character Database ...
set db=%2
set source_path=.\tc2\sql
call source %db% %source_path%\characters.sql
Echo Installing Character Updates...
set source_path=.\tc2\sql\updates
for %sql in (4105_8030_01_characters_character_spell.sql 4105_8030_02_characters_character_action.sql 4209_characters_TDB.sql 4292_8072_01_characters_characters.sql 4292_8072_02_characters_characters.sql 4346_8098_characters.sql 4351_8104_01_characters.sql) do call source %db% %source_path%\%sql
Echo Installing RealmD Database
set source_path=.\tc2\sql
set db=%3
call source %db% %source_path%\realmd.sql
rem Echo Installing RealmD Updates...
rem set source_path=.\tc2\sql\updates
rem for %sql in () do call source %db% %source_path%\%sql
Echo Installing World Database...
set source_path=.\UDB\trunk\full_db
set db=%1
call source %db% %source_path%\UDB_0.11.5_Core_7681_SD2_1012.sql
Echo Installing World Update Packs...
set source_path=.\UDB\trunk\Updates\0.11.5_additions
for %sql in (380_corepatch_mangos_7682_to_7894.sql 380_updatepack_mangos.sql 381_corepatch_mangos_7895_to_8029.sql 381_updatepack_mangos.sql) DO call source %db% %source_path%\%sql
Echo Installing World Converter...
set source_path=.\DB\trunk\udb_to_tdb_converter
call source %db% %source_path%\UDB_381_to_TDB_TC2_4067_Converter.sql
Echo Installing World Strings...
set source_path=.\tc2\sql\full\
for %sql in (trinityscript_script_texts.sql world_script_waypoints.sql world_scripts_full.sql world_spell_full.sql) DO call source %db% %source_path%\%sql
Echo Installing World Updates...
set source_path=.\tc2\sql\updates
for %sql in (4081_world.sql 4105_8030_03_mangos_npc_trainer.sql 4115_world_sd2.sql 4154_world_script.sql 4159_world.sql 4174_world_script.sql 4176_world.sql 4209_world_TDB.sql 4211_world.sql 4216_world.sql 4217_world_spell_proc_event.sql 4222_world.sql 4225_world.sql 4233_world_spell_proc_event.sql 4234_world_spell_bonus_data_TDB.sql 4246_world_script.sql 4258_world_TDB.sql 4276_world_TDB.sql 4283_world_TDB.sql 4307_world_TDB.sql 4308_world_TDB.sql 4320_world_.sql 4321_world.sql 4346_8098_world.sql 4352_spell_bonus_data_full.sql) DO call source %db% %source_path%\%sql
Echo Done sourcing!
Echo Showing Errors...
type error_log.txt
Code for 'source.bat'
@echo off
echo Sourcing %2
mysql -u<mylogin> -p<mypassword> -h192.168.1.105 %1 < %2 >> error_log.txt 2>&1

Open in new window

Question by:sgaggerj
  • 2

Accepted Solution

sgaggerj earned 0 total points
ID: 24764503
I think i found the answer....
using %sql seemed to be the problem (even %%sql).
I changed it to %%g and it's working.
LVL 43

Expert Comment

by:Steve Knight
ID: 24764915
Yes it has to be one letter as you found... watch out as it is case sensitive too so %%a is diferent to %%b ... it might be neater to put the list of .sql files in a text file and read them with a for /f loop too as you could run into command line length issues with long lines too... ask if more info. needed .

LVL 72

Expert Comment

ID: 24764926
Yes, as a FOR variable you only can use a single letter, and upper/lower case is honoured. This is because of the special treatment FOR variables get. A normal environment variable can have longer name, and case is ignored.

Author Comment

ID: 24822880

yea, I was thinking about moving them to a separate file, temporarily i pulled them all out of the command and used a set file_list= .... instead and then for %%g in (%file_list%).....
i might still do that

@both, thanks for the comments!

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Using dates in 'DOS' batch files has always been tricky as it has no built in ways of extracting date information.  There are many tricks using string manipulation to pull out parts of the %date% variable or output of the date /t command but these r…
VALIDATING DATES One method of validating dates is to jam the date into the DATE command and see if it accepts it by examining the system's errorlevel value. A non-zero result indicates failure. A typical example might look something like the fol…
Planning to migrate your EDB file(s) to a new or an existing Outlook PST file? This video will guide you how to convert EDB file(s) to PST. Besides this, it also describes, how one can easily search any item(s) from multiple folders or mailboxes…
From store locators to asset tracking and route optimization, learn how leading companies are using Google Maps APIs throughout the customer journey to increase checkout conversions, boost user engagement, and optimize order fulfillment. Powered …
Suggested Courses

600 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question