Solved

T-SQL: Making an ugly query better

Posted on 2009-07-02
4
306 Views
Last Modified: 2012-06-27
I can usually get by when it comes to SQL, but I'm no whiz. In the example I've included, the task is to end up with a list of:

* all search records that match the user's search criterion (lastname starts with T), OR
* that have email addresses matching records in the first group.

I have a query that seems (after minimal testing) to work. First I get the name matches; then supplement my results with the matching non-blank emails; then, for cases of multiple identical emails, I show only the record with the best (lowest) Priority score.

My question is: is there a more concise way to rephrase this query? (I don't have the option to restructure the database.) Something that left me with about three less WITH's -- i.e., a lone query -- would be ideal, but any improvement would be good.

WITH
NarrowedTable AS
(select id, email from tmp_test
where (lastname like 't%')),
 
ExtraEmailsTable AS
(select id from NarrowedTable
union
select id from tmp_test tt
where (coalesce(tt.email, '') > '')
and (tt.email in (select email from narrowedtable))),
 
InnerTable AS(
SELECT row_number() over(partition by email order by priority) as myrank,
id,
email,
lastname
from tmp_test tt
where (coalesce(Email, '') > '')
and (tt.id in (select id from ExtraEmailsTable))
union
SELECT 1 as myrank,
id,
email,
lastname
from tmp_test tt
where (coalesce(Email, '') = '')
and (tt.id in (select id from ExtraEmailsTable)))
 
select * from InnerTable
where myrank = 1
order by Email, lastname;

Open in new window

0
Comment
Question by:180246
4 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 167 total points
ID: 24768276
seems fine to me, except to put some comments into the code, and to use UNION ALL instead of UNION to avoid the implicit Distinct...
0
 
LVL 26

Assisted Solution

by:Chris Luttrell
Chris Luttrell earned 167 total points
ID: 24768432
I agree with angelIII that it seems fine logically.  Getting rid of some of your CTE "withs" will add to the complexity of the final query by having to do extra subselects or joins there so that is matter of oppion if that is a "better" query or not.  If something in the query is not performing right or too slow then if you share some table structure and sample data that is causing a problem we could evaluate it better.
0
 
LVL 15

Assisted Solution

by:rob_farley
rob_farley earned 166 total points
ID: 24769095
The WITHs are good - they modularise your query nicely.

As the others say, there are other ways to improve the query, but you should embrace the WITH. I've helped many complex queries by introduce a bunch of CTEs.

Rob
0
 

Author Closing Comment

by:180246
ID: 31599388
Thank you all for the feedback! It's good to know I wasn't too far out in left field. I'm not aware of any performance problems with it at this point -- just figured that since I was using some features I haven't touched before, I should get a sanity check. I hope an even split of points (as even as I could make it) will be OK with you all.
0

Featured Post

Complete VMware vSphere® ESX(i) & Hyper-V Backup

Capture your entire system, including the host, with patented disk imaging integrated with VMware VADP / Microsoft VSS and RCT. RTOs is as low as 15 seconds with Acronis Active Restore™. You can enjoy unlimited P2V/V2V migrations from any source (even from a different hypervisor)

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

How to use Variables  and Custom code in SSRS report and Assembly reference to use compile shared code in SSRS. Its big question for all who are working with SSRS. It is easy to create assembly and refer in SSRS report, still there are some steps…
In this article we will get to know that how can we recover deleted data if it happens accidently. We really can recover deleted rows if we know the time when data is deleted by using the transaction log.
Established in 1997, Technology Architects has become one of the most reputable technology solutions companies in the country. TA have been providing businesses with cost effective state-of-the-art solutions and unparalleled service that is designed…
I've attached the XLSM Excel spreadsheet I used in the video and also text files containing the macros used below. https://filedb.experts-exchange.com/incoming/2017/03_w12/1151775/Permutations.txt https://filedb.experts-exchange.com/incoming/201…

856 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question