Solved

How to use mysql_num_rows to check if username has been used?

Posted on 2009-07-03
3
683 Views
Last Modified: 2012-05-07
I think I'm missing something simple on the code below, but I can't find the problem.  This is for a registration form and I'm just trying to query the table (users) and see if the username has already been used.  If the username has already been taken then tell the user, if the username hasn't been taken register the user.  What am I missing here?
// check the username and make sure it hasn't been taken
$result = mysql_query ("SELECT username from users WHERE username = '$new_user_name'");
$num_rows = mysql_num_rows($result);
 
if ($num_rows = '1') {
	echo "That username is already in use, please select another username! <a href='add_user.php'>Try Again</a>";
}
if ($num_rows = '0') {
		 mysql_query ("INSERT INTO users (first_name, last_name, username, password, email, state_id, state)
		 VALUES ('$first_name', '$last_name', '$user_name', '$encrypted_password', '$email', '$state_id', '$state_name')");	
         echo 'Good news, the user was added!';
      }

Open in new window

0
Comment
Question by:jbpeake
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
3 Comments
 
LVL 11

Expert Comment

by:BrianMM
ID: 24772787
Is it doing anything?

try:
// check the username and make sure it hasn't been taken
$result = mysql_query ("SELECT username from users WHERE username = '$new_user_name'");
 
if($result) {
	if(mysql_num_rows($result) > 0) {
		echo "That username is already in use, please select another username! <a href='add_user.php'>Try Again</a>";
	} else {
		// Insert...
		mysql_query ("INSERT INTO users (first_name, last_name, username, password, email, state_id, state)
                 VALUES ('$first_name', '$last_name', '$user_name', '$encrypted_password', '$email', '$state_id', '$state_name')");     
		echo 'Good news, the user was added!';
	}
} else {
	echo "Sorry problem with query:".mysql_error();
}

Open in new window

0
 
LVL 5

Accepted Solution

by:
Opalelement earned 500 total points
ID: 24772811
I would agree with the "if($var > 0) else" method, as it means there will always be a Yes or No result, even if there happens to be more than 1.

However, in your code I am guessing you always got both?

The problem is with these:
if ($num_rows = '1')
if ($num_rows = '0')

You need another = sign in both of those, like this:
if ($num_rows == '1')
if ($num_rows == '0')

From http://www.php5-tutorial.com/basics/if-statements/
As you can see, we are using two equal signs after each other - why is that? In PHP, and in many other programming languages, a single equal sign is an assignment operator. It's used to assign a value to e.g. a variable. Two equal signs are a comparison operator, that is, it's used to compare two values. So, in this case, we use two equal signs to compare the two items: $number and 42. Had we only used one equal sign, 42 would be assigned to $number, and no comparison would have been made.
0
 
LVL 11

Expert Comment

by:BrianMM
ID: 24772847
yes... that is correct also... should have spotted that in original code :)

General practice of using if(mysql_num_rows($result) > 0) is 'safer' incase for any reason there is more than one.
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Nothing in an HTTP request can be trusted, including HTTP headers and form data.  A form token is a tool that can be used to guard against request forgeries (CSRF).  This article shows an improved approach to form tokens, making it more difficult to…
This post looks at MongoDB and MySQL, and covers high-level MongoDB strengths, weaknesses, features, and uses from the perspective of an SQL user.
The viewer will learn how to count occurrences of each item in an array.
In this seventh video of the Xpdf series, we discuss and demonstrate the PDFfonts utility, which lists all the fonts used in a PDF file. It does this via a command line interface, making it suitable for use in programs, scripts, batch files — any pl…

695 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question