We help IT Professionals succeed at work.

Check out our new AWS podcast with Certified Expert, Phil Phillips! Listen to "How to Execute a Seamless AWS Migration" on EE or on your favorite podcast platform. Listen Now

x

Radio button not working properly in Internet explorer to show content on checked

Medium Priority
1,009 Views
Last Modified: 2013-12-13
This question  is an extension on a previous question I posted. I have a form with 2 radio buttons that when one is clicked a dropdown is visible and when the other is checked is it not visible.

In firefox this works perfect. In internet explorer it only works when the text next to the radio button is clicked and not when the actual button is checked.

Please tell me what I did wrong.
<script type="text/javascript">
                var prepMenu = function() {
                        var optionNumberThatShowsMenu = 0; //or whichever radio it is, in this case #0
                        
                        var a = document.forms['cart'].options[optionNumberThatShowsMenu];
                        var m = document.forms['cart'].more
                        m.style.display = ( (a.checked === false) ? 'inline' : 'none' );
                }
                
               var loadRadios = function() {
                        for ( var i = 0; i < document.forms['cart'].options.length; i++ ) {
                                var a = document.forms['cart'].options[i];
                                //set up events
                                a.onchange = prepMenu;
                        }
                        //make menu initially visible (or invisible if that's what you want)
                        prepMenu();
                }
        </script>   
 <form action="<?php echo ($_SERVER["PHP_SELF"].(isset($_SERVER["QUERY_STRING"])?"?".htmlentities($_SERVER["QUERY_STRING"]):""));?>" method="post" id="cart" name="cart">
 
 <table width="500" border="0">
                <tr>
                  <td width="236" height="56" align="left" valign="top">
                 Ship Product<input name="options" type="radio" value="B" checked/></td>
				<td width="221" align="left" valign="top"> Pick up from store<input name="options" type="radio" value="0"  />
 
                    </td>
                  <td width="152" align="left" valign="top">
                      <label>
                        <select name="more" id="more">
                          <option>Choose a location</option>
                          <option value="Agoura Hills">Agoura Hills</option>
                          <option value="Canyon Country">Canyon Country</option>
                          <option value="Chatsworth">Chatsworth</option>
                          <option value="Glendale">Glendale</option>
                          <option value="Moorpark">Moorpark</option>
                          <option value="Oxnard">Oxnard</option>
                          <option value="Santa Barbara">Santa Barbara</option>
                          </select>
                        </label>
</td>
                  </tr>
  </table>
</form>

Open in new window

Comment
Watch Question

Commented:
Browsers execute code sequentially, so in your case when you search for the form before the form tag it's impossible for the javascript to find it. Just put your javascript after the form tag.

 <form action="" method="post" id="cart" name="cart">
 
 <table width="500" border="0">
                <tr>
                  <td width="236" height="56" align="left" valign="top">
                 Ship Product<input name="options" type="radio" value="B" checked/></td>
                                <td width="221" align="left" valign="top"> Pick up from store<input name="options" type="radio" value="0"  />
 
                    </td>
                  <td width="152" align="left" valign="top">
                      <label>
                        <select name="more" id="more">
                          <option>Choose a location</option>
                          <option value="Agoura Hills">Agoura Hills</option>
                          <option value="Canyon Country">Canyon Country</option>
                          <option value="Chatsworth">Chatsworth</option>
                          <option value="Glendale">Glendale</option>
                          <option value="Moorpark">Moorpark</option>
                          <option value="Oxnard">Oxnard</option>
                          <option value="Santa Barbara">Santa Barbara</option>
                          </select>
                        </label>
</td>
                  </tr>
  </table>
</form>
 
<script type="text/javascript">
                var prepMenu = function() {
                        var optionNumberThatShowsMenu = 0; //or whichever radio it is, in this case #0
                        
                        var a = document.forms['cart'].options[optionNumberThatShowsMenu];
                        var m = document.forms['cart'].more
                        m.style.display = ( (a.checked === false) ? 'inline' : 'none' );
                }
                
               var loadRadios = function() {
                        for ( var i = 0; i < document.forms['cart'].options.length; i++ ) {
                                var a = document.forms['cart'].options[i];
                                //set up events
                                a.onchange = prepMenu;
                        }
                        //make menu initially visible (or invisible if that's what you want)
                        prepMenu();
                }
                loadRadios();
        </script>   

Open in new window

CERTIFIED EXPERT
Commented:
Unlock this solution and get a sample of our free trial.
(No credit card required)
UNLOCK SOLUTION
CERTIFIED EXPERT

Commented:
Mokona, you missed his question. The problem is with clicking on the radio button itself doesn't trigger the event. Using element ids and label tag is a better way to go, I reckon :)
CERTIFIED EXPERT

Commented:
The fact (for this case) that the script can be loaded before or after, it doesn't matter as it doesn't get called while the page is loading. The function is only called when user click on the radios.

Commented:
I simply corrected his code and has i posted it works fine, but is true that your's is cleaner.

Author

Commented:
thank you so much. That is much better!
CERTIFIED EXPERT

Commented:
Hi Mokona,

You missed it again. He meant it doesn't work in IE. I tested yours in IE before letting you know though.

Cheers,
Tien
Unlock the solution to this question.
Thanks for using Experts Exchange.

Please provide your email to receive a sample view!

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.