Solved

Radio button not working properly in Internet explorer to show content on checked

Posted on 2009-07-06
7
970 Views
Last Modified: 2013-12-13
This question  is an extension on a previous question I posted. I have a form with 2 radio buttons that when one is clicked a dropdown is visible and when the other is checked is it not visible.

In firefox this works perfect. In internet explorer it only works when the text next to the radio button is clicked and not when the actual button is checked.

Please tell me what I did wrong.
<script type="text/javascript">

                var prepMenu = function() {

                        var optionNumberThatShowsMenu = 0; //or whichever radio it is, in this case #0

                        

                        var a = document.forms['cart'].options[optionNumberThatShowsMenu];

                        var m = document.forms['cart'].more

                        m.style.display = ( (a.checked === false) ? 'inline' : 'none' );

                }

                

               var loadRadios = function() {

                        for ( var i = 0; i < document.forms['cart'].options.length; i++ ) {

                                var a = document.forms['cart'].options[i];

                                //set up events

                                a.onchange = prepMenu;

                        }

                        //make menu initially visible (or invisible if that's what you want)

                        prepMenu();

                }

        </script>   

 <form action="<?php echo ($_SERVER["PHP_SELF"].(isset($_SERVER["QUERY_STRING"])?"?".htmlentities($_SERVER["QUERY_STRING"]):""));?>" method="post" id="cart" name="cart">

 

 <table width="500" border="0">

                <tr>

                  <td width="236" height="56" align="left" valign="top">

                 Ship Product<input name="options" type="radio" value="B" checked/></td>

				<td width="221" align="left" valign="top"> Pick up from store<input name="options" type="radio" value="0"  />
 

                    </td>

                  <td width="152" align="left" valign="top">

                      <label>

                        <select name="more" id="more">

                          <option>Choose a location</option>

                          <option value="Agoura Hills">Agoura Hills</option>

                          <option value="Canyon Country">Canyon Country</option>

                          <option value="Chatsworth">Chatsworth</option>

                          <option value="Glendale">Glendale</option>

                          <option value="Moorpark">Moorpark</option>

                          <option value="Oxnard">Oxnard</option>

                          <option value="Santa Barbara">Santa Barbara</option>

                          </select>

                        </label>

</td>

                  </tr>

  </table>

</form>

Open in new window

0
Comment
Question by:danjen
  • 4
  • 2
7 Comments
 
LVL 1

Expert Comment

by:Mokona
Comment Utility
Browsers execute code sequentially, so in your case when you search for the form before the form tag it's impossible for the javascript to find it. Just put your javascript after the form tag.


 <form action="" method="post" id="cart" name="cart">

 

 <table width="500" border="0">

                <tr>

                  <td width="236" height="56" align="left" valign="top">

                 Ship Product<input name="options" type="radio" value="B" checked/></td>

                                <td width="221" align="left" valign="top"> Pick up from store<input name="options" type="radio" value="0"  />

 

                    </td>

                  <td width="152" align="left" valign="top">

                      <label>

                        <select name="more" id="more">

                          <option>Choose a location</option>

                          <option value="Agoura Hills">Agoura Hills</option>

                          <option value="Canyon Country">Canyon Country</option>

                          <option value="Chatsworth">Chatsworth</option>

                          <option value="Glendale">Glendale</option>

                          <option value="Moorpark">Moorpark</option>

                          <option value="Oxnard">Oxnard</option>

                          <option value="Santa Barbara">Santa Barbara</option>

                          </select>

                        </label>

</td>

                  </tr>

  </table>

</form>
 

<script type="text/javascript">

                var prepMenu = function() {

                        var optionNumberThatShowsMenu = 0; //or whichever radio it is, in this case #0

                        

                        var a = document.forms['cart'].options[optionNumberThatShowsMenu];

                        var m = document.forms['cart'].more

                        m.style.display = ( (a.checked === false) ? 'inline' : 'none' );

                }

                

               var loadRadios = function() {

                        for ( var i = 0; i < document.forms['cart'].options.length; i++ ) {

                                var a = document.forms['cart'].options[i];

                                //set up events

                                a.onchange = prepMenu;

                        }

                        //make menu initially visible (or invisible if that's what you want)

                        prepMenu();

                }

                loadRadios();

        </script>   

Open in new window

0
 
LVL 6

Accepted Solution

by:
coolersport earned 500 total points
Comment Utility
A much simpler solution (Tested in IE7, IE6, Firefox):

<form action="" method="post" id="cart" name="cart">

 

 <table width="500" border="0">

                <tr>

                  <td width="236" height="56" align="left" valign="top">

                 <label for="shipping">Ship Product</label><input name="options" type="radio" value="B" checked id="shipping" onclick="toggleDropdown();"/></td>

                                <td width="221" align="left" valign="top"> <label for="pickup">Pick up from store</label><input name="options" type="radio" value="0" id="pickup" onclick="toggleDropdown();" />

 

                    </td>

                  <td width="152" align="left" valign="top">

                      <label>

                        <select name="more" id="more" style="display:none">

                          <option>Choose a location</option>

                          <option value="Agoura Hills">Agoura Hills</option>

                          <option value="Canyon Country">Canyon Country</option>

                          <option value="Chatsworth">Chatsworth</option>

                          <option value="Glendale">Glendale</option>

                          <option value="Moorpark">Moorpark</option>

                          <option value="Oxnard">Oxnard</option>

                          <option value="Santa Barbara">Santa Barbara</option>

                          </select>

                        </label>

</td>

                  </tr>

  </table>

   <script type="text/javascript">

               var toggleDropdown = function() {

					document.getElementById('more').style.display = document.getElementById('pickup').checked ? 'block' : 'none';

                };

        </script>   

</form>

Open in new window

0
 
LVL 6

Expert Comment

by:coolersport
Comment Utility
Mokona, you missed his question. The problem is with clicking on the radio button itself doesn't trigger the event. Using element ids and label tag is a better way to go, I reckon :)
0
Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

 
LVL 6

Expert Comment

by:coolersport
Comment Utility
The fact (for this case) that the script can be loaded before or after, it doesn't matter as it doesn't get called while the page is loading. The function is only called when user click on the radios.
0
 
LVL 1

Expert Comment

by:Mokona
Comment Utility
I simply corrected his code and has i posted it works fine, but is true that your's is cleaner.
0
 

Author Closing Comment

by:danjen
Comment Utility
thank you so much. That is much better!
0
 
LVL 6

Expert Comment

by:coolersport
Comment Utility
Hi Mokona,

You missed it again. He meant it doesn't work in IE. I tested yours in IE before letting you know though.

Cheers,
Tien
0

Featured Post

6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

Join & Write a Comment

These days socially coordinated efforts have turned into a critical requirement for enterprises.
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
The purpose of this video is to demonstrate how to update a WordPress Site’s version. WordPress releases new versions of its software frequently and it is important to update frequently in order to keep your site secure, and to get new WordPress…
The viewer will learn how to create and use a small PHP class to apply a watermark to an image. This video shows the viewer the setup for the PHP watermark as well as important coding language. Continue to Part 2 to learn the core code used in creat…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

8 Experts available now in Live!

Get 1:1 Help Now