Solved

Problem while iterate in Two loops

Posted on 2009-07-06
9
191 Views
Last Modified: 2012-05-07
hi all,
         in reference to my earlier post,  your comment "
         Additionally u can pass all ids as a string to the above qery and take the output in a Map and then iterate in a single loop. "
        Can you please let me know how can i do that ?

Awaiting your expert comment...
0
Comment
Question by:NASEEMA
  • 5
  • 4
9 Comments
 
LVL 13

Expert Comment

by:Murali Murugesan
ID: 24791991
Something like this,

your value in variable tprID and seq_nr should be like this,

tprID : 'MN4676','4567TR','TU36363'
seq_nr: '2','4','6'  -- (i guess values should be unique since sequence number)

public Map getLogCounter(String tprID,String seq_nr) {
                                    Map counterMap = new HashMap();
                                     String sql="SELECT opn_seq_nr,COUNT(*)"
                                                       +" FROM   log"
                                                       +" WHERE  opn_id IN ("+tprID
                                                       +") AND opn_flag ='TPR'"
                                                       +" AND opn_seq_nr IN ("+seq_nr
                                                         +") AND upd_flag  IS NULL GROUP BY opn_seq_nr ";      
                               //PreparedStatement - implement this
                                         //resultset - implement this

                                   while(rs.next()){
                                          counterMap .put(rs.getString(1),rs.getInt(2));
                                    }      
                              return counterMap ;                              
                              }


Map values after iteration should look like below,

2  20
4  60
6  90


Now get the map values and get the count for each sequence number and iterate the second loop.

-Murali*

0
 

Author Comment

by:NASEEMA
ID: 24796926
Hi,
  Sorry for ver late reply.
   seq_nr is not unique. and i feel i couldnt be able to implement code.is  There any other possibilty in achieve my task
 
0
 

Author Comment

by:NASEEMA
ID: 24800760
HI All,
        Any other possibility in achieve my task..


0
VMware Disaster Recovery and Data Protection

In this expert guide, you’ll learn about the components of a Modern Data Center. You will use cases for the value-added capabilities of Veeam®, including combining backup and replication for VMware disaster recovery and using replication for data center migration.

 
LVL 13

Expert Comment

by:Murali Murugesan
ID: 24800913
is your tprID is unique? If not then replace the select as follows,

SELECT opn_seq_nr || '~' ||opn_id,COUNT(*)

Now a combination of sequence and tprID  will be unique. Now u can implement the above code.

Even if this combination is not unique i would suggest u to use a bean class object (i hope u already have one) as the value and key for the map as some unique running number.

I feel this code would reduce you most of the delay and also we need to see if we can refactor the next loop as well once u implement this.

-Murali*
0
 
LVL 13

Expert Comment

by:Murali Murugesan
ID: 24810777
did u try to implement this function ? or still facing problem in implementing it?
0
 

Author Comment

by:NASEEMA
ID: 24810960
Hi,
   i  couldnt be able to implemnt your last input.
  i appreciate if you can write the whole code so that i will copy and paste the code .
  sorry that i am asking u to write the code.

0
 
LVL 13

Accepted Solution

by:
Murali Murugesan earned 500 total points
ID: 24811012
I think its a very simple implementation. Here you go,


                   public Map getLogCounter(String tprID,String seq_nr) {
                                    Map counterMap = new HashMap();
                                     String sql="SELECT opn_seq_nr || '~' ||opn_id,COUNT(*)"
                                                       +" FROM   log"
                                                       +" WHERE  opn_id IN ("+tprID
                                                       +") AND opn_flag ='TPR'"
                                                       +" AND opn_seq_nr IN ("+seq_nr
                                                         +") AND upd_flag  IS NULL GROUP BY opn_seq_nr ";      
                                       Connection conn = ConnectionManager.getConnection();
                                       PreparedStatement pstmt = null;
                                       ResultSet rs= null;

                                      try{
                                               pstmt = conn.prepareStatement(sql);
                                               rs = pstmt.executeQuery();
                                                while(rs.next()){
                                                        counterMap .put(rs.getString(1),rs.getInt(2));
                                                 }      
                                         }catch(Exception e){}
                                         finally{
                               try {
                        if (!conn.isClosed()) {
                              ConnectionManager.releaseConnection(conn);
                        }
                                 
                         } catch (SQLException e1) {
                        e1.printStackTrace();
                         }
                          }                                                                            
                              return counterMap ;                              
                              }

Now u will get a map with values as ,

2~MN4676   20
4~4567TR    60
6~TU36363  90


Now iterate the map and get the count and use it in the next loop, thereby first loop can go away.
Hope u will try and do the remaining part.

-Murali*

0
 

Author Comment

by:NASEEMA
ID: 24811069
HI,
  Thanks a lot for the help.i will accept ur comment .I appreciate if you can let me know the remaining code too....

sorry again to request to write code for me....:
0
 
LVL 13

Expert Comment

by:Murali Murugesan
ID: 24811271
Sorry Naseema, this time you need to give your best try and make up the code on your own.
You do the code and fix the bugs and if you are caught in somewhere we might guide you.

Out of the two for loops i have showed you how to minimize one loop. You get the count from this and iterate the next loop.

Thanx
-Murali*
0

Featured Post

Netscaler Common Configuration How To guides

If you use NetScaler you will want to see these guides. The NetScaler How To Guides show administrators how to get NetScaler up and configured by providing instructions for common scenarios and some not so common ones.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
How to group array of objects ? 5 65
mask rule in struts validation.xml 5 87
throw exception 21 44
null output 3 25
Do you use a spreadsheet like Microsoft's Excel?  Have you ever wanted to link out to a non excel file on your computer or network drive?  This is the way I found to do it!
This article outlines the process to identify and resolve account lockout in an Active Directory environment.
Two types of users will appreciate AOMEI Backupper Pro: 1 - Those with PCIe drives (and haven't found cloning software that works on them). 2 - Those who want a fast clone of their boot drive (no re-boots needed) and it can clone your drive wh…
This video shows how to use Hyena, from SystemTools Software, to bulk import 100 user accounts from an external text file. View in 1080p for best video quality.

770 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question