Solved

Problem while iterate in Two loops

Posted on 2009-07-06
9
187 Views
Last Modified: 2012-05-07
hi all,
         in reference to my earlier post,  your comment "
         Additionally u can pass all ids as a string to the above qery and take the output in a Map and then iterate in a single loop. "
        Can you please let me know how can i do that ?

Awaiting your expert comment...
0
Comment
Question by:NASEEMA
  • 5
  • 4
9 Comments
 
LVL 13

Expert Comment

by:Murali Murugesan
Comment Utility
Something like this,

your value in variable tprID and seq_nr should be like this,

tprID : 'MN4676','4567TR','TU36363'
seq_nr: '2','4','6'  -- (i guess values should be unique since sequence number)

public Map getLogCounter(String tprID,String seq_nr) {
                                    Map counterMap = new HashMap();
                                     String sql="SELECT opn_seq_nr,COUNT(*)"
                                                       +" FROM   log"
                                                       +" WHERE  opn_id IN ("+tprID
                                                       +") AND opn_flag ='TPR'"
                                                       +" AND opn_seq_nr IN ("+seq_nr
                                                         +") AND upd_flag  IS NULL GROUP BY opn_seq_nr ";      
                               //PreparedStatement - implement this
                                         //resultset - implement this

                                   while(rs.next()){
                                          counterMap .put(rs.getString(1),rs.getInt(2));
                                    }      
                              return counterMap ;                              
                              }


Map values after iteration should look like below,

2  20
4  60
6  90


Now get the map values and get the count for each sequence number and iterate the second loop.

-Murali*

0
 

Author Comment

by:NASEEMA
Comment Utility
Hi,
  Sorry for ver late reply.
   seq_nr is not unique. and i feel i couldnt be able to implement code.is  There any other possibilty in achieve my task
 
0
 

Author Comment

by:NASEEMA
Comment Utility
HI All,
        Any other possibility in achieve my task..


0
 
LVL 13

Expert Comment

by:Murali Murugesan
Comment Utility
is your tprID is unique? If not then replace the select as follows,

SELECT opn_seq_nr || '~' ||opn_id,COUNT(*)

Now a combination of sequence and tprID  will be unique. Now u can implement the above code.

Even if this combination is not unique i would suggest u to use a bean class object (i hope u already have one) as the value and key for the map as some unique running number.

I feel this code would reduce you most of the delay and also we need to see if we can refactor the next loop as well once u implement this.

-Murali*
0
How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

 
LVL 13

Expert Comment

by:Murali Murugesan
Comment Utility
did u try to implement this function ? or still facing problem in implementing it?
0
 

Author Comment

by:NASEEMA
Comment Utility
Hi,
   i  couldnt be able to implemnt your last input.
  i appreciate if you can write the whole code so that i will copy and paste the code .
  sorry that i am asking u to write the code.

0
 
LVL 13

Accepted Solution

by:
Murali Murugesan earned 500 total points
Comment Utility
I think its a very simple implementation. Here you go,


                   public Map getLogCounter(String tprID,String seq_nr) {
                                    Map counterMap = new HashMap();
                                     String sql="SELECT opn_seq_nr || '~' ||opn_id,COUNT(*)"
                                                       +" FROM   log"
                                                       +" WHERE  opn_id IN ("+tprID
                                                       +") AND opn_flag ='TPR'"
                                                       +" AND opn_seq_nr IN ("+seq_nr
                                                         +") AND upd_flag  IS NULL GROUP BY opn_seq_nr ";      
                                       Connection conn = ConnectionManager.getConnection();
                                       PreparedStatement pstmt = null;
                                       ResultSet rs= null;

                                      try{
                                               pstmt = conn.prepareStatement(sql);
                                               rs = pstmt.executeQuery();
                                                while(rs.next()){
                                                        counterMap .put(rs.getString(1),rs.getInt(2));
                                                 }      
                                         }catch(Exception e){}
                                         finally{
                               try {
                        if (!conn.isClosed()) {
                              ConnectionManager.releaseConnection(conn);
                        }
                                 
                         } catch (SQLException e1) {
                        e1.printStackTrace();
                         }
                          }                                                                            
                              return counterMap ;                              
                              }

Now u will get a map with values as ,

2~MN4676   20
4~4567TR    60
6~TU36363  90


Now iterate the map and get the count and use it in the next loop, thereby first loop can go away.
Hope u will try and do the remaining part.

-Murali*

0
 

Author Comment

by:NASEEMA
Comment Utility
HI,
  Thanks a lot for the help.i will accept ur comment .I appreciate if you can let me know the remaining code too....

sorry again to request to write code for me....:
0
 
LVL 13

Expert Comment

by:Murali Murugesan
Comment Utility
Sorry Naseema, this time you need to give your best try and make up the code on your own.
You do the code and fix the bugs and if you are caught in somewhere we might guide you.

Out of the two for loops i have showed you how to minimize one loop. You get the count from this and iterate the next loop.

Thanx
-Murali*
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

This article will show you how to create an ISO CD-ROM/DVD-ROM image (*.iso), and MD5 checksum signature, for use with VMware vSphere Hypervisor 6.5 (ESXi 6.5). It's a good idea to compare checksums, because many installations fail because of a corr…
This article explains how to prepare an HTML email signature template file containing dynamic placeholders for users' Azure AD data. Furthermore, it explains how to use this file to remotely set up a department-wide email signature policy in Office …
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

8 Experts available now in Live!

Get 1:1 Help Now