Losing $_GET variable inside if clause

Hi Experts!

the variable $_GET['subtask'] is not being posted to the database.

If I remove "isset($_POST['task'] from the if statement, it will work. But it has to be there.

Note that the other variables are being posted correctly to the database in both cases.

Thank you!
<? include 'inc/func.php'; ?>
<? include 'inc/dbc.php'; ?>
 
<? include 'inc/head.php'; ?>
 
<?
if(isset($_GET['subtask']) && isset($_POST['task'])){
	$q = "INSERT INTO tasks (task, parent_id, added) VALUES ('{$_POST['task']}', '{$_GET['subtask']}', NOW())";
	$r = mysql_query($q);
	redirect("index.php");    
}
?>
 
<? include 'inc/head.php'; ?>
 
<form action="new.php" method="post">
	<label>Task: </label><input name="task" id="task" type="text" />
    <br />
    <br />
    <input name="submit" id="submit" type="submit" value="Submit" />
</form>
 
<? include 'inc/foot.php'; ?>

Open in new window

LVL 2
AphXAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Kevin CrossChief Technology OfficerCommented:
Try it like this:
(as indicated in the other question, this may need to be $_GET['task'] as well)
<? include 'inc/func.php'; ?>
<? include 'inc/dbc.php'; ?>
 
<? include 'inc/head.php'; ?>
 
<?
if(isset($_GET['subtask']) && isset($_POST['task'])){
        $q = "INSERT INTO tasks (task, parent_id, added) VALUES ('".$_POST['task']."', '".$_GET['subtask']."', NOW())";
        $r = mysql_query($q);
        redirect("index.php");    
}
?>
 
<? include 'inc/head.php'; ?>
 
<form action="new.php" method="post">
        <label>Task: </label><input name="task" id="task" type="text" />
    <br />
    <br />
    <input name="submit" id="submit" type="submit" value="Submit" />
</form>
 
<? include 'inc/foot.php'; ?>

Open in new window

0
AphXAuthor Commented:
Hi and thanks for fast response!

It didn't work. I can´t even echo $_GET['subtask'] inside the if clause. The exact same echo works outside the if clause.

As I pointed out above: if I use this if statement instead, it works 100%

if(isset($_GET['subtask'])){

Something turns wrong when using $_POST['task'] in the if statement...
0
Kevin CrossChief Technology OfficerCommented:
Oh, yeah and you have to ensure that you are passing on the 'subtask' query parameter, either in the post URL or as another value along side task maybe with a hidden variable.

URL method:
<form action="new.php?<?php echo $_SERVER['QUERY_STRING']; ?>" method="post">

Hidden field method:
<input name="subtask" id="subtask" type="hidden" value="<?php echo $_GET['subtask'] ?>" />
(And then change the if to use $_POST['subtask'] instead)
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Amazon Web Services

Are you thinking about creating an Amazon Web Services account for your business? Not sure where to start? In this course you’ll get an overview of the history of AWS and take a tour of their user interface.

Kevin CrossChief Technology OfficerCommented:
Remember that the $_POST['task'] is only set after the form has been posted; therefore, you have to test that way.  Otherwise, the IF condition will fail as $_POST['task'] will not be set.
0
Cornelia YoderArtistCommented:
By the way, NEVER use $_GET or $_POST variables directly in a MySQL query!!   It leaves you wide open to SQL Injection hacking!

Always pass the inputs through a safety function such as mysql_real_escape_string().
0
AphXAuthor Commented:
Thank you!

Now I see!
0
Kevin CrossChief Technology OfficerCommented:
Great point, yodercm.  Same on me for not mentioning as I presented a security discussion on cross-site scripting (XSS) on the very subject.  Definitely a no no, especially going to a database as it becomes the gift that keeps on giving. ;)
0
Kevin CrossChief Technology OfficerCommented:
*Shame NOT same. :)
0
AphXAuthor Commented:
Thank you! :)
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
PHP

From novice to tech pro — start learning today.