Drastically shorten your training time with WalkMe's advanced online training solution that Guides your trainees to action. Forget about retraining and skyrocket knowledge retention rates.
Course Of The Month
8 days, left to enrollBecome a Premium Member and unlock a new, free course in leading technologies each month.
Solved
Losing $_GET variable inside if clause
Posted on 2009-07-08
Hi Experts!
the variable $_GET['subtask'] is not being posted to the database.
If I remove "isset($_POST['task'] from the if statement, it will work. But it has to be there.
Note that the other variables are being posted correctly to the database in both cases.
Thank you!
the variable $_GET['subtask'] is not being posted to the database.
If I remove "isset($_POST['task'] from the if statement, it will work. But it has to be there.
Note that the other variables are being posted correctly to the database in both cases.
Thank you!
<? include 'inc/func.php'; ?>
<? include 'inc/dbc.php'; ?>
<? include 'inc/head.php'; ?>
<?
if(isset($_GET['subtask']) && isset($_POST['task'])){
$q = "INSERT INTO tasks (task, parent_id, added) VALUES ('{$_POST['task']}', '{$_GET['subtask']}', NOW())";
$r = mysql_query($q);
redirect("index.php");
}
?>
<? include 'inc/head.php'; ?>
<form action="new.php" method="post">
<label>Task: </label><input name="task" id="task" type="text" />
<br />
<br />
<input name="submit" id="submit" type="submit" value="Submit" />
</form>
<? include 'inc/foot.php'; ?>
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
5-
3
9 Comments
Try it like this:
(as indicated in the other question, this may need to be $_GET['task'] as well)
(as indicated in the other question, this may need to be $_GET['task'] as well)
<? include 'inc/func.php'; ?>
<? include 'inc/dbc.php'; ?>
<? include 'inc/head.php'; ?>
<?
if(isset($_GET['subtask']) && isset($_POST['task'])){
$q = "INSERT INTO tasks (task, parent_id, added) VALUES ('".$_POST['task']."', '".$_GET['subtask']."', NOW())";
$r = mysql_query($q);
redirect("index.php");
}
?>
<? include 'inc/head.php'; ?>
<form action="new.php" method="post">
<label>Task: </label><input name="task" id="task" type="text" />
<br />
<br />
<input name="submit" id="submit" type="submit" value="Submit" />
</form>
<? include 'inc/foot.php'; ?>
Hi and thanks for fast response!
It didn't work. I can´t even echo $_GET['subtask'] inside the if clause. The exact same echo works outside the if clause.
As I pointed out above: if I use this if statement instead, it works 100%
if(isset($_GET['subtask'])
Something turns wrong when using $_POST['task'] in the if statement...
It didn't work. I can´t even echo $_GET['subtask'] inside the if clause. The exact same echo works outside the if clause.
As I pointed out above: if I use this if statement instead, it works 100%
if(isset($_GET['subtask'])
Something turns wrong when using $_POST['task'] in the if statement...
Oh, yeah and you have to ensure that you are passing on the 'subtask' query parameter, either in the post URL or as another value along side task maybe with a hidden variable.
URL method:
<form action="new.php?<?php echo $_SERVER['QUERY_STRING']; ?>" method="post">
Hidden field method:
<input name="subtask" id="subtask" type="hidden" value="<?php echo $_GET['subtask'] ?>" />
(And then change the if to use $_POST['subtask'] instead)
URL method:
<form action="new.php?<?php echo $_SERVER['QUERY_STRING']; ?>" method="post">
Hidden field method:
<input name="subtask" id="subtask" type="hidden" value="<?php echo $_GET['subtask'] ?>" />
(And then change the if to use $_POST['subtask'] instead)
Remember that the $_POST['task'] is only set after the form has been posted; therefore, you have to test that way. Otherwise, the IF condition will fail as $_POST['task'] will not be set.
By the way, NEVER use $_GET or $_POST variables directly in a MySQL query!! It leaves you wide open to SQL Injection hacking!
Always pass the inputs through a safety function such as mysql_real_escape_string()
Always pass the inputs through a safety function such as mysql_real_escape_string()
Great point, yodercm. Same on me for not mentioning as I presented a security discussion on cross-site scripting (XSS) on the very subject. Definitely a no no, especially going to a database as it becomes the gift that keeps on giving. ;)
Featured Post
Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.
One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
Popularity Can Be Measured
Sometimes we deal with questions of popularity, and we need a way to collect opinions from our clients. This article shows a simple teaching example of how we might elect a favorite color by letting our clients vote for …
Many old projects have bad code, but the budget doesn't exist to rewrite the codebase. You can update this code to be safer by introducing contemporary input validation, sanitation, and safer database queries.
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.
The viewer will learn how to create and use a small PHP class to apply a watermark to an image. This video shows the viewer the setup for the PHP watermark as well as important coding language. Continue to Part 2 to learn the core code used in creat…
Suggested Courses
Course of the Month8 days, left to enroll
729 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.