Solved

Add records to a SQL table based on values in another table

Posted on 2009-07-08
8
269 Views
Last Modified: 2012-05-07
I would like to add records to the "DrgGrp" table based on records in the "Drg" table (please see attached files for screenshots of sample data and field names from both tables).

I want to add a record to the DrgGrp table for every time a a record exists in the Drg table with the text "CAP" anywhere in the FORM field and the records being added will all have the same value for DrgGrp.GroupID (lets say for the example of the query to make it 199).  Care must be taken to update the DrgGrp.Seq field properly.  If several records exist with the same DrgGrp.DrgID the DrgGrp.Seq must be incremented to the next higher number.  For example if there are already two records with the same DrgGrp.DrgID then the 3rd record that gets added would need to have a DrgGrp.Seq value of 3.
drg-Table.png
drggrp-Table.png
0
Comment
Question by:tsmit877
  • 6
  • 2
8 Comments
 
LVL 32

Expert Comment

by:bhess1
ID: 24805735
A query like this one (implemented here as a stored procedure for clarity) should do what you are looking for, as I understand it.  Here are the assumptions I will be making:

     "I want to add a record to the DrgGrp table for every time a a record exists in the Drg table with the text "CAP" anywhere in the FORM field "

We will be looking for the distinct word CAP, not the letters CAP embedded in another word.  Thus, the WHERE clause will be a bit complex, eg

WHERE form LIKE 'CAP %'
    OR form LIKE '% CAP'
    OR form LIKE '% CAP %'

If other separators than a space may occur, a variation would be needed.  For example, if the word could end with a period, space, or comma, then the WHERE would look like:

WHERE form LIKE 'CAP[ ,.]%'
    OR form LIKE '% CAP'
    OR form LIKE '% CAP[ ,.]%'


     "and the records being added will all have the same value for DrgGrp.GroupID (lets say for the example of the query to make it 199)."

Passed as a parameter into the stored procedure


     "If several records exist with the same DrgGrp.DrgID the DrgGrp.Seq must be incremented to the next higher number"

Assuming that the condition should be "If several records exist with the same DrgGrp.DrgID and DrgGrp.GroupID....."


Given these assumptions:

CREATE PROCEDURE drg_AddDrgGrpRecords
    @GroupID int
AS
BEGIN
CREATE PROCEDURE drg_AddDrgGrpRecords
    @GroupID int
AS
BEGIN
    CREATE TABLE #tmp (
        id INT IDENTITY(1,1) PRIMARY KEY CLUSTERED,
        DrgID INT NOT NULL
    )
 
    INSERT INTO #tmp (DrgID)
    SELECT ID 
    FROM Drg
    WHERE form LIKE 'CAP[ ,.]%'
        OR form LIKE '% CAP'
        OR form LIKE '% CAP[ ,.]%'
 
    INSERT INTO DrgGrp (
        DrgID,
        GroupID,
        Created,        ---- Not updated in sample, can be commented out if not needed
        Seq,
        CentralMaintFieldMask
        )
    SELECT 
        DrgID,
        @GroupID,
        CURRENT_TIMESTAMP,    -- Not updated in sample, can be commented out if not needed
        (SELECT COUNT(*) FROM #tmp x WHERE x.DrgID = t.DrgID AND x.id <= t.id) Seq,
        0
    FROM #tmp t
END

Open in new window

0
 
LVL 2

Author Comment

by:tsmit877
ID: 24805830
Where do I specify DrgGrp.GroupID in the stored procedure that will be used for all the records that get added?
0
 
LVL 2

Author Comment

by:tsmit877
ID: 24805885
Sorry, I just ran the stored procedure and see that it prompts for the value.  I will try it now and let you know the results shortly.
0
Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

 
LVL 2

Author Comment

by:tsmit877
ID: 24807576
Looks like it works well but the portion that is supposed to account for existing Seq #'s is not working.  My SQL is very basic but looking at the query it look like it might be because it is looking for existing Seq #'s in the TMP table instead of the DrgGrp table?

Right now when it is adding the records it simply uses Seq "1" but I think that's because there are never more than 1 seq #'s in the TMP table.
0
 
LVL 32

Accepted Solution

by:
bhess1 earned 500 total points
ID: 24807809
Ah - I see what you need then.  I missed the fact that you would be inserting multiple times into the same DrgGrp.  

The code snippet below handles all cases I can think of.



CREATE PROCEDURE drg_AddDrgGrpRecords
    @GroupID int
AS
BEGIN
    CREATE TABLE #tmp (
        id INT IDENTITY(1,1),
		Src CHAR(1) NOT NULL,
        DrgID INT NOT NULL,
		CONSTRAINT tmp_pk_drg_12935498 PRIMARY KEY CLUSTERED (Src, ID)
    )
 
	INSERT INTO #tmp (Src, DrgID)
		SELECT 
			'A',
			DrgID
		FROM DrgGrp
		WHERE DrgGrp.GroupID = @GroupID
 
    INSERT INTO #tmp (Src, DrgID)
    SELECT 
		'Z', 
		ID 
    FROM Drg
    WHERE form LIKE 'CAP[ ,.]%'
        OR form LIKE '% CAP'
        OR form LIKE '% CAP[ ,.]%'
 
    INSERT INTO DrgGrp (
        DrgID,
        GroupID,
        Created,        ---- Not updated in sample, can be commented out if not needed
        Seq,
        CentralMaintFieldMask
        )
    SELECT 
        DrgID,
        @GroupID,
        CURRENT_TIMESTAMP,    -- Not updated in sample, can be commented out if not needed
        (SELECT COUNT(*) FROM #tmp x WHERE x.DrgID = t.DrgID AND x.id <= t.id) Seq,
        0
    FROM #tmp t
	WHERE Src = 'Z'
END

Open in new window

0
 
LVL 2

Author Closing Comment

by:tsmit877
ID: 31601181
Worked Great.  Thanks bhess1
0
 
LVL 2

Author Comment

by:tsmit877
ID: 24827587
When I comment out where you have suggested I get the following error:

Msg 121, Level 15, State 1, Procedure drg_AddDrgGrpRecords, Line 26
The select list for the INSERT statement contains more items than the insert list. The number of SELECT values must match the number of INSERT columns.

Can you please help with this?
0
 
LVL 2

Author Comment

by:tsmit877
ID: 24827667
Ok, fixed the last error but now getting this when I run the stored procedure:

(565 row(s) affected)
Msg 2601, Level 14, State 1, Procedure drg_AddDrgGrpRecords, Line 15
Cannot insert duplicate key row in object 'dbo.DrgGrp' with unique index 'IXC_DrgGrp_DrgID_GroupID'.
The statement has been terminated.

(1 row(s) affected)
0

Featured Post

3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

INTRODUCTION: While tying your database objects into builds and your enterprise source control system takes a third-party product (like Visual Studio Database Edition or Red-Gate's SQL Source Control), you can achieve some protection using a sing…
Occasionally there is a need to clean table columns, especially if you have inherited legacy data. There are obviously many ways to accomplish that, including elaborate UPDATE queries with anywhere from one to numerous REPLACE functions (even within…
Along with being a a promotional video for my three-day Annielytics Dashboard Seminor, this Micro Tutorial is an intro to Google Analytics API data.
Email security requires an ever evolving service that stays up to date with counter-evolving threats. The Email Laundry perform Research and Development to ensure their email security service evolves faster than cyber criminals. We apply our Threat…

810 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question