Add records to a SQL table based on values in another table

I would like to add records to the "DrgGrp" table based on records in the "Drg" table (please see attached files for screenshots of sample data and field names from both tables).

I want to add a record to the DrgGrp table for every time a a record exists in the Drg table with the text "CAP" anywhere in the FORM field and the records being added will all have the same value for DrgGrp.GroupID (lets say for the example of the query to make it 199).  Care must be taken to update the DrgGrp.Seq field properly.  If several records exist with the same DrgGrp.DrgID the DrgGrp.Seq must be incremented to the next higher number.  For example if there are already two records with the same DrgGrp.DrgID then the 3rd record that gets added would need to have a DrgGrp.Seq value of 3.
drg-Table.png
drggrp-Table.png
LVL 2
tsmit877IT ManagerAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Brendt HessSenior DBACommented:
A query like this one (implemented here as a stored procedure for clarity) should do what you are looking for, as I understand it.  Here are the assumptions I will be making:

     "I want to add a record to the DrgGrp table for every time a a record exists in the Drg table with the text "CAP" anywhere in the FORM field "

We will be looking for the distinct word CAP, not the letters CAP embedded in another word.  Thus, the WHERE clause will be a bit complex, eg

WHERE form LIKE 'CAP %'
    OR form LIKE '% CAP'
    OR form LIKE '% CAP %'

If other separators than a space may occur, a variation would be needed.  For example, if the word could end with a period, space, or comma, then the WHERE would look like:

WHERE form LIKE 'CAP[ ,.]%'
    OR form LIKE '% CAP'
    OR form LIKE '% CAP[ ,.]%'


     "and the records being added will all have the same value for DrgGrp.GroupID (lets say for the example of the query to make it 199)."

Passed as a parameter into the stored procedure


     "If several records exist with the same DrgGrp.DrgID the DrgGrp.Seq must be incremented to the next higher number"

Assuming that the condition should be "If several records exist with the same DrgGrp.DrgID and DrgGrp.GroupID....."


Given these assumptions:

CREATE PROCEDURE drg_AddDrgGrpRecords
    @GroupID int
AS
BEGIN
CREATE PROCEDURE drg_AddDrgGrpRecords
    @GroupID int
AS
BEGIN
    CREATE TABLE #tmp (
        id INT IDENTITY(1,1) PRIMARY KEY CLUSTERED,
        DrgID INT NOT NULL
    )
 
    INSERT INTO #tmp (DrgID)
    SELECT ID 
    FROM Drg
    WHERE form LIKE 'CAP[ ,.]%'
        OR form LIKE '% CAP'
        OR form LIKE '% CAP[ ,.]%'
 
    INSERT INTO DrgGrp (
        DrgID,
        GroupID,
        Created,        ---- Not updated in sample, can be commented out if not needed
        Seq,
        CentralMaintFieldMask
        )
    SELECT 
        DrgID,
        @GroupID,
        CURRENT_TIMESTAMP,    -- Not updated in sample, can be commented out if not needed
        (SELECT COUNT(*) FROM #tmp x WHERE x.DrgID = t.DrgID AND x.id <= t.id) Seq,
        0
    FROM #tmp t
END

Open in new window

0
tsmit877IT ManagerAuthor Commented:
Where do I specify DrgGrp.GroupID in the stored procedure that will be used for all the records that get added?
0
tsmit877IT ManagerAuthor Commented:
Sorry, I just ran the stored procedure and see that it prompts for the value.  I will try it now and let you know the results shortly.
0
Acronis Data Cloud 7.8 Enhances Cyber Protection

A closer look at five essential enhancements that benefit end-users and help MSPs take their cloud data protection business further.

tsmit877IT ManagerAuthor Commented:
Looks like it works well but the portion that is supposed to account for existing Seq #'s is not working.  My SQL is very basic but looking at the query it look like it might be because it is looking for existing Seq #'s in the TMP table instead of the DrgGrp table?

Right now when it is adding the records it simply uses Seq "1" but I think that's because there are never more than 1 seq #'s in the TMP table.
0
Brendt HessSenior DBACommented:
Ah - I see what you need then.  I missed the fact that you would be inserting multiple times into the same DrgGrp.  

The code snippet below handles all cases I can think of.



CREATE PROCEDURE drg_AddDrgGrpRecords
    @GroupID int
AS
BEGIN
    CREATE TABLE #tmp (
        id INT IDENTITY(1,1),
		Src CHAR(1) NOT NULL,
        DrgID INT NOT NULL,
		CONSTRAINT tmp_pk_drg_12935498 PRIMARY KEY CLUSTERED (Src, ID)
    )
 
	INSERT INTO #tmp (Src, DrgID)
		SELECT 
			'A',
			DrgID
		FROM DrgGrp
		WHERE DrgGrp.GroupID = @GroupID
 
    INSERT INTO #tmp (Src, DrgID)
    SELECT 
		'Z', 
		ID 
    FROM Drg
    WHERE form LIKE 'CAP[ ,.]%'
        OR form LIKE '% CAP'
        OR form LIKE '% CAP[ ,.]%'
 
    INSERT INTO DrgGrp (
        DrgID,
        GroupID,
        Created,        ---- Not updated in sample, can be commented out if not needed
        Seq,
        CentralMaintFieldMask
        )
    SELECT 
        DrgID,
        @GroupID,
        CURRENT_TIMESTAMP,    -- Not updated in sample, can be commented out if not needed
        (SELECT COUNT(*) FROM #tmp x WHERE x.DrgID = t.DrgID AND x.id <= t.id) Seq,
        0
    FROM #tmp t
	WHERE Src = 'Z'
END

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
tsmit877IT ManagerAuthor Commented:
Worked Great.  Thanks bhess1
0
tsmit877IT ManagerAuthor Commented:
When I comment out where you have suggested I get the following error:

Msg 121, Level 15, State 1, Procedure drg_AddDrgGrpRecords, Line 26
The select list for the INSERT statement contains more items than the insert list. The number of SELECT values must match the number of INSERT columns.

Can you please help with this?
0
tsmit877IT ManagerAuthor Commented:
Ok, fixed the last error but now getting this when I run the stored procedure:

(565 row(s) affected)
Msg 2601, Level 14, State 1, Procedure drg_AddDrgGrpRecords, Line 15
Cannot insert duplicate key row in object 'dbo.DrgGrp' with unique index 'IXC_DrgGrp_DrgID_GroupID'.
The statement has been terminated.

(1 row(s) affected)
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Query Syntax

From novice to tech pro — start learning today.