How Do I Read Text File into Array using C++

Im really unfamiliar with C++ so need some help. Can someone post the exact code that will do the following;

I have a  text file called "C:\\bob.txt"

It contains 256 rows of 3 digits (separated by a space). ie. the first 3 lines are

33 47 50
12 88 99
44 90 23

Each number contains a maximum of 3 digits.
 
Each row represents a colour in RGB format. ie 1st number is red, 2nd number is green, 3rd number is blue.

I want to read the text file into an array of Color. Something along the lines of;

Color myColorArray = new Color[256];

Then you would use a loop and add each line of 3 digits (representing a color) to the array. ie.

Color col  = Color::FromArgb(r,g,b);

then add col to the array


So basically I need to read the text file and add each line that represents a color to an array of Color.
Can someone post the exact code that would do this?

Thanks
rangers99Asked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
evilrixConnect With a Mentor Senior Software Engineer (Avast)Commented:
Just noticed you need to use FromArgb... code modified to suit.

>>> colors.push_back(Color::FromArgb(v[0], v[1], v[2])); <<<

NB. Again, Color is a dummy class since I don't have Windows... just remove it and use your own class.
#include <sstream>
#include <string>
#include <vector>
#include <iterator>
 
struct Color // Dummy
{
   Color(int r, int g, int b)
      :r(r), g(g), b(b)
   {}
 
   static Color FromArgb(int r, int g, int b)
   {
      return Color(r,g,b);
   }
 
   int r;
   int g;
   int b;
};
 
int main()
{
   // For test purposes I use a stringstream you can swap this for
   // a fstream to read the same data from file, interfaces are identical
   std::stringstream ifs("33 47 50\n12 88 99\n 44 90 23");
 
   std::string sLine;
   std::vector<int> v(3);
   std::vector<Color> colors;
 
   while(std::getline(ifs, sLine))
   {
      std::stringstream ss(sLine);
      std::copy(std::istream_iterator<int>(ss), std::istream_iterator<int>(), v.begin());
 
      colors.push_back(Color::FromArgb(v[0], v[1], v[2]));
   }
}

Open in new window

0
 
itsmeandnobodyelseCommented:
Something like the below?
#include <string>
#include <vector>
#include <fstream>
#include <sstream>
using namespace std;
 
 
...
ifstream ifs("bob.txt");
string line;
vector<Color> colors;
while (getline(ifs, line))
{
    istringstream iss(line);
    Color c = { 0 };
    if (!iss >> c.red) continue;
    if (!iss >> c.green) continue;
    if (!iss >> c.blue) continue;
    colors.push_back(c);
}
ifs.close();

Open in new window

0
 
evilrixSenior Software Engineer (Avast)Commented:
http://www.cplusplus.com/reference/algorithm/copy/
http://www.cplusplus.com/reference/stl/vector/
http://www.cplusplus.com/reference/std/iterator/istream_iterator/
http://www.cplusplus.com/reference/iostream/fstream/
http://www.cplusplus.com/reference/iostream/stringstream/
#include <sstream>
#include <string>
#include <vector>
#include <iterator>
 
struct Color // Dummy
{
   Color(int r, int g, int b)
      :r(r), g(g), b(b)
   {}
 
   int r;
   int g;
   int b;
};
 
int main()
{
   // For test purposes I use a stringstream you can swap this for
   // a fstream to read the same data from file, interfaces are identical
   std::stringstream ifs("33 47 50\n12 88 99\n 44 90 23");
 
   std::string sLine;
   std::vector<int> v(3);
   std::vector<Color> colors;
 
   while(std::getline(ifs, sLine))
   {
      std::stringstream ss(sLine);
      std::copy(std::istream_iterator<int>(ss), std::istream_iterator<int>(), v.begin());
 
      colors.push_back(Color(v[0], v[1], v[2]));
   }
}

Open in new window

0
Get your problem seen by more experts

Be seen. Boost your question’s priority for more expert views and faster solutions

 
rangers99Author Commented:
Hi
Did that code compile OK?
I tried pasting that into my code but Im getting several compiler errors.
0
 
rangers99Author Commented:
Sorry my above comment was for "itsmeandnobodyelse"
0
 
evilrixSenior Software Engineer (Avast)Commented:
>> Did that code compile OK?
Me or Alex?

Me -- yes, of course :)
0
 
Infinity08Commented:
>>     if (!iss >> c.red) continue;

Be careful with operator precedence. This does something entirely different than what you intended, since the negation operator (!) has higher precedence than the bit-leftshift operator (<<). You should add ()'s :

        if (!(iss >> c.red)) continue;
0
 
itsmeandnobodyelseCommented:
>>>> Did that code compile OK?
Hmmm, I made some "..." which probably won't compile.

also the code below the includes should be moved to a function or to your main.

Then I assumed Color struct has members red, green, blue. If it is not or if it is r,g,b  you would need to change it.

Best, you post the struct definition of Color and I could test it on my system.
0
 
rangers99Author Commented:
evilrix
The Color struct you have defined clashes with the Color class
0
 
itsmeandnobodyelseCommented:
>>>> if (!(iss >> c.red)) continue;
Thanks, Infinity. I recognized it after posting.
0
 
evilrixSenior Software Engineer (Avast)Commented:
>> The Color struct you have defined clashes with the Color class
It's for example purposes only... that's why it says Dummy next to it. I am not compiling this on Windows so it is meant to represent your Color class.
0
 
evilrixSenior Software Engineer (Avast)Commented:
>> I am not compiling this on Windows so it is meant to represent your Color class.
In other words swap it out for your class.
0
 
itsmeandnobodyelseCommented:
>>>> Me -- yes, of course :)
>>>> I am not compiling this on Windows

yes, of course ;-)
0
 
rangers99Author Commented:
Thanks thats done it. cheers.
0
 
itsmeandnobodyelseCommented:
The below compiles on my compiler.

I will test later.
#include <string>
#include <vector>
#include <fstream>
#include <sstream>
using namespace std;
 
/*  it is only for my test 
    you should use your Color structure
 
struct Color
{
   int r, g, b;
   static Color FromArgb(int red, int green, int blue)
   {
      Color c = { 0 };    
      c.r = red; c.g = green; c.b = blue;
      return c;
   }
};
*/
 
bool getColors(vector<Color>& colors)
{
   ifstream ifs("bob.txt");
   string line;
   while (getline(ifs, line))
   {
       istringstream iss(line);
       int red = 0, green = 0, blue = 0;
       if (!(iss >> red)) continue;
       if (!(iss >> green)) continue;
       if (!(iss >> blue)) continue;
       // Hope FromArgb was no typo
       Color c = Color::FromArgb(red, green, blue);
       colors.push_back(c);
   }
   ifs.close();
   return colors.size() != 0;
}
 
int main(void) 
{
   vector<Color> colors;
   if (getColors(colors))
   {
      // here you can use the array
   }
   return 0;
}
 

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.