Any way to improve the performance of SQL query with optional parameters ?


This query returns correct data, just appears to be a bit slower than hoped (about 0.9s in testing on development box)
I will be calling it up to 150 times in succession from my app, using different DocId's
The idea is to determine docrevision with highest priority, including testing a requested docrevision to see what it's priority would be.

ProjectId is alway available. usually only one of DocId and DocNo will be supplied.
I need the RevStyles as a LIKE operation, but am looking at removing the option for LIKE testing of DocId

Query is in a stored proc. Currently SQLS2000. 2005 is available.
declare @ProjectId varchar(8)
   declare @DocNo int
   declare @DocId varchar(50)
   declare @TestRev varchar(5)
   
   set @ProjectId = '07074'
   set @DocId = 'Q1251-ME-BWSE-1000'
   set @TestRev = 'D'
   
   SELECT  rtrim(Proj_DocRev.RevisionId) AS RevId, Proj_RevStyles.Priority as Priority
   FROM dbo.Proj_Documents  , dbo.Proj_DocRev , dbo.Proj_Codes , dbo.Proj_RevStyles 
 
   WHERE proj_documents.Projectno =  @ProjectId 
        AND ((@DocNo IS NULL) OR (Proj_Documents.DocNo = @DocNo))
        AND ((@DocId IS NULL) OR (Proj_Documents.DocId LIKE @DocId))
        AND Proj_Documents.DocNo = Proj_DocRev.DocNo
        AND Proj_Documents.ProjectNo = Proj_Codes.ProjectNo 
        AND Proj_Codes.RevisionStyle = Proj_Revstyles.Id
        AND Proj_DocRev.RevisionId LIKE Proj_RevStyles.Tag
	UNION 
		 SELECT rtrim(@TestRev) as RevId, Proj_RevStyles.Priority as Priority
		   FROM dbo.Proj_Documents  , dbo.Proj_DocRev , dbo.Proj_Codes , dbo.Proj_RevStyles 
		   WHERE Proj_Codes.ProjectNo =  @ProjectId
				AND Proj_Codes.RevisionStyle = Proj_Revstyles.Id
				AND ((@TestRev IS NOT NULL) AND (@TestRev LIKE Proj_Revstyles.Tag))
		
   ORDER BY Priority DESC,RevId DESC;

Open in new window

LVL 33
Robberbaron (robr)Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Robberbaron (robr)Author Commented:
just realised i had too many tables in second query.  Removing them makes a significant improvement by itself.

   UNION                
       SELECT rtrim(@TestRev) as RevId, Proj_RevStyles.Priority as Priority
                   FROM dbo.Proj_Codes , dbo.Proj_RevStyles 
                   WHERE Proj_Codes.ProjectNo =  @ProjectId
                                AND Proj_Codes.RevisionStyle = Proj_Revstyles.Id
                                AND ((@TestRev IS NOT NULL) AND (@TestRev LIKE Proj_Revstyles.Tag))
                

Open in new window

0
RiteshShahCommented:
btw, can try removing "RTrim" function? it may give you good boost up, rather you can use something like this:

set @TestRev = rtrim('D')

there may be few more reason of low speed, like not having appropriate index, not having updated states but this is just a first look.
0
Éric MoreauSenior .Net ConsultantCommented:
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Racim BOUDJAKDJIDatabase Architect - Dba - Data ScientistCommented:
Try...

WHERE (col1 = ISNULL(@col1, col1))  AND
(col2 = ISNULL(@col2, col2) ) AND...
0
Robberbaron (robr)Author Commented:
none made any major improvement though the query may well be impacted by the parameter sniffing issue so have impleneted that workaround and added an index to assist with another process.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Query Syntax

From novice to tech pro — start learning today.