Drop down time selector - is there an &amp;quot;elegant&amp;quot; way to do it in php

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

SOLUTION

xBellox

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

khsater

Attached is a relatively simple way to do it, but it could probably be shortened by someone who knows more functions than I do. I can already think of a quicker way using a 24-hour system and checking if the number is more than 12, but it's not going to be much faster.

print '<option value="12:00a">12:00 A.M.</option>';
for($i = 1; $i<12 $i++){
   print '<option value="'.$i.':00a">'.$i.':00 A.M.</option>';
   print '<option value="'.$i.':30a">'.$i.':30 A.M.</option>';
}
print '<option value="12:00p">12:00 P.M.</option>';
for($i = 1; $i<12 $i++){
   print '<option value="'.$i.':00p">'.$i.':00 P.M.</option>';
   print '<option value="'.$i.':30p">'.$i.':30 P.M.</option>';
}

khsater

There we go. xBellox's method is much nicer than mine.

ASKER

Thanks all.

I am going to have "two" time drop downs in the forms.

Do I have to give each one an unique name or unique identifiers.

For example

Drop off your vehicle time:

Pick up your vehicle time:

Thanks

Rowby

khsater

You should give each one a unique name and a unique id. The name so that the submitted values can be differentiated and the id so that they're not confused by the browser.

You could do like this:

function TimeDropdown($name) {
  $res = '<select name="'.$name.'">';
  for($i=0;$i<24*60;$i+=30) {
    $time = date('h:i A',mktime($i/60,$i%60,0));
    $res .= '<option value="'.$time.'">'.$time.'</option>';  
  }
  $res .= '</select>';
  return $res;
}
echo TimeDropdown('drop_off_time');
echo TimeDropdown('pick_up_time');

ASKER

Hi cxr,

I used the below code.

Please check the result.

http://www.avrparking.com/test2.html

Any suggestions?

Thanks


function TimeDropdown($name) {
  $res = '<select name="'.$name.'">';
  for($i=0;$i<24*60;$i+=30) {
    $time = date('h:i A',mktime($i/60,$i%60,0));
    $res .= '<option value="'.$time.'">'.$time.'</option>';  
  }
  $res .= '</select>';
  return $res;
}
echo TimeDropdown('drop_off_time');
echo TimeDropdown('pick_up_time');

You must sorround it with PHP tags:

<?php
(php code here)
?>

You can (should) have three different php tags, first define the function, then put these where you want them in the form:

<?php echo TimeDropdown('drop_off_time'); ?>

<?php echo TimeDropdown('pick_up_time'); ?>

Your page has .html extension, normally you would need .php extension for the server to render PHP code, but this depends on the server configuration.

ASKER

Would this be correct?

<?php 
function TimeDropdown($name) {
  $res = '<select name="'.$name.'">';
  for($i=0;$i<24*60;$i+=30) {
    $time = date('h:i A',mktime($i/60,$i%60,0));
    $res .= '<option value="'.$time.'">'.$time.'</option>';  
  }
  $res .= '</select>';
  return $res;
}
<?php echo TimeDropdown('drop_off_time'); ?>
<?php echo TimeDropdown('pick_up_time'); ?>	
?>

No. You can not nest PHP tags. Split it in three parts: first the function within one set of PHP tags, then the two TimeDropdown() calls, each in its own PHP tags, placed where you want them in the HTML form.

<?php 
function TimeDropdown($name) {
  $res = '<select name="'.$name.'">';
  for($i=0;$i<24*60;$i+=30) {
    $time = date('h:i A',mktime($i/60,$i%60,0));
    $res .= '<option value="'.$time.'">'.$time.'</option>';  
  }
  $res .= '</select>';
  return $res;
}
?>
<form ... >
<?php echo TimeDropdown('drop_off_time'); ?>
(more form fields)
<?php echo TimeDropdown('pick_up_time'); ?>     
</form>

ASKER

Working nicely. (I need to style it but it's working.

http://www.avrparking.com/test2.html

What field would I use for the form results? I assume "drop_off_time" and "pick_up_time" ?

I tried using the form but the date fields did not show up in the emailed form results. OR is that something beyond the scope of this question -- for another Experts Exchange area?

Also (but it is not essential) is there a way to remove the "0" from times such as "09:30am"?

Rowby

SOLUTION

xBellox

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

xBellox

I saw in your test2.html that the two select input has tha same name: "drop_off_time". I think this may be the problem. And yes, normally the name of the variable should be $_POST["drop_off_time"] and $_POST["pick_up_time"] (or $drop_off_time and $pick_up_time if your server has the option "safe_mode"set to off).

ASKER

Hi

I have to go to some meethings but will resume later. Looks like all is gonna work fine!

Rowby

ASKER

Hi xBellox:

Working very nice.
http://avrparking.com/test2.html

One final question.

Can I add some code that will start the time at, say 8:00 am and end the time at say 10:00pm

Thanks

Rowby

Just change the start and end time in the for loop, like this:

for($i=8*60;$i<=22*60;$i+=30) {

22 == 10:00pm

ASKER

I'm getting close but not quite there

The below code gives me a start time of 10:00 AM and an end time of 10:00 AM.

http://avrparking.com/test2.html

Rowby

<?php 
function TimeDropdown($name) {
  $res = '<select name="'.$name.'">';
   for($i=10*60;$i<=22*60;$i+=30) {
    $time = date('g:i A',mktime($i/60,$i%60,0));
    $res .= '<option value="'.$time.'">'.$time.'</option>';  
  }
  $res .= '</select>';
  return $res;
}
?>

ASKER

Never mind. I think the code is correct.

Let me double check.

Stay tuned.