Solved

Copy selected row from one ADOQuery to an other

Posted on 2009-07-11
18
1,673 Views
Last Modified: 2013-11-23
I have 2 adoquery's, (connected to an access database), when I select a record in adoquery1 I want it to be copied to adoquery2 when I click on a button.
I already have this code, but it doesnt work.
procedure TForm1.Button2Click(Sender: TObject);
var teller : Integer;
  Enabled : Boolean;
begin
  ADOQuery2.Append;
  for teller := 1 to ADOQuery1.fieldcount - 1 do
  ADOQuery2.fields[teller].Value := ADOQuery1.fields[teller].Value;
  ADOQuery2.Post;
  Enabled := ADOQuery2.RecordCount > 0;
  RemoveSongButton.Enabled := Enabled;
  RemoveSongfromsonglist.Enabled := Enabled;
  DBGrid2.Enabled := True;
  Button4.Enabled := True;
  Button5.Enabled := True;
  Button6.Enabled := True;
end;

Open in new window

0
Comment
Question by:delphiuser2009
  • 9
  • 9
18 Comments
 
LVL 6

Expert Comment

by:FactorB
ID: 24829874
procedure TForm1.Button2Click(Sender: TObject);
var
  teller : Integer;
  Enbld : Boolean;
begin
  ADOQuery2.Insert;
  for teller := 1 to ADOQuery1.fieldcount - 1 do begin
  ADOQuery2.Fields[teller].value := ADOQuery1.Fields[teller].value;
  end;
  ADOQuery2.Post;
  if ADOQuery2.RecordCount > 0 then Enbld:=true else Enbld:=false;  
  RemoveSongButton.Enabled := Enbld;
  RemoveSongfromsonglist.Enabled := Enbld;
  DBGrid2.Enabled := True;
  Button4.Enabled := True;
  Button5.Enabled := True;
  Button6.Enabled := True;
end;
0
 

Author Comment

by:delphiuser2009
ID: 24829899
Thanks, I have the first ADOQuery (is linked to a DBGrid with two columns in). But in the second ADOQuery (second DBGrid), it only shows the second column (columns are: Songtitle and Genre). The second ADOQuery should also show the first column, but now it displays only the second column.
Why?
 
0
 
LVL 6

Expert Comment

by:FactorB
ID: 24829927
1. Have you used proper SQL syntax for it. Probably should be:

ADOQuery2.SQL:='SELECT * FROM Table_Name;';

it looks that in your case is

ADOQuery2.SQL:='SELECT Songtitle FROM Table_Name;';

Change Table_Name with the name of your table

2. Also it can be a case if you defined DBGrid to show only specific columns. Double click on DBGrid in design time and clear all the columns defined in Editing dialog.

Regards,
B.
0
How our DevOps Teams Maximize Uptime

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us. Read the use case whitepaper.

 

Author Comment

by:delphiuser2009
ID: 24829945
Thanks I've changed it to ADOQuery.SQL :='SELECT Songtitle, Genre FROM songs2
Now the Genre column is on its place, but the first column is not visible.
It looks like the code is not taking the column Songtitle for the copy, only the Genre column.
0
 
LVL 6

Expert Comment

by:FactorB
ID: 24830020
If is more possible that you have defined only Genre column for DBGrid, try double clicking on DBGrid and deleting all the columns from the list. This way DBGrid will have default settings.
0
 

Author Comment

by:delphiuser2009
ID: 24830092
Nope this doesnt work also.
0
 
LVL 6

Expert Comment

by:FactorB
ID: 24830133
Hmm, I don't know what is the problem with DBGrid. I really haven't similar problems. Do you remember changing it somehow in the meantime. If I was you I would delete problematic DBGrid. Put a new on the form, name it like the old one and reconnect it to the same datasource.
0
 
LVL 6

Accepted Solution

by:
FactorB earned 100 total points
ID: 24830249
here is the problem, in my first post change

for teller := 1 to ADOQuery1.fieldcount - 1 do begin

with

for teller := 0 to ADOQuery1.fieldcount - 1 do begin

Everything should be fine now. Sorry I did a mistake, when I used your code as base I haven't noticed that loop starts from 1, Songtitle in this case is column 0.

Regards,
Bojan
0
 

Author Comment

by:delphiuser2009
ID: 24831678
Thanks that did the trick.
I will reward you the points, but I have a small question (not really this topic but still SQL).
I have this code which I use to get all the columns (single row) and put them into 2 richedit fields and a edit field.
1 column is a songtext column and the text inside that field should be put into the richedit field. The other two are the songtitle and id column.
It now shows (when I press a button) not the selected row in the fields I described earlier. But some other row.
This is the code I use for it.
Please can you look at it?
I'll raise the point for you if you can help me with it.
Thanks.

procedure TForm1.Button3Click(Sender: TObject);
begin
  with ADOQuery1 do
  begin
    Close;
    SQL.Clear;
    SQL.Add('SELECT * FROM songs');
    Open;
    RichEdit1.Lines.Text := ADOQuery1.FieldByName('SongText').AsString;
    RichEdit2.Lines.Text := ADOQuery1.FieldByName('Songtitle').AsString;
    Edit3.Text := ADOQuery1.FieldByName('Id').AsString;
    RichEdit1.Enabled := True;
    RichEdit2.Enabled := True;
    Button8.Enabled := True;
  end;
end;

Open in new window

0
 
LVL 6

Expert Comment

by:FactorB
ID: 24831708
Off course that you can not get the selected record.
Why: when you close and open ADOQuery1 pointer moves from selected row to first row.
As I can see now original code should be stripped to:

procedure TForm1.Button3Click(Sender: TObject);
begin
    RichEdit1.Lines.Text := ADOQuery1.FieldByName('SongText').AsString;
    RichEdit2.Lines.Text := ADOQuery1.FieldByName('Songtitle').AsString;
    Edit3.Text := ADOQuery1.FieldByName('Id').AsString;
    RichEdit1.Enabled := True;
    RichEdit2.Enabled := True;
    Button8.Enabled := True;
end;
0
 

Author Comment

by:delphiuser2009
ID: 24831767
I get the message: Exception class EDatabaseError with message 'ADOQuery1: Field 'SongText' not found'.
0
 
LVL 6

Expert Comment

by:FactorB
ID: 24831789
This is why, when you execute query previously you are not including these two fields (SongText, Songtitle):

ADOQuery1.SQL:='SELECT Songtitle, Genre FROM songs2';

in order to function you should change the query to:

ADOQuery1.SQL:='SELECT Songtitle, Genre, SongText, Songtitle FROM songs2';
0
 

Author Comment

by:delphiuser2009
ID: 24835015
I see in the Query that you use songs table, but like you said in a previous post:
procedure TForm1.Button3Click(Sender: TObject);
begin
    RichEdit1.Lines.Text := ADOQuery1.FieldByName('SongText').AsString;
    RichEdit2.Lines.Text := ADOQuery1.FieldByName('Songtitle').AsString;
    Edit3.Text := ADOQuery1.FieldByName('Id').AsString;
    RichEdit1.Enabled := True;
    RichEdit2.Enabled := True;
    Button8.Enabled := True;
end;
This is a query that is related to table songs, the query for ADOQuery1 looks like this now: ADOQuery1.SQL :='SELECT Id, Songtitle, Genre, Songtext FROM songs';
But I still get the error that field 'Songtext' can't be found.
0
 
LVL 6

Expert Comment

by:FactorB
ID: 24835044
Ttry changing column names with numbers

from

 RichEdit1.Lines.Text := ADOQuery1.FieldByName('SongText').AsString;
 RichEdit2.Lines.Text := ADOQuery1.FieldByName('Songtitle').AsString;

to

 RichEdit1.Lines.Text := ADOQuery1.Fields[3].AsString;
 RichEdit2.Lines.Text := ADOQuery1.Fields[1].AsString;

0
 

Author Comment

by:delphiuser2009
ID: 24835220
Now I get the error: 'list index out of bounds (3)'.
0
 

Author Comment

by:delphiuser2009
ID: 24835328
I've got the solution: With button1 I open the database, but forgot to add songtext in the SELECT query.
I will reward you the points and I'll raise it to 100 for you help.
0
 

Author Closing Comment

by:delphiuser2009
ID: 31602386
Thanks you very much for your help. This helped me alot.
0
 
LVL 6

Expert Comment

by:FactorB
ID: 24835594
Glad that it helped, I suspected too on SQL syntax, but since you posted good Query earlier, I got confused.

Have a good day,
B.
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction I have seen many questions in this Delphi topic area where queries in threads are needed or suggested. I know bumped into a similar need. This article will address some of the concepts when dealing with a multithreaded delphi database…
Occasionally there is a need to clean table columns, especially if you have inherited legacy data. There are obviously many ways to accomplish that, including elaborate UPDATE queries with anywhere from one to numerous REPLACE functions (even within…
Email security requires an ever evolving service that stays up to date with counter-evolving threats. The Email Laundry perform Research and Development to ensure their email security service evolves faster than cyber criminals. We apply our Threat…
Nobody understands Phishing better than an anti-spam company. That’s why we are providing Phishing Awareness Training to our customers. According to a report by Verizon, only 3% of targeted users report malicious emails to management. With compan…

713 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question