Solved

Javascript switch

Posted on 2009-07-12
2
320 Views
Last Modified: 2012-05-07
I have a callback function (onContentLoad) that is parsing some json.  I have a bunch of if/else statements that I'd like to turn into a swtich.
onContentLoad: function (json) {

    //Parse the returned JSON response

    if (json.result == 'success' && json.addremove == 'add') {
 

}

    else if (json.result == 'success' && json.addremove == 'remove') {
 

}

    else if (json.result == 'fail' && json.message == 'action-failed') {
 

}

    else if (json.result == 'fail' && json.message == 'number-exceeded') {
 

}

    else if (json.result == 'fail' && json.message == 'not-logged-in') {
 

}

}

Open in new window

0
Comment
Question by:aznprncritic
2 Comments
 
LVL 36

Accepted Solution

by:
Zyloch earned 250 total points
ID: 24835544
You cannot turn a condition in which you are testing two equalities into a single switch. What you can do is:

//Parse the returned JSON response

if (json.result == 'success')

{

    switch (json.addremove)

    {

    case 'add':

        // Code

        break;

    case 'remove':

        // Code

        break;

    }

}

else if (json.result == 'fail')

{

    switch (json.message)

    {

    case 'action-failed':

        // Code

        break;

    case 'number-exceeded':

        // Code

        break;

    case 'not-logged-in':

        // Code

        break;

    }

}

Open in new window

0
 
LVL 41

Expert Comment

by:HonorGod
ID: 24835560

if ( json. result == 'success' ) {

  if ( json.addremove == 'add' ) {

//  #1 - json.result == 'success' && json.addremove == 'add' 

  } else {

//  #2 - json.result == 'success' && json.addremove == 'remove' 

  }

} else {

  switch ( json.message ) {

    case 'action-failed' :

//    #3 json.result == 'fail' && json.message == 'action-failed'

      break;

    case  'number-exceeded' :

//    #4 json.result == 'fail' && json.message == 'number-exceeded'

      break;

    case 'not-logged-in' :

//    #5 json.result == 'fail' && json.message ==    'not-logged-in'

      break;

    default :

      alert( 'oops' );

  }

}

Open in new window

0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

PROBLEM: The other day I was working on adding an ajax request to a webpage that already had a dialog box on the page.  The dialog box was using relative positioning to be positioned next to a form field I had on the page.  Everything was working…
I found this questions asking how to do this in many different forums, so I will describe here how to implement a solution using PHP and AJAX. The logical flow for the problem should be: Write an event handler for the first drop down box to get …
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn the basics of jQuery, including how to invoke it on a web page. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery.: (CODE)

705 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now