Solved

More cursor help!!  :)

Posted on 2009-07-13
4
213 Views
Last Modified: 2012-05-07
I have a cursor that creates a detail records for invoice.  The primary key is based on the source code, group num, and transaction num.  I am incrementing my transaction number but it is being overwritten on the next Fetch and being set back to 1.  So if the second record is the same grp number and source code the transnumber must be different.  How can I increment the trans_num without being overwritten...Hope this makes sense.  I have included the part of my code I'm having an issue with.  Thanks so much for any assistance.
SET @trans_num = 1

SET @encumb_gl_flag = 'G'

SET @encumb_gl_trans_sts = 'C'

SET @offset_flag = 'P'

SET @subsid_trans_sts = 'C'
 

DECLARE curDetail CURSOR FOR 

SELECT distinct @source, ih.grp_num, @trans_num, @tran_dte, @amt, cd.amt, cd.tran_desc,

cd.gl, @project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, ch.id_num,

@subsid_cde, @inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte

FROM

ccheader ch left outer join invoice_header ih 

on ch.id_num = ih.id_num

left outer join ccdetail cd ON cd.id_num = ch.id_num

WHERE ih.invoice_num = @inv_num

order by ih.grp_num
 

OPEN curDetail

FETCH NEXT FROM curDetail

INTO

@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,

@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte
 

WHILE @@FETCH_STATUS = 0

 

BEGIN
 

print @source + ' ' + cast(@grp_num as varchar) + ' '+ 

cast(@amt_det as varchar)+ ' '+ cast(@trans_num as varchar)+ ' ' + @gl
 

INSERT INTO trans_hist

(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,

acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,

invoice_num, subsid_trans_sts, user_name, job_name, job_time)

SELECT

@source, @grp_num, @trans_num, @tran_dte, @amt_det, @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,

@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 

SET @trans_num = @trans_num + 1
 

print @source + ' ' + cast(@grp_num as char) + ' '+ 

cast(-(@amt_det)as char)+ ' '+ cast(@trans_num as char)+ ' ' + @gl
 

INSERT INTO trans_hist

(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,

acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,

offset_flag, invoice_num, subsid_trans_sts, user_name, job_name, job_time)

SELECT

@source, @grp_num, @trans_num, @tran_dte, -(@amt_det), @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde, @offset_flag,

@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 
 

SET @trans_num = @trans_num + 1
 

print cast(@trans_num as char) + ' trans num after first run'
 

FETCH NEXT FROM curDetail 

INTO 

@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,

@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte

Open in new window

0
Comment
Question by:jasonbrandt3
  • 2
  • 2
4 Comments
 
LVL 22

Expert Comment

by:dportas
ID: 24842733
Cursors are rarely a good idea for this kind of thing. You should be able to get the same result using two INSERT statements, no cursor required. For example:

INSERT INTO trans_hist (...)
SELECT ...
FROM ccheader ch
LEFT OUTER JOIN invoice_header ih
ON ch.id_num = ih.id_num
LEFT OUTER JOIN ccdetail cd
ON cd.id_num = ch.id_num
WHERE ih.invoice_num = @inv_num ;

If the purpose of the cursor is to generate a new number for each row then use the ROW_NUMBER() function instead.

Note that the "WHERE ih.invoice_num = @inv_num" condition makes the OUTER join into an INNER join, which may or may not be what you intended.
0
 

Author Comment

by:jasonbrandt3
ID: 24843110
So you are saying insert all records at once.  How could I increment the transaction number for each row?
0
 
LVL 22

Accepted Solution

by:
dportas earned 500 total points
ID: 24843456
0
 

Author Closing Comment

by:jasonbrandt3
ID: 31602935
I will give it a try, these seems to be the more efficient way.  Appreciate the help.
0

Featured Post

How to improve team productivity

Quip adds documents, spreadsheets, and tasklists to your Slack experience
- Elevate ideas to Quip docs
- Share Quip docs in Slack
- Get notified of changes to your docs
- Available on iOS/Android/Desktop/Web
- Online/Offline

Join & Write a Comment

INTRODUCTION: While tying your database objects into builds and your enterprise source control system takes a third-party product (like Visual Studio Database Edition or Red-Gate's SQL Source Control), you can achieve some protection using a sing…
Use this article to create a batch file to backup a Microsoft SQL Server database to a Windows folder.  The folder can be on the local hard drive or on a network share.  This batch file will query the SQL server to get the current date & time and wi…
Get a first impression of how PRTG looks and learn how it works.   This video is a short introduction to PRTG, as an initial overview or as a quick start for new PRTG users.
You have products, that come in variants and want to set different prices for them? Watch this micro tutorial that describes how to configure prices for Magento super attributes. Assigning simple products to configurable: We assigned simple products…

758 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now