Solved

More cursor help!!  :)

Posted on 2009-07-13
4
215 Views
Last Modified: 2012-05-07
I have a cursor that creates a detail records for invoice.  The primary key is based on the source code, group num, and transaction num.  I am incrementing my transaction number but it is being overwritten on the next Fetch and being set back to 1.  So if the second record is the same grp number and source code the transnumber must be different.  How can I increment the trans_num without being overwritten...Hope this makes sense.  I have included the part of my code I'm having an issue with.  Thanks so much for any assistance.
SET @trans_num = 1
SET @encumb_gl_flag = 'G'
SET @encumb_gl_trans_sts = 'C'
SET @offset_flag = 'P'
SET @subsid_trans_sts = 'C'
 
DECLARE curDetail CURSOR FOR 
SELECT distinct @source, ih.grp_num, @trans_num, @tran_dte, @amt, cd.amt, cd.tran_desc,
cd.gl, @project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, ch.id_num,
@subsid_cde, @inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte
FROM
ccheader ch left outer join invoice_header ih 
on ch.id_num = ih.id_num
left outer join ccdetail cd ON cd.id_num = ch.id_num
WHERE ih.invoice_num = @inv_num
order by ih.grp_num
 
OPEN curDetail
FETCH NEXT FROM curDetail
INTO
@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,
@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte
 
WHILE @@FETCH_STATUS = 0
 
BEGIN
 
print @source + ' ' + cast(@grp_num as varchar) + ' '+ 
cast(@amt_det as varchar)+ ' '+ cast(@trans_num as varchar)+ ' ' + @gl
 
INSERT INTO trans_hist
(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,
acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,
invoice_num, subsid_trans_sts, user_name, job_name, job_time)
SELECT
@source, @grp_num, @trans_num, @tran_dte, @amt_det, @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,
@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 
SET @trans_num = @trans_num + 1
 
print @source + ' ' + cast(@grp_num as char) + ' '+ 
cast(-(@amt_det)as char)+ ' '+ cast(@trans_num as char)+ ' ' + @gl
 
INSERT INTO trans_hist
(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,
acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,
offset_flag, invoice_num, subsid_trans_sts, user_name, job_name, job_time)
SELECT
@source, @grp_num, @trans_num, @tran_dte, -(@amt_det), @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde, @offset_flag,
@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 
 
SET @trans_num = @trans_num + 1
 
print cast(@trans_num as char) + ' trans num after first run'
 
FETCH NEXT FROM curDetail 
INTO 
@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,
@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte

Open in new window

0
Comment
Question by:jasonbrandt3
  • 2
  • 2
4 Comments
 
LVL 22

Expert Comment

by:dportas
ID: 24842733
Cursors are rarely a good idea for this kind of thing. You should be able to get the same result using two INSERT statements, no cursor required. For example:

INSERT INTO trans_hist (...)
SELECT ...
FROM ccheader ch
LEFT OUTER JOIN invoice_header ih
ON ch.id_num = ih.id_num
LEFT OUTER JOIN ccdetail cd
ON cd.id_num = ch.id_num
WHERE ih.invoice_num = @inv_num ;

If the purpose of the cursor is to generate a new number for each row then use the ROW_NUMBER() function instead.

Note that the "WHERE ih.invoice_num = @inv_num" condition makes the OUTER join into an INNER join, which may or may not be what you intended.
0
 

Author Comment

by:jasonbrandt3
ID: 24843110
So you are saying insert all records at once.  How could I increment the transaction number for each row?
0
 
LVL 22

Accepted Solution

by:
dportas earned 500 total points
ID: 24843456
0
 

Author Closing Comment

by:jasonbrandt3
ID: 31602935
I will give it a try, these seems to be the more efficient way.  Appreciate the help.
0

Featured Post

VMware Disaster Recovery and Data Protection

In this expert guide, you’ll learn about the components of a Modern Data Center. You will use cases for the value-added capabilities of Veeam®, including combining backup and replication for VMware disaster recovery and using replication for data center migration.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In this article I will describe the Backup & Restore method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
Use this article to create a batch file to backup a Microsoft SQL Server database to a Windows folder.  The folder can be on the local hard drive or on a network share.  This batch file will query the SQL server to get the current date & time and wi…
This video shows how to use Hyena, from SystemTools Software, to bulk import 100 user accounts from an external text file. View in 1080p for best video quality.
The Email Laundry PDF encryption service allows companies to send confidential encrypted  emails to anybody. The PDF document can also contain attachments that are embedded in the encrypted PDF. The password is randomly generated by The Email Laundr…

810 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question