Solved

More cursor help!!  :)

Posted on 2009-07-13
4
214 Views
Last Modified: 2012-05-07
I have a cursor that creates a detail records for invoice.  The primary key is based on the source code, group num, and transaction num.  I am incrementing my transaction number but it is being overwritten on the next Fetch and being set back to 1.  So if the second record is the same grp number and source code the transnumber must be different.  How can I increment the trans_num without being overwritten...Hope this makes sense.  I have included the part of my code I'm having an issue with.  Thanks so much for any assistance.
SET @trans_num = 1

SET @encumb_gl_flag = 'G'

SET @encumb_gl_trans_sts = 'C'

SET @offset_flag = 'P'

SET @subsid_trans_sts = 'C'
 

DECLARE curDetail CURSOR FOR 

SELECT distinct @source, ih.grp_num, @trans_num, @tran_dte, @amt, cd.amt, cd.tran_desc,

cd.gl, @project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, ch.id_num,

@subsid_cde, @inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte

FROM

ccheader ch left outer join invoice_header ih 

on ch.id_num = ih.id_num

left outer join ccdetail cd ON cd.id_num = ch.id_num

WHERE ih.invoice_num = @inv_num

order by ih.grp_num
 

OPEN curDetail

FETCH NEXT FROM curDetail

INTO

@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,

@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte
 

WHILE @@FETCH_STATUS = 0

 

BEGIN
 

print @source + ' ' + cast(@grp_num as varchar) + ' '+ 

cast(@amt_det as varchar)+ ' '+ cast(@trans_num as varchar)+ ' ' + @gl
 

INSERT INTO trans_hist

(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,

acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,

invoice_num, subsid_trans_sts, user_name, job_name, job_time)

SELECT

@source, @grp_num, @trans_num, @tran_dte, @amt_det, @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,

@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 

SET @trans_num = @trans_num + 1
 

print @source + ' ' + cast(@grp_num as char) + ' '+ 

cast(-(@amt_det)as char)+ ' '+ cast(@trans_num as char)+ ' ' + @gl
 

INSERT INTO trans_hist

(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,

acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,

offset_flag, invoice_num, subsid_trans_sts, user_name, job_name, job_time)

SELECT

@source, @grp_num, @trans_num, @tran_dte, -(@amt_det), @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde, @offset_flag,

@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 
 

SET @trans_num = @trans_num + 1
 

print cast(@trans_num as char) + ' trans num after first run'
 

FETCH NEXT FROM curDetail 

INTO 

@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,

@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,

@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte

Open in new window

0
Comment
Question by:jasonbrandt3
  • 2
  • 2
4 Comments
 
LVL 22

Expert Comment

by:dportas
ID: 24842733
Cursors are rarely a good idea for this kind of thing. You should be able to get the same result using two INSERT statements, no cursor required. For example:

INSERT INTO trans_hist (...)
SELECT ...
FROM ccheader ch
LEFT OUTER JOIN invoice_header ih
ON ch.id_num = ih.id_num
LEFT OUTER JOIN ccdetail cd
ON cd.id_num = ch.id_num
WHERE ih.invoice_num = @inv_num ;

If the purpose of the cursor is to generate a new number for each row then use the ROW_NUMBER() function instead.

Note that the "WHERE ih.invoice_num = @inv_num" condition makes the OUTER join into an INNER join, which may or may not be what you intended.
0
 

Author Comment

by:jasonbrandt3
ID: 24843110
So you are saying insert all records at once.  How could I increment the transaction number for each row?
0
 
LVL 22

Accepted Solution

by:
dportas earned 500 total points
ID: 24843456
0
 

Author Closing Comment

by:jasonbrandt3
ID: 31602935
I will give it a try, these seems to be the more efficient way.  Appreciate the help.
0

Featured Post

Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction This article will provide a solution for an error that might occur installing a new SQL 2005 64-bit cluster. This article will assume that you are fully prepared to complete the installation and describes the error as it occurred durin…
When writing XML code a very difficult part is when we like to remove all the elements or attributes from the XML that have no data. I would like to share a set of recursive MSSQL stored procedures that I have made to remove those elements from …
This video shows how to remove a single email address from the Outlook 2010 Auto Suggestion memory. NOTE: For Outlook 2016 and 2013 perform the exact same steps. Open a new email: Click the New email button in Outlook. Start typing the address: …
Delivering innovative fully-managed cloud services for mission-critical applications requires expertise in multiple areas plus vision and commitment. Meet a few of the people behind the quality services of Concerto.

943 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

4 Experts available now in Live!

Get 1:1 Help Now