More cursor help!! :)

I have a cursor that creates a detail records for invoice.  The primary key is based on the source code, group num, and transaction num.  I am incrementing my transaction number but it is being overwritten on the next Fetch and being set back to 1.  So if the second record is the same grp number and source code the transnumber must be different.  How can I increment the trans_num without being overwritten...Hope this makes sense.  I have included the part of my code I'm having an issue with.  Thanks so much for any assistance.
SET @trans_num = 1
SET @encumb_gl_flag = 'G'
SET @encumb_gl_trans_sts = 'C'
SET @offset_flag = 'P'
SET @subsid_trans_sts = 'C'
 
DECLARE curDetail CURSOR FOR 
SELECT distinct @source, ih.grp_num, @trans_num, @tran_dte, @amt, cd.amt, cd.tran_desc,
cd.gl, @project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, ch.id_num,
@subsid_cde, @inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte
FROM
ccheader ch left outer join invoice_header ih 
on ch.id_num = ih.id_num
left outer join ccdetail cd ON cd.id_num = ch.id_num
WHERE ih.invoice_num = @inv_num
order by ih.grp_num
 
OPEN curDetail
FETCH NEXT FROM curDetail
INTO
@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,
@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte
 
WHILE @@FETCH_STATUS = 0
 
BEGIN
 
print @source + ' ' + cast(@grp_num as varchar) + ' '+ 
cast(@amt_det as varchar)+ ' '+ cast(@trans_num as varchar)+ ' ' + @gl
 
INSERT INTO trans_hist
(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,
acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,
invoice_num, subsid_trans_sts, user_name, job_name, job_time)
SELECT
@source, @grp_num, @trans_num, @tran_dte, @amt_det, @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,
@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 
SET @trans_num = @trans_num + 1
 
print @source + ' ' + cast(@grp_num as char) + ' '+ 
cast(-(@amt_det)as char)+ ' '+ cast(@trans_num as char)+ ' ' + @gl
 
INSERT INTO trans_hist
(source_cde, group_num, trans_key_line_num, trans_dte, trans_amt, trans_desc,
acct_cde, project_code, encumb_gl_flag, encumb_gl_trans_st, ap_sbs_id_num, ap_sbs_cde_subsid,
offset_flag, invoice_num, subsid_trans_sts, user_name, job_name, job_time)
SELECT
@source, @grp_num, @trans_num, @tran_dte, -(@amt_det), @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde, @offset_flag,
@inv_num,  @subsid_trans_sts, @user, @job, @tran_dte
 
 
SET @trans_num = @trans_num + 1
 
print cast(@trans_num as char) + ' trans num after first run'
 
FETCH NEXT FROM curDetail 
INTO 
@source, @grp_num, @trans_num, @tran_dte, @amt, @amt_det, @tran_desc, @gl,
@project_cde, @encumb_gl_flag, @encumb_gl_trans_sts, @id_num, @subsid_cde,
@inv_num, @offset_flag, @subsid_trans_sts, @user, @job, @tran_dte

Open in new window

jasonbrandt3Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

dportasCommented:
Cursors are rarely a good idea for this kind of thing. You should be able to get the same result using two INSERT statements, no cursor required. For example:

INSERT INTO trans_hist (...)
SELECT ...
FROM ccheader ch
LEFT OUTER JOIN invoice_header ih
ON ch.id_num = ih.id_num
LEFT OUTER JOIN ccdetail cd
ON cd.id_num = ch.id_num
WHERE ih.invoice_num = @inv_num ;

If the purpose of the cursor is to generate a new number for each row then use the ROW_NUMBER() function instead.

Note that the "WHERE ih.invoice_num = @inv_num" condition makes the OUTER join into an INNER join, which may or may not be what you intended.
0
jasonbrandt3Author Commented:
So you are saying insert all records at once.  How could I increment the transaction number for each row?
0
dportasCommented:
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
jasonbrandt3Author Commented:
I will give it a try, these seems to be the more efficient way.  Appreciate the help.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server 2005

From novice to tech pro — start learning today.