Mandatory to call GetUpdateCommand of SqlCommandBuilder ?

Posted on 2009-07-13
Last Modified: 2012-05-07
I am updating/inserting database via dataset.
According to the sample code from Microsoft documentation, it is required to call GetUpdateCommand() and GetInsertCommand() of the command builder before doing
adapter.Update(ds, dataTableName).

But my program works fine even without calling these.
Could somebody tell if I really need to call these methods ?
Without that, what kind of problem could happen?
SqlConnection conn = new SqlConnection(CONNECTION_STRING);

            string dataTableName = "PRICE_DATA";

            DataSet ds = new DataSet(dataTableName);

            string sql = "SELECT Ticker, As_of, Updt_dt, eqy_weighted_avg_px, px_open, px_volume, asset_id, modifiedtimestamp FROM Price WHERE Updt_dt = '" + update_Date + "'";

            SqlCommand selectCMD = new SqlCommand(sql, conn);

            SqlDataAdapter da = new SqlDataAdapter(selectCMD);

            SqlCommandBuilder builder = new SqlCommandBuilder(da);




                da.Fill(ds, dataTableName);


            catch (SqlException ex)


                throw ex;


            //Setting composite PK

            DataColumn[] keys = new DataColumn[2];

            DataColumn column1 = ds.Tables[0].Columns["TICKER"];

            DataColumn column2 = ds.Tables[0].Columns["UPDT_DT"];

            keys[0] = column1;

            keys[1] = column2;

            ds.Tables[0].PrimaryKey = keys;


            foreach (Security sec in securities)


                if (sec.OpenPrice != 0 && sec.Volume != 0  && sec.WeightedAverage != 0) //if value is not available, do not insert


                    //Key Values

                    object[] myKeyValues = { sec.Ticker, sec.UpdateDate.ToString("yyyyMMdd") };

                    if (ds.Tables[dataTableName].Rows.Contains(myKeyValues))



                        DataRow existingRow = ds.Tables[dataTableName].Rows.Find(myKeyValues);

                        existingRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");

                        existingRow["PX_OPEN"] = sec.OpenPrice;

                        existingRow["PX_VOLUME"] = sec.Volume;

                        existingRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;

                        existingRow["MODIFIEDTIMESTAMP"] = DateTime.Now;





                        DataRow newRow = ds.Tables[dataTableName].NewRow();

                        newRow["TICKER"] = sec.Ticker;

                        newRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");

                        newRow["UPDT_DT"] = DateTime.Now.Date.ToString("yyyyMMdd");

                        newRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;

                        newRow["PX_OPEN"] = sec.OpenPrice;

                        newRow["PX_VOLUME"] = sec.Volume;

                        newRow["ASSET_ID"] = sec.AssetId;

                        newRow["MODIFIEDTIMESTAMP"] = DateTime.Now;





            builder.GetUpdateCommand(); //not necessary ?

            builder.GetInsertCommand();//not necessary ?


	    da.Update(ds, dataTableName);

Open in new window

Question by:Takamasa
  • 2
  • 2
LVL 96

Expert Comment

by:Bob Learned
Comment Utility
If you reach da.Update(ds, dataTableName) without calling GetUpdateCommand and GetInsertCommand, does the SqlDataAdapter have an instance of an UpdateCommand and InsertCommand?  I don't see anything in the SqlCommandBuilder or DbCommandBuilder (base class), that would construct the commands otherwise.

Author Comment

Comment Utility
Hi. Thank you for the response.
No, both UpdateCommand and InsertCommand are null...
LVL 96

Accepted Solution

Bob Learned earned 500 total points
Comment Utility
Then, I would suggest that there isn't any updates or inserts, or there should have been an exception.  I always use the GetUpdateCommand, GetInsertCommand, and GetDeleteCommand with command builders.

Author Comment

Comment Utility
Hello TheLearnedOne,
Thank you for your comment again.
Strangely the data do get inserted in my database, which made me wonder what is the use of GetInsertCommand. Anyways, I will use the GetUpdateCommand and GetInsertCommand like you suggested.
Thank you!

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Introduction Hi all and welcome to my first article on Experts Exchange. A while ago, someone asked me if i could do some tutorials on object oriented programming. I decided to do them on C#. Now you may ask me, why's that? Well, one of the re…
Entity Framework is a powerful tool to help you interact with the DataBase but still doesn't help much when we have a Stored Procedure that returns more than one resultset. The solution takes some of out-of-the-box thinking; read on!
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…
This video explains how to create simple products associated to Magento configurable product and offers fast way of their generation with Store Manager for Magento tool.

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now