Mandatory to call GetUpdateCommand of SqlCommandBuilder ?

Posted on 2009-07-13
Last Modified: 2012-05-07
I am updating/inserting database via dataset.
According to the sample code from Microsoft documentation, it is required to call GetUpdateCommand() and GetInsertCommand() of the command builder before doing
adapter.Update(ds, dataTableName).

But my program works fine even without calling these.
Could somebody tell if I really need to call these methods ?
Without that, what kind of problem could happen?
SqlConnection conn = new SqlConnection(CONNECTION_STRING);

            string dataTableName = "PRICE_DATA";

            DataSet ds = new DataSet(dataTableName);

            string sql = "SELECT Ticker, As_of, Updt_dt, eqy_weighted_avg_px, px_open, px_volume, asset_id, modifiedtimestamp FROM Price WHERE Updt_dt = '" + update_Date + "'";

            SqlCommand selectCMD = new SqlCommand(sql, conn);

            SqlDataAdapter da = new SqlDataAdapter(selectCMD);

            SqlCommandBuilder builder = new SqlCommandBuilder(da);




                da.Fill(ds, dataTableName);


            catch (SqlException ex)


                throw ex;


            //Setting composite PK

            DataColumn[] keys = new DataColumn[2];

            DataColumn column1 = ds.Tables[0].Columns["TICKER"];

            DataColumn column2 = ds.Tables[0].Columns["UPDT_DT"];

            keys[0] = column1;

            keys[1] = column2;

            ds.Tables[0].PrimaryKey = keys;


            foreach (Security sec in securities)


                if (sec.OpenPrice != 0 && sec.Volume != 0  && sec.WeightedAverage != 0) //if value is not available, do not insert


                    //Key Values

                    object[] myKeyValues = { sec.Ticker, sec.UpdateDate.ToString("yyyyMMdd") };

                    if (ds.Tables[dataTableName].Rows.Contains(myKeyValues))



                        DataRow existingRow = ds.Tables[dataTableName].Rows.Find(myKeyValues);

                        existingRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");

                        existingRow["PX_OPEN"] = sec.OpenPrice;

                        existingRow["PX_VOLUME"] = sec.Volume;

                        existingRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;

                        existingRow["MODIFIEDTIMESTAMP"] = DateTime.Now;





                        DataRow newRow = ds.Tables[dataTableName].NewRow();

                        newRow["TICKER"] = sec.Ticker;

                        newRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");

                        newRow["UPDT_DT"] = DateTime.Now.Date.ToString("yyyyMMdd");

                        newRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;

                        newRow["PX_OPEN"] = sec.OpenPrice;

                        newRow["PX_VOLUME"] = sec.Volume;

                        newRow["ASSET_ID"] = sec.AssetId;

                        newRow["MODIFIEDTIMESTAMP"] = DateTime.Now;





            builder.GetUpdateCommand(); //not necessary ?

            builder.GetInsertCommand();//not necessary ?


	    da.Update(ds, dataTableName);

Open in new window

Question by:Takamasa
  • 2
  • 2
LVL 96

Expert Comment

by:Bob Learned
ID: 24850354
If you reach da.Update(ds, dataTableName) without calling GetUpdateCommand and GetInsertCommand, does the SqlDataAdapter have an instance of an UpdateCommand and InsertCommand?  I don't see anything in the SqlCommandBuilder or DbCommandBuilder (base class), that would construct the commands otherwise.

Author Comment

ID: 24856811
Hi. Thank you for the response.
No, both UpdateCommand and InsertCommand are null...
LVL 96

Accepted Solution

Bob Learned earned 500 total points
ID: 24858439
Then, I would suggest that there isn't any updates or inserts, or there should have been an exception.  I always use the GetUpdateCommand, GetInsertCommand, and GetDeleteCommand with command builders.

Author Comment

ID: 24865560
Hello TheLearnedOne,
Thank you for your comment again.
Strangely the data do get inserted in my database, which made me wonder what is the use of GetInsertCommand. Anyways, I will use the GetUpdateCommand and GetInsertCommand like you suggested.
Thank you!

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
schema xmlns='http //' was not expected 3 35
Create XML 5 46
Syntax error 9 45
In WPF / C# binding a local database in code behind 1 24
It was really hard time for me to get the understanding of Delegates in C#. I went through many websites and articles but I found them very clumsy. After going through those sites, I noted down the points in a easy way so here I am sharing that unde…
This article aims to explain the working of CircularLogArchiver. This tool was designed to solve the buildup of log file in cases where systems do not support circular logging or where circular logging is not enabled
Get a first impression of how PRTG looks and learn how it works.   This video is a short introduction to PRTG, as an initial overview or as a quick start for new PRTG users.
This is a video describing the growing solar energy use in Utah. This is a topic that greatly interests me and so I decided to produce a video about it.

919 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now