Mandatory to call GetUpdateCommand of SqlCommandBuilder ?

Posted on 2009-07-13
Last Modified: 2012-05-07
I am updating/inserting database via dataset.
According to the sample code from Microsoft documentation, it is required to call GetUpdateCommand() and GetInsertCommand() of the command builder before doing
adapter.Update(ds, dataTableName).

But my program works fine even without calling these.
Could somebody tell if I really need to call these methods ?
Without that, what kind of problem could happen?
SqlConnection conn = new SqlConnection(CONNECTION_STRING);
            string dataTableName = "PRICE_DATA";
            DataSet ds = new DataSet(dataTableName);
            string sql = "SELECT Ticker, As_of, Updt_dt, eqy_weighted_avg_px, px_open, px_volume, asset_id, modifiedtimestamp FROM Price WHERE Updt_dt = '" + update_Date + "'";
            SqlCommand selectCMD = new SqlCommand(sql, conn);
            SqlDataAdapter da = new SqlDataAdapter(selectCMD);
            SqlCommandBuilder builder = new SqlCommandBuilder(da);
                da.Fill(ds, dataTableName);
            catch (SqlException ex)
                throw ex;
            //Setting composite PK
            DataColumn[] keys = new DataColumn[2];
            DataColumn column1 = ds.Tables[0].Columns["TICKER"];
            DataColumn column2 = ds.Tables[0].Columns["UPDT_DT"];
            keys[0] = column1;
            keys[1] = column2;
            ds.Tables[0].PrimaryKey = keys;
            foreach (Security sec in securities)
                if (sec.OpenPrice != 0 && sec.Volume != 0  && sec.WeightedAverage != 0) //if value is not available, do not insert
                    //Key Values
                    object[] myKeyValues = { sec.Ticker, sec.UpdateDate.ToString("yyyyMMdd") };
                    if (ds.Tables[dataTableName].Rows.Contains(myKeyValues))
                        DataRow existingRow = ds.Tables[dataTableName].Rows.Find(myKeyValues);
                        existingRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");
                        existingRow["PX_OPEN"] = sec.OpenPrice;
                        existingRow["PX_VOLUME"] = sec.Volume;
                        existingRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;
                        existingRow["MODIFIEDTIMESTAMP"] = DateTime.Now;
                        DataRow newRow = ds.Tables[dataTableName].NewRow();
                        newRow["TICKER"] = sec.Ticker;
                        newRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");
                        newRow["UPDT_DT"] = DateTime.Now.Date.ToString("yyyyMMdd");
                        newRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;
                        newRow["PX_OPEN"] = sec.OpenPrice;
                        newRow["PX_VOLUME"] = sec.Volume;
                        newRow["ASSET_ID"] = sec.AssetId;
                        newRow["MODIFIEDTIMESTAMP"] = DateTime.Now;
            builder.GetUpdateCommand(); //not necessary ?
            builder.GetInsertCommand();//not necessary ?
	    da.Update(ds, dataTableName);

Open in new window

Question by:Takamasa
  • 2
  • 2
LVL 96

Expert Comment

by:Bob Learned
ID: 24850354
If you reach da.Update(ds, dataTableName) without calling GetUpdateCommand and GetInsertCommand, does the SqlDataAdapter have an instance of an UpdateCommand and InsertCommand?  I don't see anything in the SqlCommandBuilder or DbCommandBuilder (base class), that would construct the commands otherwise.

Author Comment

ID: 24856811
Hi. Thank you for the response.
No, both UpdateCommand and InsertCommand are null...
LVL 96

Accepted Solution

Bob Learned earned 500 total points
ID: 24858439
Then, I would suggest that there isn't any updates or inserts, or there should have been an exception.  I always use the GetUpdateCommand, GetInsertCommand, and GetDeleteCommand with command builders.

Author Comment

ID: 24865560
Hello TheLearnedOne,
Thank you for your comment again.
Strangely the data do get inserted in my database, which made me wonder what is the use of GetInsertCommand. Anyways, I will use the GetUpdateCommand and GetInsertCommand like you suggested.
Thank you!

Featured Post

3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction This article series is supposed to shed some light on the use of IDisposable and objects that inherit from it. In essence, a more apt title for this article would be: using (IDisposable) {}. I’m just not sure how many people would ge…
The article shows the basic steps of integrating an HTML theme template into an ASP.NET MVC project
Two types of users will appreciate AOMEI Backupper Pro: 1 - Those with PCIe drives (and haven't found cloning software that works on them). 2 - Those who want a fast clone of their boot drive (no re-boots needed) and it can clone your drive wh…
Finds all prime numbers in a range requested and places them in a public primes() array. I've demostrated a template size of 30 (2 * 3 * 5) but larger templates can be built such 210  (2 * 3 * 5 * 7) or 2310  (2 * 3 * 5 * 7 * 11). The larger templa…

773 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question