Mandatory to call GetUpdateCommand of SqlCommandBuilder ?

Posted on 2009-07-13
Medium Priority
Last Modified: 2012-05-07
I am updating/inserting database via dataset.
According to the sample code from Microsoft documentation, it is required to call GetUpdateCommand() and GetInsertCommand() of the command builder before doing
adapter.Update(ds, dataTableName).

But my program works fine even without calling these.
Could somebody tell if I really need to call these methods ?
Without that, what kind of problem could happen?
SqlConnection conn = new SqlConnection(CONNECTION_STRING);
            string dataTableName = "PRICE_DATA";
            DataSet ds = new DataSet(dataTableName);
            string sql = "SELECT Ticker, As_of, Updt_dt, eqy_weighted_avg_px, px_open, px_volume, asset_id, modifiedtimestamp FROM Price WHERE Updt_dt = '" + update_Date + "'";
            SqlCommand selectCMD = new SqlCommand(sql, conn);
            SqlDataAdapter da = new SqlDataAdapter(selectCMD);
            SqlCommandBuilder builder = new SqlCommandBuilder(da);
                da.Fill(ds, dataTableName);
            catch (SqlException ex)
                throw ex;
            //Setting composite PK
            DataColumn[] keys = new DataColumn[2];
            DataColumn column1 = ds.Tables[0].Columns["TICKER"];
            DataColumn column2 = ds.Tables[0].Columns["UPDT_DT"];
            keys[0] = column1;
            keys[1] = column2;
            ds.Tables[0].PrimaryKey = keys;
            foreach (Security sec in securities)
                if (sec.OpenPrice != 0 && sec.Volume != 0  && sec.WeightedAverage != 0) //if value is not available, do not insert
                    //Key Values
                    object[] myKeyValues = { sec.Ticker, sec.UpdateDate.ToString("yyyyMMdd") };
                    if (ds.Tables[dataTableName].Rows.Contains(myKeyValues))
                        DataRow existingRow = ds.Tables[dataTableName].Rows.Find(myKeyValues);
                        existingRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");
                        existingRow["PX_OPEN"] = sec.OpenPrice;
                        existingRow["PX_VOLUME"] = sec.Volume;
                        existingRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;
                        existingRow["MODIFIEDTIMESTAMP"] = DateTime.Now;
                        DataRow newRow = ds.Tables[dataTableName].NewRow();
                        newRow["TICKER"] = sec.Ticker;
                        newRow["AS_OF"] = sec.AsOfDate.ToString("yyyyMMdd");
                        newRow["UPDT_DT"] = DateTime.Now.Date.ToString("yyyyMMdd");
                        newRow["EQY_WEIGHTED_AVG_PX"] = sec.WeightedAverage;
                        newRow["PX_OPEN"] = sec.OpenPrice;
                        newRow["PX_VOLUME"] = sec.Volume;
                        newRow["ASSET_ID"] = sec.AssetId;
                        newRow["MODIFIEDTIMESTAMP"] = DateTime.Now;
            builder.GetUpdateCommand(); //not necessary ?
            builder.GetInsertCommand();//not necessary ?
	    da.Update(ds, dataTableName);

Open in new window

Question by:Takamasa
  • 2
  • 2
LVL 96

Expert Comment

by:Bob Learned
ID: 24850354
If you reach da.Update(ds, dataTableName) without calling GetUpdateCommand and GetInsertCommand, does the SqlDataAdapter have an instance of an UpdateCommand and InsertCommand?  I don't see anything in the SqlCommandBuilder or DbCommandBuilder (base class), that would construct the commands otherwise.

Author Comment

ID: 24856811
Hi. Thank you for the response.
No, both UpdateCommand and InsertCommand are null...
LVL 96

Accepted Solution

Bob Learned earned 1500 total points
ID: 24858439
Then, I would suggest that there isn't any updates or inserts, or there should have been an exception.  I always use the GetUpdateCommand, GetInsertCommand, and GetDeleteCommand with command builders.

Author Comment

ID: 24865560
Hello TheLearnedOne,
Thank you for your comment again.
Strangely the data do get inserted in my database, which made me wonder what is the use of GetInsertCommand. Anyways, I will use the GetUpdateCommand and GetInsertCommand like you suggested.
Thank you!

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

This article introduced a TextBox that supports transparent background.   Introduction TextBox is the most widely used control component in GUI design. Most GUI controls do not support transparent background and more or less do not have the…
Real-time is more about the business, not the technology. In day-to-day life, to make real-time decisions like buying or investing, business needs the latest information(e.g. Gold Rate/Stock Rate). Unlike traditional days, you need not wait for a fe…
The video provides a quick and easy steps to migrate MBOX file to well known Outlook PST and Office 365. Besides this, it also supports and migrates more than 20 email clients of MBOX which include AppleMail, Opera, Thunderbird and SeaMonkey effortl…
From store locators to asset tracking and route optimization, learn how leading companies are using Google Maps APIs throughout the customer journey to increase checkout conversions, boost user engagement, and optimize order fulfillment. Powered …

624 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question