Solved

Problems with Row_Deleting in GridView

Posted on 2009-07-14
5
232 Views
Last Modified: 2012-05-07
Hi,

I'm having trouble deleting a row in GridView.  The error message states:  Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

The problem I think I'm having is finding the right code to return my datakeys.

My code is below.

Any help someone could provide would be great.

Thanks.

<asp:GridView ID="publications" runat="server"  

            AutoGenerateColumns="False"

           Width="642px" onRowDeleting="publications_RowDeleting" DataKeyNames="subjectID, publicationID">

            <Columns>

            <asp:BoundField DataField="publicationID" HeaderText="Publication ID"  ReadOnly="true" />

                <asp:TemplateField HeaderText="Subject Name">

                    <EditItemTemplate>

                        <asp:TextBox ID="subjectName" runat="server" Text='<%# Bind("subjectName") %>'></asp:TextBox>

                    </EditItemTemplate>

                    <ItemTemplate>

                        <asp:Label ID="subjectName" runat="server" Text='<%# Bind("subjectName") %>'></asp:Label>

                    </ItemTemplate>

                </asp:TemplateField>

                <asp:BoundField DataField="subjectID" ReadOnly="true"/>

                <asp:CommandField ShowDeleteButton="True" />

            

            </Columns>

        </asp:GridView>
 
 
 

protected void publications_RowDeleting(Object sender, GridViewDeleteEventArgs e)

        {

            string publicationID = publications.DataKeys[publications.SelectedIndex].Values["publicationID"].ToString();

            string subjectID = publications.DataKeys[publications.SelectedIndex].Values["subjectID"].ToString();
 

        SqlConnection conn;

        SqlCommand comm;
 

        string connectionString = ConfigurationManager.ConnectionStrings["publications"].ConnectionString;
 

        conn = new SqlConnection(connectionString);
 

        comm = new SqlCommand("Delete subjects2pub where publicationID = @publicationID and subjectID = @subjectID ", conn);

        comm.Parameters.AddWithValue("@publicationID", publicationID);

        comm.Parameters.AddWithValue("@subjectID", subjectID);

        try

        {

            conn.Open();

            comm.ExecuteNonQuery();

            BindGrid();

        }
 

        catch

        {

            MessageBox.Text = "There was an error deleting this record.";

        }

         finally

        {

            conn.Close();

        }
 

    }
 

//partial code from BindGrid() to show that I believe I've set up the DataKeyNames correctly:

BindGrid()

publications.DataKeyNames = new string[] { "publicationID" };

publications.DataKeyNames = new string[] { "subjectID" };

Open in new window

0
Comment
Question by:Finlay11
  • 2
  • 2
5 Comments
 
LVL 41

Expert Comment

by:guru_sami
ID: 24851420
You are deleting the row and a=might be the Row is not selected i.e. SelectedIndex=-1
Use e.RowIndex like below:

string publicationID = publications.DataKeys[e.RowIndex].Values["publicationID"].ToString();
string subjectID = publications.DataKeys[e.RowIndex].Values["subjectID"].ToString();
 
0
 
LVL 8

Expert Comment

by:ppittle
ID: 24851470
What's the DataSource for hte GridView?  If you configure your GridView to use a SqlDataSource or ObjectDataSource you get deleting more or less for free and it you generally don't have to worry about these head aches.  

If you're unfimiliar with SqlDataSources, here's a good tutorial:  http://www.asp.net/learn/data-access/tutorial-47-cs.aspx
0
 

Author Comment

by:Finlay11
ID: 24851471
Now I get the error:  Object reference not set to an instance of an object.
0
 
LVL 41

Accepted Solution

by:
guru_sami earned 500 total points
ID: 24851594
looks due to this:
publications.DataKeyNames = new string[] { "publicationID" };
publications.DataKeyNames = new string[] { "subjectID" };

Try this:
publications.DataKeyNames = new string[] { "publicationID" ,"subjectID" };
0
 

Author Closing Comment

by:Finlay11
ID: 31603323
That was it!  Thanks so much
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

User art_snob (http://www.experts-exchange.com/M_6114203.html) encountered strange behavior of Android Web browser on his Mobile Web site. It took a while to find the true cause. It happens so, that the Android Web browser (at least up to OS ver. 2.…
Introduction This article shows how to use the open source plupload control to upload multiple images. The images are resized on the client side before uploading and the upload is done in chunks. Background I had to provide a way for user…
This tutorial gives a high-level tour of the interface of Marketo (a marketing automation tool to help businesses track and engage prospective customers and drive them to purchase). You will see the main areas including Marketing Activities, Design …
As a trusted technology advisor to your customers you are likely getting the daily question of, ‘should I put this in the cloud?’ As customer demands for cloud services increases, companies will see a shift from traditional buying patterns to new…

863 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

26 Experts available now in Live!

Get 1:1 Help Now