Solved

Problems with Row_Deleting in GridView

Posted on 2009-07-14
5
234 Views
Last Modified: 2012-05-07
Hi,

I'm having trouble deleting a row in GridView.  The error message states:  Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

The problem I think I'm having is finding the right code to return my datakeys.

My code is below.

Any help someone could provide would be great.

Thanks.

<asp:GridView ID="publications" runat="server"  
            AutoGenerateColumns="False"
           Width="642px" onRowDeleting="publications_RowDeleting" DataKeyNames="subjectID, publicationID">
            <Columns>
            <asp:BoundField DataField="publicationID" HeaderText="Publication ID"  ReadOnly="true" />
                <asp:TemplateField HeaderText="Subject Name">
                    <EditItemTemplate>
                        <asp:TextBox ID="subjectName" runat="server" Text='<%# Bind("subjectName") %>'></asp:TextBox>
                    </EditItemTemplate>
                    <ItemTemplate>
                        <asp:Label ID="subjectName" runat="server" Text='<%# Bind("subjectName") %>'></asp:Label>
                    </ItemTemplate>
                </asp:TemplateField>
                <asp:BoundField DataField="subjectID" ReadOnly="true"/>
                <asp:CommandField ShowDeleteButton="True" />
            
            </Columns>
        </asp:GridView>
 
 
 
protected void publications_RowDeleting(Object sender, GridViewDeleteEventArgs e)
        {
            string publicationID = publications.DataKeys[publications.SelectedIndex].Values["publicationID"].ToString();
            string subjectID = publications.DataKeys[publications.SelectedIndex].Values["subjectID"].ToString();
 
        SqlConnection conn;
        SqlCommand comm;
 
        string connectionString = ConfigurationManager.ConnectionStrings["publications"].ConnectionString;
 
        conn = new SqlConnection(connectionString);
 
        comm = new SqlCommand("Delete subjects2pub where publicationID = @publicationID and subjectID = @subjectID ", conn);
        comm.Parameters.AddWithValue("@publicationID", publicationID);
        comm.Parameters.AddWithValue("@subjectID", subjectID);
        try
        {
            conn.Open();
            comm.ExecuteNonQuery();
            BindGrid();
        }
 
        catch
        {
            MessageBox.Text = "There was an error deleting this record.";
        }
         finally
        {
            conn.Close();
        }
 
    }
 
//partial code from BindGrid() to show that I believe I've set up the DataKeyNames correctly:
BindGrid()
publications.DataKeyNames = new string[] { "publicationID" };
publications.DataKeyNames = new string[] { "subjectID" };

Open in new window

0
Comment
Question by:Finlay11
  • 2
  • 2
5 Comments
 
LVL 41

Expert Comment

by:guru_sami
ID: 24851420
You are deleting the row and a=might be the Row is not selected i.e. SelectedIndex=-1
Use e.RowIndex like below:

string publicationID = publications.DataKeys[e.RowIndex].Values["publicationID"].ToString();
string subjectID = publications.DataKeys[e.RowIndex].Values["subjectID"].ToString();
 
0
 
LVL 8

Expert Comment

by:ppittle
ID: 24851470
What's the DataSource for hte GridView?  If you configure your GridView to use a SqlDataSource or ObjectDataSource you get deleting more or less for free and it you generally don't have to worry about these head aches.  

If you're unfimiliar with SqlDataSources, here's a good tutorial:  http://www.asp.net/learn/data-access/tutorial-47-cs.aspx
0
 

Author Comment

by:Finlay11
ID: 24851471
Now I get the error:  Object reference not set to an instance of an object.
0
 
LVL 41

Accepted Solution

by:
guru_sami earned 500 total points
ID: 24851594
looks due to this:
publications.DataKeyNames = new string[] { "publicationID" };
publications.DataKeyNames = new string[] { "subjectID" };

Try this:
publications.DataKeyNames = new string[] { "publicationID" ,"subjectID" };
0
 

Author Closing Comment

by:Finlay11
ID: 31603323
That was it!  Thanks so much
0

Featured Post

Is Your AD Toolbox Looking More Like a Toybox?

Managing Active Directory can get complicated.  Often, the native tools for managing AD are just not up to the task.  The largest Active Directory installations in the world have relied on one tool to manage their day-to-day administration tasks: Hyena. Start your trial today.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In an ASP.NET application, I faced some technical problems. In this article, I list them out and show the solutions that I found.  I hope it will be useful. Problem: After closing a pop-up window, the parent page should be refreshed automaticall…
In .NET 2.0, Microsoft introduced the Web Site.  This was the default way to create a web Project in Visual Studio 2005.  In Visual Studio 2008, the Web Application has been restored as the default web Project in Visual Studio/.NET 3.x The Web Si…
Nobody understands Phishing better than an anti-spam company. That’s why we are providing Phishing Awareness Training to our customers. According to a report by Verizon, only 3% of targeted users report malicious emails to management. With compan…
A short tutorial showing how to set up an email signature in Outlook on the Web (previously known as OWA). For free email signatures designs, visit https://www.mail-signatures.com/articles/signature-templates/?sts=6651 If you want to manage em…

803 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question