Error 3061 too few parameters / QueryDef Parameter Problem

Hi all,

First time posting and pretty new at this, so apologies in advance for any stupidity...I'm building a bookings database in MS Access and have created a command button ("Command25") on a form ("subfrmBooking") which is supposed to send a confirmation email to a student who is booked in for an appointment with an attachment ("rptBookingConfirmationEmail").

I have created a query ("qryBookingIDAndStudentEmail") which selects "StudentEmail" from a table ("Student") and BookingID from a table ("Booking") where Booking.BookingID = subfrmBooking.BookingID.  The query seems to work fine; however, when I try to click the command button I am confronted with a pop-up informing me of Error 3061:  Too few parameters.  Expected 1"

I've spent hours trawling previous posts and other sites, and I believe that the problem may relate to my having to define the parameters in the vba editor using QueryDef, but can't seem to get my head around how to apply it to my code, which I've pasted below in the hope that someone might be able to help.

Any advice would be much appreciated!
Private Sub Command25_Click()
On Error GoTo Err_Command25_Click
Dim dbs As DAO.Database
Dim rst As DAO.Recordset
Dim strSQL As String
Dim lngBookingID As Long
Dim strEmail As String
strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail"
Set dbs = CurrentDb()
Set rst = dbs.OpenRecordset(strSQL)
    Do While Not rst.EOF
        lngBookingID = rst!BookingID
        strEmail = rst!StudentEmail
        DoCmd.SendObject acSendReport, "rptBookingConfirmationEmail", acFormatHTML, strEmail, , , "Confirmation of Needs Assessment Booking.", "Please find attached details of your pending appointment at CLASS", True
lngpubBookingID = 0
MsgBox "Done", vbInformation
Set rst = Nothing
Set dbs = Nothing
    On Error Resume Next
    Set rst = Nothing
    Set dbs = Nothing
    Exit Sub
    If Err.Number = 2501 Then
        Resume Exit_Command25_Click
        MsgBox "There was an error sending the email" & vbCrLf & vbCrLf & Err.Number & ": " & vbCrLf & vbCrLf & Error, vbExclamation
        Resume Exit_Command25_Click
End If
End Sub

Open in new window

Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Rey Obrero (Capricorn1)Commented:
this line is possibly causing the error

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail"

post the sql view of the query  qryBookingIDAndStudentEmail

you might be using a wrong field name or mispelled field name or query
mattdc1978Author Commented:
Thanks for having a look.  The SQL for the query is as follows.

SELECT Student.StudentEmail, Booking.BookingID
FROM Student INNER JOIN (StudentCourse INNER JOIN Booking ON StudentCourse.StudentCourseID = Booking.StudentCourseID) ON Student.StudentID = StudentCourse.StudentID
WHERE (((Booking.BookingID)=[Forms]![frmStudentBooking]![subfrmBooking]![BookingID]));

Not sure if this is relevant, but initially I forgot to add any criteria to qryBookingIDAndStudentEmail.  At that point the command button did everything right (opened Outlook, filled in subject and body text and attached report); with the exception of always obtaining the email address from the first record which is a fairly major thing!
Is qryBookingIDAndStudentEmail a parameter query?
If so you can't use it in the way you are trying to and you will need a different approach.
But can you confirm this first?

10 Tips to Protect Your Business from Ransomware

Did you know that ransomware is the most widespread, destructive malware in the world today? It accounts for 39% of all security breaches, with ransomware gangsters projected to make $11.5B in profits from online extortion by 2019.

mattdc1978Author Commented:
Yes, it is a parameter query.  Have just this second posted the SQL which includes details.
I think the simplest approach is to take the Where clause out of the saved query and put it into the recordset sql

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail  "
strsql = strsql & "wHERE BookingID= " & [Forms]![frmStudentBooking]![subfrmBooking].Form![BookingID]

this assumes bookingid is a number.

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
mattdc1978Author Commented:
Yep, BookingID is a number.

I've put that code into mine and it's telling me there is an error 3075: Syntax error (missing operator) in query expression 'BookingID='

I'm not sure if this is right, but I did also try changing that line to:

strSQL=strSQL & "WHERE BookingID=" & "[Forms]![frmStudentBooking]![subfrmBooking].Form![BookingID]"

When I tried that, it gave me error 3061 - too few parameters - again.
Rey Obrero (Capricorn1)Commented:
thats right, peter is on the right track
copy and paste this

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail"
strSQL=strSQL & " WHERE BookingID=" & [Forms]![frmStudentBooking]![subfrmBooking].Form![BookingID]
!peter is on the right track"???
On the right track indeed.
If yours is right, Cap,  then mine is too.

Rey Obrero (Capricorn1)Commented:
i know, i just want the asker to copy and paste the sql string.
pardon me if my post lacks explanation.
Leigh PurvisDatabase DeveloperCommented:
Just to offer a different option...
A standard function to open your recordsets to allow for Form expressions as parameters in case they're part of it.
The function fDAOGenericRst in this thread.
mattdc1978Author Commented:
Guys - thank you so much for this.  It now seems to work perfectly.  :)
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft Access

From novice to tech pro — start learning today.