Solved

Error 3061 too few parameters / QueryDef Parameter Problem

Posted on 2009-07-14
11
965 Views
Last Modified: 2013-11-29
Hi all,

First time posting and pretty new at this, so apologies in advance for any stupidity...I'm building a bookings database in MS Access and have created a command button ("Command25") on a form ("subfrmBooking") which is supposed to send a confirmation email to a student who is booked in for an appointment with an attachment ("rptBookingConfirmationEmail").

I have created a query ("qryBookingIDAndStudentEmail") which selects "StudentEmail" from a table ("Student") and BookingID from a table ("Booking") where Booking.BookingID = subfrmBooking.BookingID.  The query seems to work fine; however, when I try to click the command button I am confronted with a pop-up informing me of Error 3061:  Too few parameters.  Expected 1"

I've spent hours trawling previous posts and other sites, and I believe that the problem may relate to my having to define the parameters in the vba editor using QueryDef, but can't seem to get my head around how to apply it to my code, which I've pasted below in the hope that someone might be able to help.

Any advice would be much appreciated!
Private Sub Command25_Click()

On Error GoTo Err_Command25_Click

Dim dbs As DAO.Database

Dim rst As DAO.Recordset

Dim strSQL As String

Dim lngBookingID As Long

Dim strEmail As String
 

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail"

Set dbs = CurrentDb()

Set rst = dbs.OpenRecordset(strSQL)
 

rst.MoveFirst
 

    Do While Not rst.EOF

        lngBookingID = rst!BookingID

        strEmail = rst!StudentEmail

        DoCmd.SendObject acSendReport, "rptBookingConfirmationEmail", acFormatHTML, strEmail, , , "Confirmation of Needs Assessment Booking.", "Please find attached details of your pending appointment at CLASS", True

        rst.MoveNext

    Loop

lngpubBookingID = 0
 

MsgBox "Done", vbInformation
 

rst.Close

Set rst = Nothing

dbs.Close

Set dbs = Nothing
 

Exit_Command25_Click:

    On Error Resume Next

    rst.Close

    Set rst = Nothing

    dbs.Close

    Set dbs = Nothing

    Exit Sub
 

Err_Command25_Click:

    If Err.Number = 2501 Then

        Resume Exit_Command25_Click

    Else

        MsgBox "There was an error sending the email" & vbCrLf & vbCrLf & Err.Number & ": " & vbCrLf & vbCrLf & Error, vbExclamation

        Resume Exit_Command25_Click

End If

End Sub

Open in new window

0
Comment
Question by:mattdc1978
  • 4
  • 3
  • 3
  • +1
11 Comments
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 24851313
this line is possibly causing the error

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail"

post the sql view of the query  qryBookingIDAndStudentEmail

you might be using a wrong field name or mispelled field name or query
0
 

Author Comment

by:mattdc1978
ID: 24851479
Thanks for having a look.  The SQL for the query is as follows.

SELECT Student.StudentEmail, Booking.BookingID
FROM Student INNER JOIN (StudentCourse INNER JOIN Booking ON StudentCourse.StudentCourseID = Booking.StudentCourseID) ON Student.StudentID = StudentCourse.StudentID
WHERE (((Booking.BookingID)=[Forms]![frmStudentBooking]![subfrmBooking]![BookingID]));

Not sure if this is relevant, but initially I forgot to add any criteria to qryBookingIDAndStudentEmail.  At that point the command button did everything right (opened Outlook, filled in subject and body text and attached report); with the exception of always obtaining the email address from the first record which is a fairly major thing!
0
 
LVL 77

Expert Comment

by:peter57r
ID: 24851524
Is qryBookingIDAndStudentEmail a parameter query?
If so you can't use it in the way you are trying to and you will need a different approach.
But can you confirm this first?

0
 

Author Comment

by:mattdc1978
ID: 24851573
Yes, it is a parameter query.  Have just this second posted the SQL which includes details.
0
 
LVL 77

Accepted Solution

by:
peter57r earned 300 total points
ID: 24851631
I think the simplest approach is to take the Where clause out of the saved query and put it into the recordset sql

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail  "
strsql = strsql & "wHERE BookingID= " & [Forms]![frmStudentBooking]![subfrmBooking].Form![BookingID]

this assumes bookingid is a number.
0
Complete Microsoft Windows PC® & Mac Backup

Backup and recovery solutions to protect all your PCs & Mac– on-premises or in remote locations. Acronis backs up entire PC or Mac with patented reliable disk imaging technology and you will be able to restore workstations to a new, dissimilar hardware in minutes.

 

Author Comment

by:mattdc1978
ID: 24851859
Yep, BookingID is a number.

I've put that code into mine and it's telling me there is an error 3075: Syntax error (missing operator) in query expression 'BookingID='

I'm not sure if this is right, but I did also try changing that line to:

strSQL=strSQL & "WHERE BookingID=" & "[Forms]![frmStudentBooking]![subfrmBooking].Form![BookingID]"

When I tried that, it gave me error 3061 - too few parameters - again.
0
 
LVL 119

Assisted Solution

by:Rey Obrero
Rey Obrero earned 200 total points
ID: 24852010
thats right, peter is on the right track
copy and paste this

strSQL = "SELECT BookingID,StudentEmail From qryBookingIDAndStudentEmail"
strSQL=strSQL & " WHERE BookingID=" & [Forms]![frmStudentBooking]![subfrmBooking].Form![BookingID]
0
 
LVL 77

Expert Comment

by:peter57r
ID: 24852548
!peter is on the right track"???
On the right track indeed.
If yours is right, Cap,  then mine is too.

0
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 24852606
i know, i just want the asker to copy and paste the sql string.
pardon me if my post lacks explanation.
0
 
LVL 44

Expert Comment

by:Leigh Purvis
ID: 24854609
Just to offer a different option...
A standard function to open your recordsets to allow for Form expressions as parameters in case they're part of it.
The function fDAOGenericRst in this thread.
0
 

Author Closing Comment

by:mattdc1978
ID: 31603333
Guys - thank you so much for this.  It now seems to work perfectly.  :)
0

Featured Post

Do You Know the 4 Main Threat Actor Types?

Do you know the main threat actor types? Most attackers fall into one of four categories, each with their own favored tactics, techniques, and procedures.

Join & Write a Comment

Suggested Solutions

In the previous article, Using a Critera Form to Filter Records (http://www.experts-exchange.com/A_6069.html), the form was basically a data container storing user input, which queries and other database objects could read. The form had to remain op…
Today's users almost expect this to happen in all search boxes. After all, if their favourite search engine juggles with tens of thousand keywords while they type, and suggests matching phrases on the fly, why shouldn't they expect the same from you…
Get people started with the utilization of class modules. Class modules can be a powerful tool in Microsoft Access. They allow you to create self-contained objects that encapsulate functionality. They can easily hide the complexity of a process from…
Familiarize people with the process of retrieving data from SQL Server using an Access pass-thru query. Microsoft Access is a very powerful client/server development tool. One of the ways that you can retrieve data from a SQL Server is by using a pa…

759 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now